From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id QBTbAqarlWP6eQAAbAwnHQ (envelope-from ) for ; Sun, 11 Dec 2022 11:06:30 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id IFzCAqarlWPh5AAAauVa8A (envelope-from ) for ; Sun, 11 Dec 2022 11:06:30 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B76FCA03A for ; Sun, 11 Dec 2022 11:06:29 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4JDB-00007s-Oh; Sun, 11 Dec 2022 05:05:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4JCv-00006x-42 for emacs-orgmode@gnu.org; Sun, 11 Dec 2022 05:05:20 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4JCs-0004dZ-JO for emacs-orgmode@gnu.org; Sun, 11 Dec 2022 05:05:16 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id A3AB5240028 for ; Sun, 11 Dec 2022 11:05:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1670753112; bh=1BF+LrmeIaPqzhSPdVUcEcOuQ7LNfGt+srdZyOdPhAg=; h=From:To:Cc:Subject:Date:From; b=kE9YLi5OB7EidGpEXJnOyhsXMHohC0ZKxhnGtG8YlRugPs5yoFDfe8axHvCn8b6Hz Yn17TV6SpqNMQbmaw/xfqU0f7vpvnvUOYYtAlUmgwXSwu29w+2EZF2XU/u3J91DMUH nXuGh14JxV+up5n12muEdh/3pgTViP3EoDwsnPLqJC8VO7n8VHLKOl6tmUf2hbQcu9 zUzz110bUNNVBauK+oFqyX9BKq5R9RuET87yTujFnjQHu/ygPtSEE6XDB49oNct+z3 0bXj5C9adumeaWUeuJFV7tiV7mFKGwoFYswnkt3nlvp8Lo/tLNPUeECyOUzhHrGR8E C7fIra4kKhMrQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NVL3W181Sz9rxK; Sun, 11 Dec 2022 11:05:11 +0100 (CET) From: Ihor Radchenko To: Pedro Andres Aranda Gutierrez Cc: Org Mode List Subject: Re: PATCH: include controlling language= in my previous patch In-Reply-To: References: Date: Sun, 11 Dec 2022 10:05:09 +0000 Message-ID: <87cz8qdzmy.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670753189; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=qp+ll3KIKJZPTZ7eCNYsh/Tk7pK3T9VDSmsE5BcjB9I=; b=VGiEU87NIb2gZC8B9m4HanlI8scUX+Wb80ZO7s842kagbfRtpbHUYRsTFOLe61zQ9dYhhI GQ1NuZeqiP/fPViifZOWMKXYgEM/DS1FIHb8O3PU+27bteaCops5d7rjmWn2NsXmalTV7/ 5wEDA8Q8JIWuluMAIE75MHEgcrqKle4asY+1jHUHTLHzRUQPSytzzr9XRemOooMg7qP58g ZxgUQ8XBcNAdWIb5KeEFYVVDk8+eVSm4+Vjlgrolt3RW5tKXQkwGmuIU74+2qo0Wse3G92 vTc+4Un7xnYSKXzCQbTM6gOjhQs+yzFY+Nbv7tZVw02DelzKyvZIxwPlr1TSoQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=kE9YLi5O; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670753189; a=rsa-sha256; cv=none; b=XlNFmaEjKTLn935KM3U6/d0/b3MyEslygMl8XgaMKeSZao2ka9vGAazg1cA7gOB1VfL3Db klhsh+upXWPd1RMxkKZo9T0UWKbAHlaWUYfzAhk0RtgQdpmu8c1oEPjWPUWhR8W3G8meN8 XEJMkQ229UPhGwj1nks4br1fj6dlyWcfaWMHDP6YhQof92YZzpWBP/HPhqeS5tEviYY+9b ywTrGJ57Q+xTOZ0f8WQ6TwvM3JUeHIRPuBAB7pdID5sW7C/tdCUrJxfTVjPvucTM3QPOBL KT140z5DVhLpwFjRs+PN6VfcsXfz2Mzg++YDTYZ/RkgpOVoiGdA9wbk3eHjvmQ== X-Migadu-Spam-Score: -9.23 X-Spam-Score: -9.23 X-Migadu-Queue-Id: B76FCA03A X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=kE9YLi5O; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-TUID: LnFo87DYqC/5 Note: This email thread is a followup for https://orgmode.org/list/CAO48Bk_6bqKgp1MgnZaARYku2+St6R1D4Bziq5NzMWNEWqfitw@mail.gmail.com Pedro Andres Aranda Gutierrez writes: > I have a second version of my previous patch, inlcuing and extra variable > to control whether you want to include the language= or not. It is made in > a backwards-compatible way. Default is to include it and you have to > > (setq org-latex-listings-src-omit-language t) > > to omit language= Makes sense from a first glance. > + (when label ; label= w/o label makes little sense > + `(("label" ,(org-latex--label src-block info)))) > + (when caption-str ; caption= w/o caption makes little sense > + `(("caption" ,caption-str)) > + `(("captionpos" ,(if caption-above-p "t" "b")))) ; as does captionpos w/o caption This is not true. We do need that empty caption/label. See https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=eaaa5c2e4 and https://orgmode.org/list/534BEAFB.4080607@gmx.de Also, if you can, please create a proper patch instead of diff. See https://orgmode.org/worg/org-contribute.html#first-patch -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at