From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60122: 29.0.60; c-ts-mode breaks with '"' separated macros Date: Fri, 16 Dec 2022 20:30:39 +0100 Message-ID: <87cz8jrvs0.fsf@thornhill.no> References: <84db9d18bd013acbff59890f895e26f0@sadiqpk.org> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30543"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60122@debbugs.gnu.org, casouri@gmail.com To: Mohammed Sadiq Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 16 20:31:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p6GQM-0007mU-UM for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Dec 2022 20:31:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6GQI-0000wY-Df; Fri, 16 Dec 2022 14:31:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6GQB-0000vR-3e for bug-gnu-emacs@gnu.org; Fri, 16 Dec 2022 14:31:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6GQA-0004HW-Py for bug-gnu-emacs@gnu.org; Fri, 16 Dec 2022 14:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p6GQA-0005tT-Lf for bug-gnu-emacs@gnu.org; Fri, 16 Dec 2022 14:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Dec 2022 19:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60122 X-GNU-PR-Package: emacs Original-Received: via spool by 60122-submit@debbugs.gnu.org id=B60122.167121904722647 (code B ref 60122); Fri, 16 Dec 2022 19:31:02 +0000 Original-Received: (at 60122) by debbugs.gnu.org; 16 Dec 2022 19:30:47 +0000 Original-Received: from localhost ([127.0.0.1]:51163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6GPu-0005tD-St for submit@debbugs.gnu.org; Fri, 16 Dec 2022 14:30:47 -0500 Original-Received: from out-6.mta0.migadu.com ([91.218.175.6]:12961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6GPs-0005t6-21 for 60122@debbugs.gnu.org; Fri, 16 Dec 2022 14:30:45 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1671219042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gTHCZ1StjXETTilpCay3kzI4jq+rUrgETAp7SBf6jWk=; b=pwDhIqL5dEUZISfOexh/5hrmzfjZNtrMpY50q3q3QQ6UG1qWLdiBKlsdN214m2N8vDLxcd sNdm4ubSQ596XYxn/Dq4FKeyP2b8Nyg3r9H3r/ghPYRZ5YE5oQPs4jywhHzK8pVRu06Fxb UKpZ/CHUBrNo2W4TJ78zXQrg+6YV9sfhaf6vEAxm4Oewx9M2M++i0Pp8HQURIU4QkJXOqd F7h3xSNwW03oLhPjqYqUqgYPqk8mbLmnpsWCnY1Q1A09jMMnItd5nnbnggvLL2kfP/CylO VM1uOvBio0JsrX/6dy6gRb6x/5yoi9hyItq8kc40iRXGCnQVF32zUqt7JIYUHQ== In-Reply-To: <84db9d18bd013acbff59890f895e26f0@sadiqpk.org> (Mohammed Sadiq's message of "Fri, 16 Dec 2022 20:22:26 +0530") X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251239 Archived-At: Mohammed Sadiq writes: > The following code is parsed wrong with c-ts-mode: > > > #include > > int > main (void) > { > GFileInfo *info; > GFile *file; > > file = g_file_new_for_path ("some/path"); > info = g_file_query_info (file, > G_FILE_ATTRIBUTE_THUMBNAIL_IS_VALID "," > G_FILE_ATTRIBUTE_THUMBNAILING_FAILED "," > G_FILE_ATTRIBUTE_TIME_MODIFIED "," > G_FILE_ATTRIBUTE_STANDARD_FAST_CONTENT_TYPE, > G_FILE_QUERY_INFO_NONE, > NULL, NULL); > } > > > c-ts-mode doesn't assume G_FILE_ATTRIBUTE_THUMBNAIL_IS_VALID (and > others) to be a string (or some function/macro call that results in a > string) resulting in broken font locking and tab indentation. > > The same code seems to work fine with c-mode > Hi! If you use treesit-explore-mode, you can see that the tree-sitter parser returns this ast: (expression_statement (assignment_expression left: (identifier) operator: = right: (call_expression function: (identifier) arguments: (argument_list ( (identifier) , (identifier) (ERROR ") , (string_literal " (ERROR (identifier)) ") , (string_literal " (ERROR (identifier)) ") , (ERROR ") (identifier) , (identifier) , (null) , (null) )))) ;) Because tree-sitter fails to parse this there's only so much we can do. I think you should file this as a bug at the parser issue tracker over at github[0]. Maybe it's a known problem already? Theo [0]: https://github.com/tree-sitter/tree-sitter-c/issues