From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument Date: Thu, 19 Jan 2023 16:27:39 +0100 Message-ID: <87cz7a1r4k.fsf@gmail.com> References: <878ri2gx3r.fsf@daniel-mendler.de> <87r0vtaxtu.fsf@gmail.com> <3d2cc069-d258-f0b6-9679-eb13a1415202@daniel-mendler.de> <87edrsb5o3.fsf@gmail.com> <9d95e891-22ad-d700-3fab-69948a8a1a17@daniel-mendler.de> <87o7qualwa.fsf@gmail.com> <17aa757a-935d-547c-b432-9529d1ed6d6b@daniel-mendler.de> <87k01iakxz.fsf@gmail.com> <5bbc8220-6745-a123-a143-6b740caec8fa@daniel-mendler.de> <87bkmuainz.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14514"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 60867@debbugs.gnu.org To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 19 16:28:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIWpt-0003YY-Js for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 19 Jan 2023 16:28:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pIWpg-0003hF-43; Thu, 19 Jan 2023 10:28:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIWpe-0003gq-Lo for bug-gnu-emacs@gnu.org; Thu, 19 Jan 2023 10:28:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pIWpe-0002HQ-Ao for bug-gnu-emacs@gnu.org; Thu, 19 Jan 2023 10:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pIWpd-0005kl-Pz for bug-gnu-emacs@gnu.org; Thu, 19 Jan 2023 10:28:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Jan 2023 15:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60867 X-GNU-PR-Package: emacs Original-Received: via spool by 60867-submit@debbugs.gnu.org id=B60867.167414207222094 (code B ref 60867); Thu, 19 Jan 2023 15:28:01 +0000 Original-Received: (at 60867) by debbugs.gnu.org; 19 Jan 2023 15:27:52 +0000 Original-Received: from localhost ([127.0.0.1]:44458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIWpT-0005kH-Q6 for submit@debbugs.gnu.org; Thu, 19 Jan 2023 10:27:52 -0500 Original-Received: from mail-wm1-f54.google.com ([209.85.128.54]:46960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIWpR-0005k2-7Y for 60867@debbugs.gnu.org; Thu, 19 Jan 2023 10:27:50 -0500 Original-Received: by mail-wm1-f54.google.com with SMTP id m5-20020a05600c4f4500b003db03b2559eso1517337wmq.5 for <60867@debbugs.gnu.org>; Thu, 19 Jan 2023 07:27:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=KRYTQ9OwDYQdk5EXUzTt+JuZ8QKdPmAzMQowDdM+/Cw=; b=SYHOEvy8jdCaGi5L6ft0JcsY0zhc9aH13/PRLcZJokNlURS/dnT8HZXS66sAVl/7xh stFj9bZtfiuMYsFRUi8HwOuo6g7EX+Te1QNg6hYbYOPAVgejbd64/tcchUb1AkqPc3UP JwAh7mVWXgVKOKjEj9wOY8CNxjgcviyk96KDnZ1V1cnzYmke8C9teMqcv8TPO1dAkQZL 6uXyRQdfpu5JDMb78MMAgk3J3yyKFVplg4WN2IXwtImxqM0ROpBeMb3iNQR1KQRC8mf1 wNkKKc6fZc9MQcuEt9SiiFg4dQG1CymMWddSPa7+Z0nrSzwr6pam8IJZkTsv7I2KF5T/ PX7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KRYTQ9OwDYQdk5EXUzTt+JuZ8QKdPmAzMQowDdM+/Cw=; b=3rQ945W5247NZZuT7ss3frwXom2L/a1IBWMZFEU4dqnmecVRD7V97wpOf2EjLRjZhK xHkKrEvr1v32RKOLqGxtsjSsSeciDEdYCiiF9vD3L+dnl7vatDi391FQJ/WhgJGcsRk5 mN49c2Fa48Eh9w+w+J3KHNwOevxB9bhUq+TwlCgzSO0JYeso0khpYL/cKj2hFO3nGo6d WeKpKkjcvbljclp74DPdj1ZIMySF30SlKQagS0Bu16Zv5rpwYvn/MGIKIAI4JAnAXgH7 3F/Ju1+FiadPFU0P8BFoNyXUqoHgUWOldNv1Y6sod0IewfSOzN3fIU0qI0x7ueon4sxB cTzw== X-Gm-Message-State: AFqh2kruoNSdFtp1ffpWS+MKaBzN412jyf6O4rH6mLHtrV2mnoJFxAJu N0OXc9Nd8GxkhqIdV2I1ll2QWBPnqvk= X-Google-Smtp-Source: AMrXdXtN27pP/SXMHde/wLaGcDjhSqWb9ENuM8NeTg5Tt8HJdgIrKQ9IgzTtDMgCikpOjalRnuBCsg== X-Received: by 2002:a05:600c:1e21:b0:3d0:7fee:8a70 with SMTP id ay33-20020a05600c1e2100b003d07fee8a70mr11011190wmb.19.1674142062880; Thu, 19 Jan 2023 07:27:42 -0800 (PST) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id d3-20020a05600c34c300b003dab77aa911sm4979212wmq.23.2023.01.19.07.27.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 07:27:42 -0800 (PST) In-Reply-To: (Daniel Mendler's message of "Thu, 19 Jan 2023 12:19:19 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253714 Archived-At: >>>>> On Thu, 19 Jan 2023 12:19:19 +0100, Daniel Mendler said: Daniel> On 1/19/23 12:05, Robert Pluim wrote: Daniel> My point is that it would be expected from `key-parse' that it = is Daniel> equally strict as the other keymap functions, otherwise we miss= bugs Daniel> where `key-parse' wasn't used properly. Furthermore we would av= oid all Daniel> these `key-valid-p` and `keymap--check' calls, as I mentioned. `key-parse' should perhaps be renamed to `key--parse' as it=CA=BCs very much internal. Daniel> Of course `kbd' should stay as lax as it has always been. Daniel> It is mostly used internally. There are only 9 call sites in th= e Emacs code. >> I=CA=BCll make >> that change locally and see what happens. (Update: it did not go wel= l, >> there are test-suite failures). Daniel> This is hardly an argument. You should check all the call sites= and Daniel> adjust accordingly. In particular `kbd' must pass 'noerror. I w= ould Daniel> expect this to be a pretty small patch given the small number o= f call sites. The test suite shows what people=CA=BCs assumptions are, so such failures are valuable. It may be enough to use 'noerror in `kbd', indeed, but I haven=CA=BCt checked that yet. Or maybe the test suite needs adjusting. Robert --=20