From: Mickey Petersen <mickey@masteringemacs.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 61043@debbugs.gnu.org
Subject: bug#61043: 30.0.50; `json-ts-mode': invalid font lock rule
Date: Wed, 25 Jan 2023 07:29:23 +0000 [thread overview]
Message-ID: <87cz73vzpi.fsf@masteringemacs.org> (raw)
In-Reply-To: <c689fc66-81cd-3475-5c41-ada50fab8a9a@yandex.ru>
Dmitry Gutov <dgutov@yandex.ru> writes:
> On 24/01/2023 22:09, Mickey Petersen wrote:
>> There's a comment font lock rule in `json-ts-mode'. However, that is
>> illegal and againt the JSON spec, and indeed the search query fails
>> because `comment' is not a valid node type.
>
> When you say it fails, how does that look to you?
>
> Here's an example of a JSON file (or, more accurately, a JSON-superset
> file) with comments:
> https://raw.githubusercontent.com/huytd/vscode-espresso-tutti/master/themes/Espresso%20Tutti-color-theme.json
>
> The JSON tree-sitter grammar seems to parse them correctly as comments
> ("comment" node type), and json-ts-mode highlights them as comments
> correctly as a result.
It may well be my JSON grammar file that is different then. Which is
perhaps even worse: it is easy to find yourself with one of two
versions.
next prev parent reply other threads:[~2023-01-25 7:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 20:09 bug#61043: 30.0.50; `json-ts-mode': invalid font lock rule Mickey Petersen
2023-01-24 21:08 ` Drew Adams
2023-01-24 21:10 ` Drew Adams
2023-01-25 7:27 ` Mickey Petersen
2023-01-25 1:28 ` Dmitry Gutov
2023-01-25 7:29 ` Mickey Petersen [this message]
2023-01-25 12:08 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-25 12:09 ` Mickey Petersen
2023-01-25 13:14 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-25 13:30 ` Dmitry Gutov
2023-01-25 13:00 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz73vzpi.fsf@masteringemacs.org \
--to=mickey@masteringemacs.org \
--cc=61043@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.