bug#61268: 30.0.50; [PATCH] Deprecate called-interactively-p

bug#61268: 30.0.50; [PATCH] Deprecate called-interactively-p

[dick.r.chiang]

[-- Attachment #1: Type: text/plain, Size: 37 bytes --]


Deprecate `called-interactively-p`.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Deprecate-called-interactively-p.patch --]
[-- Type: text/x-diff, Size: 13880 bytes --]

From ddde988f37c5b8a0ca688b62ab6bc66f075dbcf0 Mon Sep 17 00:00:00 2001
From: dickmao <dick.r.chiang@gmail.com>
Date: Fri, 3 Feb 2023 12:12:35 -0500
Subject: [PATCH] Deprecate called-interactively-p

* doc/lispref/commands.texi (Distinguish Interactive): Deprecate.
* lisp/subr.el (called-interactively-p): Deprecate.
(interactive-p): Alias.
* src/callint.c (Ffuncall_interactively): Clarify.
* test/lisp/emacs-lisp/edebug-resources/edebug-test-code.el
(edebug-test-code-called-interactively-p): Test.
* test/lisp/emacs-lisp/edebug-tests.el
(edebug-tests-keymap,
edebug-tests-call-interactively-instrumented-func,
edebug-tests-called-interactively-p): Test.
* test/lisp/emacs-lisp/nadvice-tests.el
(advice-test-called-interactively-p-filter-args): Fix.
(advice-test-called-interactively-p-around-careful): Test.
---
 doc/lispref/commands.texi                     | 91 ++++---------------
 lisp/subr.el                                  | 55 +----------
 src/callint.c                                 | 15 ++-
 .../edebug-resources/edebug-test-code.el      |  4 +
 test/lisp/emacs-lisp/edebug-tests.el          | 16 ++++
 test/lisp/emacs-lisp/nadvice-tests.el         | 15 ++-
 6 files changed, 61 insertions(+), 135 deletions(-)

diff --git a/doc/lispref/commands.texi b/doc/lispref/commands.texi
index dc78adc4520..446d44bf8b0 100644
--- a/doc/lispref/commands.texi
+++ b/doc/lispref/commands.texi
@@ -906,89 +906,30 @@ Distinguish Interactive
 @cindex distinguish interactive calls
 @cindex is this call interactive
 
-  Sometimes a command should display additional visual feedback (such
-as an informative message in the echo area) for interactive calls
-only.  There are three ways to do this.  The recommended way to test
-whether the function was called using @code{call-interactively} is to
-give it an optional argument @code{print-message} and use the
-@code{interactive} spec to make it non-@code{nil} in interactive
-calls.  Here's an example:
+The function @code{called-interactively-p} is deprecated.
 
-@example
-(defun foo (&optional print-message)
-  (interactive "p")
-  (when print-message
-    (message "foo")))
-@end example
-
-@noindent
-We use @code{"p"} because the numeric prefix argument is never
-@code{nil}.  Defined in this way, the function does display the
-message when called from a keyboard macro.
-
-  The above method with the additional argument is usually best,
-because it allows callers to say ``treat this call as interactive''.
-But you can also do the job by testing @code{called-interactively-p}.
-
-@defun called-interactively-p kind
-This function returns @code{t} when the calling function was called
-using @code{call-interactively}.
-
-The argument @var{kind} should be either the symbol @code{interactive}
-or the symbol @code{any}.  If it is @code{interactive}, then
-@code{called-interactively-p} returns @code{t} only if the call was
-made directly by the user---e.g., if the user typed a key sequence
-bound to the calling function, but @emph{not} if the user ran a
-keyboard macro that called the function (@pxref{Keyboard Macros}).  If
-@var{kind} is @code{any}, @code{called-interactively-p} returns
-@code{t} for any kind of interactive call, including keyboard macros.
-
-If in doubt, use @code{any}; the only known proper use of
-@code{interactive} is if you need to decide whether to display a
-helpful message while a function is running.
-
-A function is never considered to be called interactively if it was
-called via Lisp evaluation (or with @code{apply} or @code{funcall}).
-@end defun
-
-@noindent
-Here is an example of using @code{called-interactively-p}:
+Instead add to the subject function an optional argument with
+interactive spec @code{p} (or another code that cannot take on a
+@code{nil} value).  This argument is thus assured to be non-@code{nil}
+when the subject function assigns arguments via the @code{interactive}
+form.  For example the following function:
 
 @example
-@group
-(defun foo ()
-  (interactive)
-  (when (called-interactively-p 'any)
-    (message "Interactive!")
-    'foo-called-interactively))
-@end group
-
-@group
-;; @r{Type @kbd{M-x foo}.}
-     @print{} Interactive!
-@end group
-
-@group
-(foo)
-     @result{} nil
-@end group
+(defun foo (bar)
+  (interactive (list "bar"))
+  (when (called-interactively-p)
+    (message "bar is %s" bar)))
 @end example
 
 @noindent
-Here is another example that contrasts direct and indirect calls to
-@code{called-interactively-p}.
+should be rewritten
 
 @example
-@group
-(defun bar ()
-  (interactive)
-  (message "%s" (list (foo) (called-interactively-p 'any))))
-@end group
-
-@group
-;; @r{Type @kbd{M-x bar}.}
-     @print{} (nil t)
-@end group
+(defun foo (bar &optional verbose-p)
+  (interactive "i\np")
+  (when verbose-p
+    (setq bar "bar")
+    (message "bar is %s" bar)))
 @end example
 
 @node Command Loop Info
diff --git a/lisp/subr.el b/lisp/subr.el
index f909b63aabe..f5add8c63ae 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -6061,32 +6061,8 @@ internal--funcall-interactively
   (symbol-function 'funcall-interactively))
 
 (defun called-interactively-p (&optional kind)
-  "Return t if the containing function was called by `call-interactively'.
-If KIND is `interactive', then return t only if the call was made
-interactively by the user, i.e. not in `noninteractive' mode nor
-when `executing-kbd-macro'.
-If KIND is `any', on the other hand, it will return t for any kind of
-interactive call, including being called as the binding of a key or
-from a keyboard macro, even in `noninteractive' mode.
-
-This function is very brittle, it may fail to return the intended result when
-the code is debugged, advised, or instrumented in some form.  Some macros and
-special forms (such as `condition-case') may also sometimes wrap their bodies
-in a `lambda', so any call to `called-interactively-p' from those bodies will
-indicate whether that lambda (rather than the surrounding function) was called
-interactively.
-
-Instead of using this function, it is cleaner and more reliable to give your
-function an extra optional argument whose `interactive' spec specifies
-non-nil unconditionally (\"p\" is a good way to do this), or via
-\(not (or executing-kbd-macro noninteractive)).
-
-The only known proper use of `interactive' for KIND is in deciding
-whether to display a helpful message, or how to display it.  If you're
-thinking of using it for any other purpose, it is quite likely that
-you're making a mistake.  Think: what do you want to do when the
-command is called from a keyboard macro?"
-  (declare (advertised-calling-convention (kind) "23.1"))
+  "Deprecated.
+Refer to Info node `(elisp)Distinguish Interactive'."
   (when (not (and (eq kind 'interactive)
                   (or executing-kbd-macro noninteractive)))
     (let* ((i 1) ;; 0 is the called-interactively-p frame.
@@ -6134,30 +6110,9 @@ called-interactively-p
                    . ,_))
          t)))))
 
-(defun interactive-p ()
-  "Return t if the containing function was run directly by user input.
-This means that the function was called with `call-interactively'
-\(which includes being called as the binding of a key)
-and input is currently coming from the keyboard (not a keyboard macro),
-and Emacs is not running in batch mode (`noninteractive' is nil).
-
-The only known proper use of `interactive-p' is in deciding whether to
-display a helpful message, or how to display it.  If you're thinking
-of using it for any other purpose, it is quite likely that you're
-making a mistake.  Think: what do you want to do when the command is
-called from a keyboard macro or in batch mode?
-
-To test whether your function was called with `call-interactively',
-either (i) add an extra optional argument and give it an `interactive'
-spec that specifies non-nil unconditionally (such as \"p\"); or (ii)
-use `called-interactively-p'.
-
-To test whether a function can be called interactively, use
-`commandp'."
-  ;; Kept around for now.  See discussion at:
-  ;; https://lists.gnu.org/r/emacs-devel/2020-08/msg00564.html
-  (declare (obsolete called-interactively-p "23.2"))
-  (called-interactively-p 'interactive))
+(define-obsolete-function-alias 'interactive-p
+  #'called-interactively-p "23.2"
+  "Keep alias (https://lists.gnu.org/r/emacs-devel/2020-08/msg00564.html)")
 
 (defun internal-push-keymap (keymap symbol)
   (let ((map (symbol-value symbol)))
diff --git a/src/callint.c b/src/callint.c
index d8d2b278458..6be96273f95 100644
--- a/src/callint.c
+++ b/src/callint.c
@@ -233,20 +233,19 @@ read_file_name (Lisp_Object default_filename, Lisp_Object mustmatch,
 		mustmatch, initial, predicate);
 }
 
-/* BEWARE: Calling this directly from C would defeat the purpose!  */
+/* This primitive should only be called from lisp and not C since its
+   very purpose is to appear as a literal token in the lisp call
+   stack.
+*/
+
 DEFUN ("funcall-interactively", Ffuncall_interactively, Sfuncall_interactively,
-       1, MANY, 0, doc: /* Like `funcall' but marks the call as interactive.
-I.e. arrange that within the called function `called-interactively-p' will
-return non-nil.
+       1, MANY, 0, doc: /* Differentiate from `funcall' to indicate interactive call.
+The function `called-interactively-p' looks for this very function token.
 usage: (funcall-interactively FUNCTION &rest ARGUMENTS)  */)
      (ptrdiff_t nargs, Lisp_Object *args)
 {
   specpdl_ref speccount = SPECPDL_INDEX ();
   temporarily_switch_to_single_kboard (NULL);
-
-  /* Nothing special to do here, all the work is inside
-     `called-interactively-p'.  Which will look for us as a marker in the
-     backtrace.  */
   return unbind_to (speccount, Ffuncall (nargs, args));
 }
 
diff --git a/test/lisp/emacs-lisp/edebug-resources/edebug-test-code.el b/test/lisp/emacs-lisp/edebug-resources/edebug-test-code.el
index b0211c915e6..b033fdddcd8 100644
--- a/test/lisp/emacs-lisp/edebug-resources/edebug-test-code.el
+++ b/test/lisp/emacs-lisp/edebug-resources/edebug-test-code.el
@@ -33,6 +33,10 @@ edebug-test-code-fac
       (* n (edebug-test-code-fac (1- n)))!mult!
     1))
 
+(defun edebug-test-code-called-interactively-p ()
+  (interactive)
+  !start!(called-interactively-p))
+
 (defun edebug-test-code-concat (a b flag)
   !start!(if flag!flag!
       !then-start!(concat a!then-a! b!then-b!)!then-concat!
diff --git a/test/lisp/emacs-lisp/edebug-tests.el b/test/lisp/emacs-lisp/edebug-tests.el
index de2fff5ef19..72ea5874cae 100644
--- a/test/lisp/emacs-lisp/edebug-tests.el
+++ b/test/lisp/emacs-lisp/edebug-tests.el
@@ -56,6 +56,7 @@ edebug-tests-failure-in-post-command
 (defvar-keymap edebug-tests-keymap
   :doc "Keys used by the keyboard macros in Edebug's tests."
   "@"       'edebug-tests-call-instrumented-func
+  "#"       'edebug-tests-call-interactively-instrumented-func
   "C-u"     'universal-argument
   "C-p"     'previous-line
   "C-n"     'next-line
@@ -268,6 +269,13 @@ edebug-tests-setup-@
           edebug-tests-args args)
     (setq edebug-tests-@-result 'no-result)))
 
+(defun edebug-tests-call-interactively-instrumented-func ()
+  "Call interactively `edebug-tests-func' and save results."
+  (interactive)
+  (let ((result (call-interactively edebug-tests-func)))
+    (should (eq edebug-tests-@-result 'no-result))
+    (setq edebug-tests-@-result result)))
+
 (defun edebug-tests-call-instrumented-func ()
   "Call `edebug-tests-func' with `edebug-tests-args' and save the results."
   (interactive)
@@ -440,6 +448,14 @@ edebug-tests-stop-point-at-start-of-first-instrumented-function
     "SPC" (edebug-tests-should-be-at "fac" "step")
     "g"   (should (equal edebug-tests-@-result 1)))))
 
+(ert-deftest edebug-tests-called-interactively-p ()
+  "`called-interactively-p' still works under edebug."
+  (edebug-tests-with-normal-env
+   (edebug-tests-setup-@ "called-interactively-p" '() t)
+   (edebug-tests-run-kbd-macro
+    "#"   (edebug-tests-should-be-at "called-interactively-p" "start")
+    "g"   (should (equal edebug-tests-@-result t)))))
+
 (ert-deftest edebug-tests-step-showing-evaluation-results ()
   "Edebug prints expression evaluation results to the echo area."
   (edebug-tests-with-normal-env
diff --git a/test/lisp/emacs-lisp/nadvice-tests.el b/test/lisp/emacs-lisp/nadvice-tests.el
index 748d42f2120..478de8177f7 100644
--- a/test/lisp/emacs-lisp/nadvice-tests.el
+++ b/test/lisp/emacs-lisp/nadvice-tests.el
@@ -145,9 +145,8 @@ advice-test-called-interactively-p-around
 
 (ert-deftest advice-test-called-interactively-p-filter-args ()
   "Check interaction between filter-args advice and called-interactively-p."
-  :expected-result :failed
   (defun sm-test7.3 () (interactive) (cons 1 (called-interactively-p)))
-  (advice-add 'sm-test7.3 :filter-args #'list)
+  (advice-add 'sm-test7.3 :filter-args #'identity)
   (should (equal (sm-test7.3) '(1 . nil)))
   (should (equal (call-interactively 'sm-test7.3) '(1 . t))))
 
@@ -163,6 +162,18 @@ advice-test-call-interactively
       (advice-remove 'call-interactively #'ignore)
       (should (eq (symbol-function 'call-interactively) old)))))
 
+(ert-deftest advice-test-called-interactively-p-around-careful ()
+  "Like sm-test7.2 but defensively preserve interactive context."
+  (defun sm-test7.5 () (interactive) (cons 1 (called-interactively-p)))
+  (advice-add 'sm-test7.5 :around
+              (lambda (f &rest args)
+                (list (cons 1 (called-interactively-p))
+                      (if (called-interactively-p)
+                          (apply #'funcall-interactively f args)
+                        (apply f args)))))
+  (should (equal (sm-test7.5) '((1 . nil) (1 . nil))))
+  (should (equal (call-interactively 'sm-test7.5) '((1 . t) (1 . t)))))
+
 (ert-deftest advice-test-interactive ()
   "Check handling of interactive spec."
   (defun sm-test8 (a) (interactive "p") a)
-- 
2.38.1


[-- Attachment #3: Type: text/plain, Size: 16170 bytes --]




In Commercial Emacs 0.3.1snapshot 00b607c in dev (upstream 30.0.50,
x86_64-pc-linux-gnu) built on dick
Repository revision: 00b607cd599a2e907ca01a23cc71c16b92294d10
Repository branch: dev
Windowing system distributor 'The X.Org Foundation', version 11.0.12101003
System Description: Ubuntu 22.04.1 LTS

Configured using:
 'configure WERROR_CFLAGS=-Werror --prefix=/home/dick/.local
 --with-tree-sitter CC=gcc-10
 PKG_CONFIG_PATH=/home/dick/.local/lib/pkgconfig CXX=gcc-10'
Configured features:
CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
TREE_SITTER LCMS2 LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY
PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11
XDBE XIM XINPUT2 XPM GTK3 ZLIB
Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Magit

Minor modes in effect:
  global-git-commit-mode: t
  server-mode: t
  shell-dirtrack-mode: t
  projectile-mode: t
  global-xlsp-mode: t
  global-hl-line-mode: t
  hl-line-mode: t
  global-auto-revert-mode: t
  flx-ido-mode: t
  winner-mode: t
  override-global-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  buffer-read-only: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
/home/dick/gomacro-mode/gomacro-mode hides /home/dick/.emacs.d/elpa/gomacro-mode-20200326.1103/gomacro-mode
/home/dick/org-gcal.el/org-gcal hides /home/dick/.emacs.d/elpa/org-gcal-0.3/org-gcal
/home/dick/.emacs.d/elpa/request-deferred-0.2.0/request-deferred hides /home/dick/.emacs.d/elpa/request-0.3.3/request-deferred
/home/dick/.emacs.d/elpa/go-rename-20190805.2101/go-rename hides /home/dick/.emacs.d/elpa/go-mode-1.6.0/go-rename
/home/dick/.emacs.d/elpa/go-guru-20181012.330/go-guru hides /home/dick/.emacs.d/elpa/go-mode-1.6.0/go-guru
/home/dick/.emacs.d/elpa/chess-2.0.5/_pkg hides /home/dick/.local/share/emacs/site-lisp/_pkg
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-pos hides /home/dick/.local/share/emacs/site-lisp/chess-pos
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-module hides /home/dick/.local/share/emacs/site-lisp/chess-module
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-ucb hides /home/dick/.local/share/emacs/site-lisp/chess-ucb
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-scid hides /home/dick/.local/share/emacs/site-lisp/chess-scid
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-puzzle hides /home/dick/.local/share/emacs/site-lisp/chess-puzzle
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-irc hides /home/dick/.local/share/emacs/site-lisp/chess-irc
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-network hides /home/dick/.local/share/emacs/site-lisp/chess-network
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-autosave hides /home/dick/.local/share/emacs/site-lisp/chess-autosave
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-engine hides /home/dick/.local/share/emacs/site-lisp/chess-engine
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-tutorial hides /home/dick/.local/share/emacs/site-lisp/chess-tutorial
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-german hides /home/dick/.local/share/emacs/site-lisp/chess-german
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-file hides /home/dick/.local/share/emacs/site-lisp/chess-file
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-random hides /home/dick/.local/share/emacs/site-lisp/chess-random
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-stockfish hides /home/dick/.local/share/emacs/site-lisp/chess-stockfish
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-pgn hides /home/dick/.local/share/emacs/site-lisp/chess-pgn
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-kibitz hides /home/dick/.local/share/emacs/site-lisp/chess-kibitz
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-eco hides /home/dick/.local/share/emacs/site-lisp/chess-eco
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-display hides /home/dick/.local/share/emacs/site-lisp/chess-display
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-var hides /home/dick/.local/share/emacs/site-lisp/chess-var
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-test hides /home/dick/.local/share/emacs/site-lisp/chess-test
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-ply hides /home/dick/.local/share/emacs/site-lisp/chess-ply
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-message hides /home/dick/.local/share/emacs/site-lisp/chess-message
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-ics1 hides /home/dick/.local/share/emacs/site-lisp/chess-ics1
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-phalanx hides /home/dick/.local/share/emacs/site-lisp/chess-phalanx
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-game hides /home/dick/.local/share/emacs/site-lisp/chess-game
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-log hides /home/dick/.local/share/emacs/site-lisp/chess-log
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-plain hides /home/dick/.local/share/emacs/site-lisp/chess-plain
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-perft hides /home/dick/.local/share/emacs/site-lisp/chess-perft
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-glaurung hides /home/dick/.local/share/emacs/site-lisp/chess-glaurung
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-ai hides /home/dick/.local/share/emacs/site-lisp/chess-ai
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-fruit hides /home/dick/.local/share/emacs/site-lisp/chess-fruit
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-uci hides /home/dick/.local/share/emacs/site-lisp/chess-uci
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-epd hides /home/dick/.local/share/emacs/site-lisp/chess-epd
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-database hides /home/dick/.local/share/emacs/site-lisp/chess-database
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-link hides /home/dick/.local/share/emacs/site-lisp/chess-link
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-transport hides /home/dick/.local/share/emacs/site-lisp/chess-transport
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-none hides /home/dick/.local/share/emacs/site-lisp/chess-none
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-polyglot hides /home/dick/.local/share/emacs/site-lisp/chess-polyglot
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-crafty hides /home/dick/.local/share/emacs/site-lisp/chess-crafty
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-chat hides /home/dick/.local/share/emacs/site-lisp/chess-chat
/home/dick/.emacs.d/elpa/chess-2.0.5/chess hides /home/dick/.local/share/emacs/site-lisp/chess
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-images hides /home/dick/.local/share/emacs/site-lisp/chess-images
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-gnuchess hides /home/dick/.local/share/emacs/site-lisp/chess-gnuchess
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-fen hides /home/dick/.local/share/emacs/site-lisp/chess-fen
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-ics hides /home/dick/.local/share/emacs/site-lisp/chess-ics
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-ics2 hides /home/dick/.local/share/emacs/site-lisp/chess-ics2
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-common hides /home/dick/.local/share/emacs/site-lisp/chess-common
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-input hides /home/dick/.local/share/emacs/site-lisp/chess-input
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-announce hides /home/dick/.local/share/emacs/site-lisp/chess-announce
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-clock hides /home/dick/.local/share/emacs/site-lisp/chess-clock
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-sound hides /home/dick/.local/share/emacs/site-lisp/chess-sound
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-sjeng hides /home/dick/.local/share/emacs/site-lisp/chess-sjeng
/home/dick/.emacs.d/elpa/chess-2.0.5/chess-algebraic hides /home/dick/.local/share/emacs/site-lisp/chess-algebraic
/home/dick/.emacs.d/elpa/transient-0.3.7snapshot/transient hides /home/dick/.local/share/emacs/0.3.1/lisp/transient
/home/dick/.emacs.d/elpa/use-package-20200520.2305/use-package-bind-key hides /home/dick/.local/share/emacs/0.3.1/lisp/use-package/use-package-bind-key
/home/dick/.emacs.d/elpa/use-package-20200520.2305/use-package-lint hides /home/dick/.local/share/emacs/0.3.1/lisp/use-package/use-package-lint
/home/dick/.emacs.d/elpa/use-package-20200520.2305/use-package-core hides /home/dick/.local/share/emacs/0.3.1/lisp/use-package/use-package-core
/home/dick/.emacs.d/elpa/use-package-20200520.2305/use-package-ensure hides /home/dick/.local/share/emacs/0.3.1/lisp/use-package/use-package-ensure
/home/dick/.emacs.d/elpa/bind-key-20161218.1520/bind-key hides /home/dick/.local/share/emacs/0.3.1/lisp/use-package/bind-key
/home/dick/.emacs.d/elpa/use-package-20200520.2305/use-package-jump hides /home/dick/.local/share/emacs/0.3.1/lisp/use-package/use-package-jump
/home/dick/.emacs.d/elpa/use-package-20200520.2305/use-package-diminish hides /home/dick/.local/share/emacs/0.3.1/lisp/use-package/use-package-diminish
/home/dick/.emacs.d/elpa/use-package-20200520.2305/use-package hides /home/dick/.local/share/emacs/0.3.1/lisp/use-package/use-package
/home/dick/.emacs.d/elpa/use-package-20200520.2305/use-package-delight hides /home/dick/.local/share/emacs/0.3.1/lisp/use-package/use-package-delight
/home/dick/.emacs.d/elpa/eglot-1.8/eglot hides /home/dick/.local/share/emacs/0.3.1/lisp/progmodes/eglot
/home/dick/.emacs.d/elpa/soap-client-3.1.5/soap-client hides /home/dick/.local/share/emacs/0.3.1/lisp/net/soap-client
/home/dick/.emacs.d/elpa/soap-client-3.1.5/soap-inspect hides /home/dick/.local/share/emacs/0.3.1/lisp/net/soap-inspect
/home/dick/.emacs.d/elpa/let-alist-1.0.6/let-alist hides /home/dick/.local/share/emacs/0.3.1/lisp/emacs-lisp/let-alist

Features:
(shadow emacsbug git-rebase pulse supercite regi texinfo
texinfo-loaddefs vc-hg vc-bzr vc-src vc-sccs vc-cvs vc-rcs log-view
whitespace magit-extras goto-addr face-remap magit-patch-changelog
magit-patch magit-submodule magit-obsolete magit-blame magit-stash
magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone
magit-remote magit-commit magit-sequence magit-notes magit-worktree
magit-tag magit-merge magit-branch magit-reset magit-files magit-refs
magit-status magit magit-repos magit-apply magit-wip magit-log
which-func imenu magit-diff git-commit log-edit pcvs-util add-log
magit-core magit-autorevert magit-margin magit-transient magit-process
with-editor server magit-mode transient magit-git magit-base
magit-section gnus-html url-queue cl-print google-translate debug
backtrace ag find-dired flow-fill smerge-mode diff shr-color gravatar
dns canlock bbdb-message footnote nnselect mm-archive
display-line-numbers calc calc-loaddefs rect calc-macs sort smiley
mail-extr textsec uni-scripts idna-mapping ucs-normalize uni-confusable
textsec-check gnus-async qp gnus-ml gnus-notifications gnus-fun
notifications gnus-kill gnus-dup disp-table utf-7 url-cache benchmark
nnrss nnfolder nndiscourse rbenv nnhackernews nntwitter nntwitter-api
bbdb-gnus gnus-demon nntp nnmairix nnml nnreddit gnus-topic url-http
url-auth url-gw network-stream nsm request virtualenvwrapper gud s dash
json-rpc gnus-score score-mode gnus-bcklg gnus-srvr gnus-cite anaphora
bbdb-mua bbdb-com crm bbdb bbdb-site timezone gnus-delay gnus-draft
gnus-cache gnus-agent gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime
smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom
nndraft nnmh gnus-group mm-url gnus-undo use-package use-package-ensure
use-package-delight use-package-diminish gnus-start gnus-dbus gnus-cloud
nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range
gnus-win python compat xscheme scheme mule-util jka-compr markdown-mode
edit-indirect misearch multi-isearch company-oddmuse company-keywords
company-etags company-gtags company-dabbrev-code company-dabbrev
company-files company-clang company-cmake company-semantic
company-template company-bbdb vc cc-mode cc-fonts cc-guess cc-menus
cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs tramp-archive
tramp-gvfs tramp-cache time-stamp zeroconf dbus xml tramp tramp-loaddefs
trampver tramp-integration cus-start files-x tramp-compat shell
pcomplete parse-time iso8601 ls-lisp format-spec vc-git diff-mode
vc-dispatcher tree-sitter bug-reference vc-svn elpaso elpaso-admin
elpaso-milky elpaso-defs message sendmail yank-media puny dired-x dired
dired-loaddefs rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode
mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums
mailabbrev gmm-utils mailheader shortdoc cal-menu calendar cal-loaddefs
help-fns radix-tree paredit-ext paredit inf-ruby ruby-mode smie
haskell-interactive-mode haskell-presentation-mode haskell-process
haskell-session haskell-compile haskell-mode haskell-cabal haskell-utils
haskell-font-lock haskell-indentation haskell-string
haskell-sort-imports haskell-lexeme rx haskell-align-imports
haskell-complete-module haskell-ghc-support noutline outline
flymake-proc flymake etags fileloop generator dabbrev haskell-customize
solarized-theme solarized-definitions projectile lisp-mnt ibuf-ext
ibuffer ibuffer-loaddefs thingatpt grep compile comint ansi-osc
ansi-color gnus nnheader range mail-utils mm-util mail-prsvr gnus-util
text-property-search time-date xlsp xlsp-xref xlsp-server xlsp-company
company-capf company xlsp-handle-notification xlsp-handle-request
xlsp-struct xlsp-utils jsonrpc pcase warnings hl-line autorevert
filenotify flx-ido flx google-translate-default-ui
google-translate-core-ui facemenu color ido google-translate-core
google-translate-tk google-translate-backend auto-complete advice popup
cus-edit pp cus-load icons wid-edit emms-player-mplayer
emms-player-simple emms emms-compat winner edmacro kmacro cl-extra
help-mode xref project ring use-package-bind-key bind-key easy-mmode
use-package-core derived company-go-autoloads wordnut-autoloads
quelpa-autoloads haskell-mode-autoloads xlsp-autoloads debbugs-autoloads
eglot-autoloads emacsql-autoloads corfu-autoloads elpaso-disc-autoloads
elpaso-autoloads find-func sml-mode-autoloads json-reformat-autoloads
typescript-mode-autoloads projectile-autoloads nnreddit-autoloads
json-snatcher-autoloads yasnippet-autoloads
tornado-template-mode-autoloads flycheck-autoloads request-autoloads
lsp-mode-autoloads lv-autoloads lsp-bridge-autoloads posframe-autoloads
magit-autoloads magit-section-autoloads cask-autoloads epl-autoloads
markdown-mode-autoloads go-mode-autoloads dash-autoloads
company-autoloads git-commit-autoloads info compat-autoloads package
browse-url url url-proxy url-privacy url-expand url-methods url-history
url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers
url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache
json subr-x map byte-opt gv bytecomp byte-compile cldefs url-vars
cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric
uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process
emacs)

Memory information:
((conses 16 1673580 201724)
 (symbols 48 51654 57)
 (strings 32 299338 52605)
 (string-bytes 1 10478826)
 (vectors 16 147139)
 (vector-slots 8 3572283 155106)
 (floats 8 1578 2761)
 (intervals 56 30603 4305)
 (buffers 984 74))

bug#61268: 30.0.50; [PATCH] Deprecate called-interactively-p

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

dick.r.chiang@gmail.com writes:

> Deprecate `called-interactively-p`.

Unacceptable, for reasons that just came up on emacs-devel this week.  Closing.

bug#61268: 30.0.50; [PATCH] Deprecate called-interactively-p

[dick]

For an individual notorious for mangling interfaces
(window-text-pixel-size, set-window-vscroll), why continue
to support a method that *reduces* such mangling?

git log -p --since="2021-10-01" --author luangruo -- | perl -ne 'chomp; $line = $_;
if ($line =~ /^[ -]((DEFUN\s\()|[a-z]\S+\s\()/) {
    $prim = 1 if $2;
    $new = "";
    substr($line,0,1) = "-";
    $old = "$line\n";
} elsif ($old && $line =~ /^[-]/) {
    $old .= "$line\n" if $line =~ /[(),]/;
} elsif ($old && $line =~ /^\+/) {
    $new .= "$line\n" if $line =~ /[(),]/;
    if (!$prim && $new =~ /\)\s*$/ ||
        $prim && $new =~ /\d,\s*\d,\s*\d/) {
        print $old;
        print $new;
        $prim = $old = $new = "";
    }
} else {
    $prim = $old = $new = "";
}'

bug#61268: 30.0.50; [PATCH] Deprecate called-interactively-p

[Eli Zaretskii]

> Cc: luangruo@yahoo.com
> From: dick <dick.r.chiang@gmail.com>
> Date: Sat, 04 Feb 2023 14:03:21 -0500
> 
> For an individual notorious for mangling interfaces
> (window-text-pixel-size, set-window-vscroll), why continue
> to support a method that *reduces* such mangling?
> 
> git log -p --since="2021-10-01" --author luangruo -- | perl -ne 'chomp; $line = $_;
> if ($line =~ /^[ -]((DEFUN\s\()|[a-z]\S+\s\()/) {
>     $prim = 1 if $2;
>     $new = "";
>     substr($line,0,1) = "-";
>     $old = "$line\n";
> } elsif ($old && $line =~ /^[-]/) {
>     $old .= "$line\n" if $line =~ /[(),]/;
> } elsif ($old && $line =~ /^\+/) {
>     $new .= "$line\n" if $line =~ /[(),]/;
>     if (!$prim && $new =~ /\)\s*$/ ||
>         $prim && $new =~ /\d,\s*\d,\s*\d/) {
>         print $old;
>         print $new;
>         $prim = $old = $new = "";
>     }
> } else {
>     $prim = $old = $new = "";
> }'

Is this a bug report?  If so, what is the bug, and how to reproduce
it?

bug#61268: 30.0.50; [PATCH] Deprecate called-interactively-p

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Eli Zaretskii <eliz@gnu.org> writes:

>> Cc: luangruo@yahoo.com
>> From: dick <dick.r.chiang@gmail.com>
>> Date: Sat, 04 Feb 2023 14:03:21 -0500
>> 
>> For an individual notorious for mangling interfaces
>> (window-text-pixel-size, set-window-vscroll), why continue
>> to support a method that *reduces* such mangling?
>> 
>> git log -p --since="2021-10-01" --author luangruo -- | perl -ne 'chomp; $line = $_;
>> if ($line =~ /^[ -]((DEFUN\s\()|[a-z]\S+\s\()/) {
>>     $prim = 1 if $2;
>>     $new = "";
>>     substr($line,0,1) = "-";
>>     $old = "$line\n";
>> } elsif ($old && $line =~ /^[-]/) {
>>     $old .= "$line\n" if $line =~ /[(),]/;
>> } elsif ($old && $line =~ /^\+/) {
>>     $new .= "$line\n" if $line =~ /[(),]/;
>>     if (!$prim && $new =~ /\)\s*$/ ||
>>         $prim && $new =~ /\d,\s*\d,\s*\d/) {
>>         print $old;
>>         print $new;
>>         $prim = $old = $new = "";
>>     }
>> } else {
>>     $prim = $old = $new = "";
>> }'
>
> Is this a bug report?  If so, what is the bug, and how to reproduce
> it?

It is a bad attempt at making a personal insult.  The next time he comes
back, I suggest replying with the word:

      *plonk*