BUG: org-sbe not working anymore: Format specifier doesn’t match argument type

BUG: org-sbe not working anymore: Format specifier doesn’t match argument type

[Michael Dauer]

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

Org mode version 9.5.5 (9.5.5-geeae6e

#+CALL: test1()

#+RESULTS:
: 1

#+CALL: test2()

Fails with: Format specifier doesn’t match argument type

* Test
#+name: test1
#+begin_src elisp
1
#+end_src
#+NAME: test2
#+begin_src elisp
(org-sbe "test1")
#+end_src

[-- Attachment #2: Type: text/html, Size: 378 bytes --]

Re: BUG: org-sbe not working anymore: Format specifier doesn’t match argument type

[Ihor Radchenko]

Michael Dauer <mick.dauer@gmail.com> writes:

> Org mode version 9.5.5 (9.5.5-geeae6e
>
> #+CALL: test1()
>
> #+RESULTS:
> : 1
>
> #+CALL: test2()
>
> Fails with: Format specifier doesn’t match argument type
>
> * Test
> #+name: test1
> #+begin_src elisp
> 1
> #+end_src
> #+NAME: test2
> #+begin_src elisp
> (org-sbe "test1")
> #+end_src

Thanks for reporting.
Confirmed.

Timothy, it is caused by your

392ccbbf5d450ad47cd5952ed2f4ef35e454648e
Author:     TEC <git@tecosaur.net>
ob-core: Display position of executed babel blocks

(nth 5 info) is nil in the above scenario. 

Could you please take a look?

I can "fix" this by using "%S" formatter, but maybe we can do better?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: BUG: org-sbe not working anymore: Format specifier doesn’t match argument type

[Michael Dauer]

[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]

It's this fixed? How can I track myself?

Ihor Radchenko <yantar92@posteo.net> schrieb am Mo., 17. Okt. 2022, 15:11:

> Michael Dauer <mick.dauer@gmail.com> writes:
>
> > Org mode version 9.5.5 (9.5.5-geeae6e
> >
> > #+CALL: test1()
> >
> > #+RESULTS:
> > : 1
> >
> > #+CALL: test2()
> >
> > Fails with: Format specifier doesn’t match argument type
> >
> > * Test
> > #+name: test1
> > #+begin_src elisp
> > 1
> > #+end_src
> > #+NAME: test2
> > #+begin_src elisp
> > (org-sbe "test1")
> > #+end_src
>
> Thanks for reporting.
> Confirmed.
>
> Timothy, it is caused by your
>
> 392ccbbf5d450ad47cd5952ed2f4ef35e454648e
> Author:     TEC <git@tecosaur.net>
> ob-core: Display position of executed babel blocks
>
> (nth 5 info) is nil in the above scenario.
>
> Could you please take a look?
>
> I can "fix" this by using "%S" formatter, but maybe we can do better?
>
> --
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>
>

[-- Attachment #2: Type: text/html, Size: 2037 bytes --]

Re: BUG: org-sbe not working anymore: Format specifier doesn’t match argument type

[Ihor Radchenko]

Michael Dauer <mick.dauer@gmail.com> writes:

> It's this fixed? How can I track myself?

I think it is, as a side effect of
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=9987451252fa64af65d0a0a014f41812f4402c02

I was mainly waiting for Timothy to chime in, but there was a second bug report...

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: BUG: org-sbe not working anymore: Format specifier doesn’t match argument type

[zhaoyiyu]

Maybe change the org-sbe macro? Below is a workaround.

(defmacro org-sbe (source-block &rest variables)

   (declare (debug (form form)))
   (let* ((header-args (if (stringp (car variables)) (car variables) ""))
      (variables (if (stringp (car variables)) (cdr variables) variables)))
     (let* (quote
        (variables
         (mapcar
          (lambda (var)
            ;; ensure that all cells prefixed with $'s are strings
            (cons (car var)
              (delq nil (mapcar
                 (lambda (el)
                   (if (eq '$ el)
                       (prog1 nil (setq quote t))
                     (prog1
                     (cond
                                          ;; FIXME: replace "\"%s\"" for 
quotation marks inside value
-->                     (quote (format "%S" el))
                      ((stringp el) (org-no-properties el))
                      (t el))
                       (setq quote nil))))
                 (cdr var)))))
          variables)))
       (unless (stringp source-block)
     (setq source-block (symbol-name source-block)))
       (let ((result
              (if (and source-block (> (length source-block) 0))
                  (let ((params
                         ;; FIXME: Why `eval'?!?!?
                         (eval `(org-babel-parse-header-arguments
                                 (concat
                                  ":var results="
                                  ,source-block
                                  "[" ,header-args "]"
                                  "("
                                  (mapconcat
                                   (lambda (var-spec)
                                     (if (> (length (cdr var-spec)) 1)
                                         (format "%S='%S"
                                                 (car var-spec)
                                                 (mapcar #'read (cdr 
var-spec)))
                                       (format "%S=%s"
                                               (car var-spec) (cadr 
var-spec))))
                                   ',variables ", ")
                                  ")")))))
                    (org-babel-execute-src-block
                     ;; FIXME: manual add names in list
-->                    nil (list "emacs-lisp" "results" params "" "results")
                     '((:results . "silent"))))
                "")))
         (org-trim (if (stringp result) result (format "%S" result)))))))

On 2022/11/4 15:23, Ihor Radchenko wrote:
> Michael Dauer <mick.dauer@gmail.com> writes:
>
>> It's this fixed? How can I track myself?
> I think it is, as a side effect of
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=9987451252fa64af65d0a0a014f41812f4402c02
>
> I was mainly waiting for Timothy to chime in, but there was a second bug report...
>

Re: BUG: org-sbe not working anymore: Format specifier doesn’t match argument type

[Ihor Radchenko]

zhaoyiyu <zhyznd@163.com> writes:
> Maybe change the org-sbe macro? Below is a workaround.

Sorry, I was not clear.
This bug has been fixed.
I can no longer reproduce it.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: BUG: org-sbe not working anymore: Format specifier doesn’t match argument type

[赵一宇]

[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]

Oh thanks, that was clear.
However, I wanna figure out if another change would somehow fix another problem, when in the (var value) pair, the value contains quotation marks, for example 123°34'23.34", the assignment would fail.


In macro she-org,
change
(quote (format "\"%s\"" el))
to
(quote (format "%S" el))


Now I can use the $ prefix to assign the string value.


|
zhyznd@163.com
|
---- Replied Message ----
| From | Ihor Radchenko<yantar92@posteo.net> |
| Date | 2/22/2023 19:18 |
| To | zhaoyiyu<zhyznd@163.com> |
| Cc | Michael Dauer<mick.dauer@gmail.com> ,
Timothy<orgmode@tec.tecosaur.net> ,
<emacs-orgmode@gnu.org> |
| Subject | Re: BUG: org-sbe not working anymore: Format specifier doesn’t match argument type |

zhaoyiyu <zhyznd@163.com> writes:
Maybe change the org-sbe macro? Below is a workaround.

Sorry, I was not clear.
This bug has been fixed.
I can no longer reproduce it.

--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

[-- Attachment #2: Type: text/html, Size: 6862 bytes --]

Re: BUG: org-sbe not working anymore: Format specifier doesn’t match argument type

[Ihor Radchenko]

赵一宇 <zhyznd@163.com> writes:

> However, I wanna figure out if another change would somehow fix another problem, when in the (var value) pair, the value contains quotation marks, for example 123°34'23.34", the assignment would fail.

Could you please provide a reproducer?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: BUG: org-sbe not working anymore: Format specifier doesn’t match argument type

[赵一宇]

[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]

Here is an example, in org file


#+name: test
#+begin_src emacs-lisp :var a :results silent
a
#+end_src


Now, if I execute 
(org-sbe "test" (a "123°34'23.34\"otherthing"))
it would say: Reference 123°34'23.34"otherthing not found
and
(org-sbe "test" (a $"123°34'23.34\"otherthing"))
would result 123°34'23.34
|
|


|
|
zhyznd@163.com
|
---- Replied Message ----
| From | Ihor Radchenko<yantar92@posteo.net> |
| Date | 2/22/2023 21:57 |
| To | 赵一宇<zhyznd@163.com> |
| Cc | mick.dauer@gmail.com<mick.dauer@gmail.com> ,
orgmode@tec.tecosaur.net<orgmode@tec.tecosaur.net> ,
emacs-orgmode@gnu.org<emacs-orgmode@gnu.org> |
| Subject | Re: BUG: org-sbe not working anymore: Format specifier doesn’t match argument type |
赵一宇 <zhyznd@163.com> writes:

However, I wanna figure out if another change would somehow fix another problem, when in the (var value) pair, the value contains quotation marks, for example 123°34'23.34", the assignment would fail.

Could you please provide a reproducer?

--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

[-- Attachment #2: Type: text/html, Size: 10626 bytes --]

Re: BUG: org-sbe not working anymore: Format specifier doesn’t match argument type

[Ihor Radchenko]

赵一宇 <zhyznd@163.com> writes:

> Here is an example, in org file
>
>
> #+name: test
> #+begin_src emacs-lisp :var a :results silent
> a
> #+end_src
>
>
> Now, if I execute 
> (org-sbe "test" (a "123°34'23.34\"otherthing"))
> it would say: Reference 123°34'23.34"otherthing not found

Fixed, on main.
I made org-sbe accept quoting string values with "$".
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=2e883b21a

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>