From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change. Date: Mon, 08 May 2023 13:34:26 +0000 Message-ID: <87cz3b6j6l.fsf@posteo.net> References: <168335548287.8529.4912240840977468283@vcs2.savannah.gnu.org> <715cdac6-83f6-6907-2ff8-3b33381f3487@gutov.dev> <83zg6hg29c.fsf@gnu.org> <83ttwpfvcr.fsf@gnu.org> <83h6spfose.fsf@gnu.org> <35df1362-fd92-9424-97d0-df3479414677@gutov.dev> <83edntfm6e.fsf@gnu.org> <667d5cc1-4a3c-5cd4-21c0-adff89cea769@gutov.dev> <834jopfdwz.fsf@gnu.org> <83v8h4elki.fsf@gnu.org> <87h6sofs02.fsf@posteo.net> <83r0rsebcf.fsf@gnu.org> <875y94f4eo.fsf@posteo.net> <834joodmaw.fsf@gnu.org> <87o7mwgd1x.fsf@posteo.net> <83y1m0c4zq.fsf@gnu.org> <87fs88gc5a.fsf@posteo.net> <83sfc7cbnx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10911"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 08 15:35:25 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pw11M-0002S4-0v for ged-emacs-devel@m.gmane-mx.org; Mon, 08 May 2023 15:35:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pw10e-00056I-O3; Mon, 08 May 2023 09:34:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pw10e-00056A-3e for emacs-devel@gnu.org; Mon, 08 May 2023 09:34:36 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pw10Y-0007Rr-IE for emacs-devel@gnu.org; Mon, 08 May 2023 09:34:35 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id EAD062401FD for ; Mon, 8 May 2023 15:34:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1683552868; bh=YYV2Y32p+sKjcYq5mxhD0lc1R8ED488xlJlUXeXxljs=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=mYv2kdJ94h0YUpVDm941g0JwyhG4VyDg0u8TsJRnaEd+wgejZhlQ9NabDkzI2wLhD CKgs/PiS2Uffp7CYOqlCCG8VuVJ3snReHudNwCfPNntHa78ajBGwgyES9YVGehdrQm bVt26sce1ym2wKlupp0Z2ota94ZfUsGkpiwDpupLWPl7q7efQQPiujF+EOvl2KJWAk q75A8XqfLX/v3P1E+Q4bBjhy3BRVZluul4I6QBiOHUJxOiT4szhsoph24NmEHTGHtr FF0BmvPnd94kvhECZQJVF5yagxtTxrJA8Z4d1kvnKyxGm7kWY0an7qFxLPAPE5/p44 IHmCDoEQrSUyg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QFMhg0Hwnz6twG; Mon, 8 May 2023 15:34:26 +0200 (CEST) In-Reply-To: <83sfc7cbnx.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 08 May 2023 14:20:18 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -39 X-Spam_score: -4.0 X-Spam_bar: ---- X-Spam_report: (-4.0 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305979 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: dmitry@gutov.dev, monnier@iro.umontreal.ca, emacs-devel@gnu.org >> Date: Sun, 07 May 2023 19:44:01 +0000 >> >> Eli Zaretskii writes: >> >> >> From: Philip Kaludercic >> >> Cc: dmitry@gutov.dev, monnier@iro.umontreal.ca, emacs-devel@gnu.org >> >> Date: Sun, 07 May 2023 19:24:26 +0000 >> >> >> >> Eli Zaretskii writes: >> >> >> >> >> but on my system, it immediately suggests upgrading 24 packages, which >> >> >> is a lot. >> >> > >> >> > Can you show the list of those 24 packages? >> >> >> >> I am on a different system now, so the prompt differs slightly and have >> >> other updates, but this is what it looks like: >> >> >> >> Packages to install: 23 (xref-1.6.3 >> >> verilog-mode-2022.12.18.181110314 use-package-2.4.5 tramp-2.6.0.4 >> >> svg-1.1 soap-client-3.2.1 so-long-1.1.2 python-0.28 project-0.9.8 >> >> org-9.6.5 ntlm-2.1.0 nadvice-0.4 map-3.3.1 let-alist-1.0.6 >> >> jsonrpc-1.0.17 flymake-1.3.4 external-completion-0.1 erc-5.5 >> >> eldoc-1.14.0 eglot-1.15 cl-lib-0.7.1 cl-generic-0.3 bind-key-2.4.1). >> >> Packages to upgrade: 2 (editorconfig-0.9.1 inspector-0.29). >> >> Proceed? (y or n) >> > >> > I see nothing unexpected in this list. And since the feature is >> > opt-in, what are the dangers of having it? >> >> There is no danger, it might just be overwhelming? I was a bit >> surprised at first. But if you think it is fine, then I have no >> objections. > > One more question: the patch you proposed affects both "U" and "/ u", > right? Yes it does, since both of these functions use `package-menu--find-upgrades'. In the future, we should probably centralise the upgrade logic in a single function, like `package--upgradeable-packages'. Eli Zaretskii writes: >> Date: Sun, 7 May 2023 23:36:24 +0300 >> Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org >> From: Dmitry Gutov >> >> On 07/05/2023 22:32, Eli Zaretskii wrote: >> > Packages to install: 23 (xref-1.6.3 >> > verilog-mode-2022.12.18.181110314 use-package-2.4.5 tramp-2.6.0.4 >> > svg-1.1 soap-client-3.2.1 so-long-1.1.2 python-0.28 project-0.9.8 >> > org-9.6.5 ntlm-2.1.0 nadvice-0.4 map-3.3.1 let-alist-1.0.6 >> > jsonrpc-1.0.17 flymake-1.3.4 external-completion-0.1 erc-5.5 >> > eldoc-1.14.0 eglot-1.15 cl-lib-0.7.1 cl-generic-0.3 >> > bind-key-2.4.1). Packages to upgrade: 2 (editorconfig-0.9.1 >> > inspector-0.29). Proceed? (y or n) >> >> At least nadvice, cl-lib and cl-generic seem to be the odd ones (the >> built-in versions are higher, and the ELPA packages are supposed to be >> used as shims or backward compatibility wrappers). That looks like a bug. I think you are right, I can extend my previous patch by a version check. > Yes, I think it's an unrelated bug. We had already reports about > strange status values, and there's a new bug#63064 today about similar > problems. We should try to fix this for Emacs 29, I think. > >> Regarding potential downsides in general: >> >> - We simply increase the odds of breakage when a built-in package is >> upgraded because it will reach more people, across different Emacs >> versions. There is good and bad in that (features will reach them faster >> too), but it's something to consider. >> >> - I very rarely use Tramp or Org. I don't use ERC or bind-key. Or >> so-long, python, ntlm, use-package, verilog-mode. Unlike other installed >> packages (which I have hand-picked), these packages are here just by the >> virtue of being included in Emacs, but flipping the pref will also cause >> them to be upgraded (downloaded, take time unarchiving, take up space) >> every time there is a new version out. It's nothing dangerous >> (probably), but seems unfortunate anyway. > > AFAIU, the "U" command is not for everyone. There are alternatives > which allow selective upgrades, and users who don't want "surprises", > or want the upgrade to take as little time and disk space as possible, > should use those alternatives instead of "U". I'll try to make that > clear in the documentation. I think that U is pretty standard, but yes, those who cannot use it are free to select the packages they wish to upgrade manually (that being said, Emacs was never known for being popular among people who are struggling for every kilobyte of disk space).