From: Visuwesh <visuweshm@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Eli Zaretskii <eliz@gnu.org>, 63861@debbugs.gnu.org
Subject: bug#63861: [PATCH] pp.el: New "pretty printing" code
Date: Fri, 09 Jun 2023 08:51:39 +0530 [thread overview]
Message-ID: <87cz25b9rw.fsf@gmail.com> (raw)
In-Reply-To: <jwvzg5bwaj4.fsf-monnier+emacs@gnu.org> (Stefan Monnier via's message of "Wed, 07 Jun 2023 11:48:32 -0400")
[புதன் ஜூன் 07, 2023] Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote:
>> BTW, how does this compare to the newly added `pp-emacs-lisp-code`?
>
> Very good question. I had completely missed that (and its `pp-use-max-width`).
> This points to a host of integration issues between my code and the
> existing code. I'll have to take a deeper look.
From what I remember, pp simply switches to use pp-emacs-lisp-code when
the relevant user option is set. The poor performance of
pp-emacs-lisp-code made me wish pp-use-max-width was only obeyed by user
facing commands like pp-eval-expression & friends.
>> It was still rough around the edges the last time I set
>> `pp-use-max-width' non-nil. It is also quite a lot slower than the
>> old path.
>
> My new code is expected to be slower than the "normal" pretty-printer,
> but barring performance bugs in `lisp-indent-line` (such as the one
> fixed by the patch I just sent to Thierry) it should be approximately
> a constant factor slower.
>
> AFAICT the performance of `pp-emacs-lisp-code` can be more problematic.
Hopefully, the constant factor is quite small. pp-emacs-lisp-code took
a lot of time to print my modest bookmark alist (28 entries) and for the
longest time I thought some other code in Emacs has gone awry.
> Beside performance, I guess the behavior of the two should be
> somewhat similar, tho I also see that `pp-emacs-lisp-code` pays
> attention to the Edebug and `doc-string-elt` info, so it may give
> slightly more refined info.
I haven't tested your pretty printer but pp-emacs-lisp-code could give
some really bizarre results for lisp data. Unfortunately, I don't have
any examples handy to illustrate what I mean by bizarre though.
> Another difference is that `pp-emacs-lisp-code` starts with an S-exp
> object, whereas my code starts with a region (i.e. an sexp that's
> already been printed).
>
>
> Stefan
next prev parent reply other threads:[~2023-06-09 3:21 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 22:50 bug#63861: [PATCH] pp.el: New "pretty printing" code Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-03 5:53 ` Eli Zaretskii
2023-06-03 18:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-03 18:58 ` Eli Zaretskii
2023-06-12 20:21 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-13 10:55 ` Eli Zaretskii
2023-06-16 18:26 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-17 5:39 ` Eli Zaretskii
2023-06-17 16:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-17 16:42 ` Eli Zaretskii
2023-06-17 22:08 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-04 3:25 ` Visuwesh
2023-06-07 15:48 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-09 3:21 ` Visuwesh [this message]
2023-06-09 14:59 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-09 15:09 ` Ihor Radchenko
2023-06-09 15:26 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-09 15:59 ` Visuwesh
2023-06-09 16:04 ` Visuwesh
2023-06-05 16:12 ` Juri Linkov
2023-06-07 15:21 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-07 18:12 ` Juri Linkov
2023-06-07 19:43 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-07 14:10 ` Thierry Volpiatto
2023-06-07 15:27 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-07 16:19 ` Thierry Volpiatto
2023-06-07 21:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-08 16:15 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-08 18:08 ` Thierry Volpiatto
2023-06-08 22:35 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-09 0:07 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-09 5:22 ` Thierry Volpiatto
2023-06-20 20:56 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz25b9rw.fsf@gmail.com \
--to=visuweshm@gmail.com \
--cc=63861@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.