From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#64735: 29.0.92; find invocations are ~15x slower because of ignores Date: Fri, 21 Jul 2023 12:25:29 +0000 Message-ID: <87cz0lmoxy.fsf@localhost> References: <1fd5e3ed-e1c3-5d6e-897f-1d5d55e379fa@gutov.dev> <87wmyupvlw.fsf@localhost> <5c4d9bea-3eb9-b262-138a-4ea0cb203436@gutov.dev> <87tttypp2e.fsf@localhost> <837cqu35lw.fsf@gnu.org> <87o7k6pmk3.fsf@localhost> <834jly351p.fsf@gnu.org> <87lefapkdx.fsf@localhost> <831qh230h5.fsf@gnu.org> <87wmyu8mi0.fsf@localhost> <83wmyu1l1k.fsf@gnu.org> <87fs5hemi1.fsf@gmx.de> <83edl11qzn.fsf@gnu.org> <874jlxebz5.fsf@gmx.de> <87lef9mqio.fsf@localhost> <87edl1scbw.fsf@gmx.de> <87fs5hmp6i.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17885"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, Eli Zaretskii , 64735@debbugs.gnu.org, sbaugh@janestreet.com To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 21 14:26:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qMpD4-0004PJ-63 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Jul 2023 14:26:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qMpCx-0004Mh-7J; Fri, 21 Jul 2023 08:26:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMpCs-0004MR-Sy for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 08:26:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qMpCr-0000wM-TQ for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 08:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qMpCr-0007jW-NC for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 08:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Jul 2023 12:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64735 X-GNU-PR-Package: emacs Original-Received: via spool by 64735-submit@debbugs.gnu.org id=B64735.168994232629681 (code B ref 64735); Fri, 21 Jul 2023 12:26:01 +0000 Original-Received: (at 64735) by debbugs.gnu.org; 21 Jul 2023 12:25:26 +0000 Original-Received: from localhost ([127.0.0.1]:60791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMpCI-0007if-3n for submit@debbugs.gnu.org; Fri, 21 Jul 2023 08:25:26 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:42283) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMpCF-0007iK-Ue for 64735@debbugs.gnu.org; Fri, 21 Jul 2023 08:25:24 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 23A81240027 for <64735@debbugs.gnu.org>; Fri, 21 Jul 2023 14:25:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689942318; bh=trV0crLwf1UqcRt+UAMceMZcJX4t5oopw9xIAI/9cww=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=fQbbywY9hNHWg4mLFUwEfFPdTtUIgYcv7faneB9q0b8HKVoZYiiA1VyKaIwrZX95u UHWpC/Hw8LbLFDdL9WhB+zfW1VjRDI5Nw6zmuh/WswSH5viG0S/9FuVIPKtT9VpL27 UFdrxelBVRBYvHekACdanV1QrHgTr0SLz/jWxbh3L+lzBAfy1JS7wkLuBwUiDpq/v2 x83WmLLEReXMbVgG7KPT4vATJYrSjiC0HQHwHsdU4Y5oS7izLmx9EVYwT9Q5etNnsv mKZRHLtHPhjspjumi9+F4nqXjpMSR5nVInTpOYl4tnct7BvEFfdUVvG8+cDbBjuIxS w5X7rDR3/m7sQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R6pfj1hN8z9rxB; Fri, 21 Jul 2023 14:25:16 +0200 (CEST) In-Reply-To: <87fs5hmp6i.fsf@localhost> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265684 Archived-At: Ihor Radchenko writes: >> Hmm, this would mean to extend the file-name-handler-alist spec. Instead >> of a regexp to check, we would need to allow a function call or >> alike. Don't know whether this pays for optimization. > > The question is: what is more costly > (a) matching complex regexp && call function or > (b) call function (lambda (fn) (when (and foo (match-string- ... fn)) ...)) (benchmark-run-compiled 10000000 (string-match-p (caar file-name-handler-alist) "/path/to/very/deep/file")) ;; => (1.495432981 0 0.0) (benchmark-run-compiled 10000000 (funcall (lambda (fn) (and nil (string-match-p (caar file-name-handler-alist) fn))) "/path/to/very/deep/file")) ;; => (0.42053276500000003 0 0.0) Looks like even funcall overheads are not as bad as invoking regexp search. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at