From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/helm 07dacfe2e2 08/11: Prefer string-match-p over string-suffix-p Date: Thu, 14 Sep 2023 18:49:28 +0000 Message-ID: <87cyyk60yo.fsf@posteo.net> References: <169468919249.10884.8856179202519044902@vcs2.savannah.gnu.org> <20230914105954.20BD1C051D0@vcs2.savannah.gnu.org> <875y4dosa4.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17264"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 14 20:54:44 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qgrUC-0004JC-H3 for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Sep 2023 20:54:44 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgrTH-0004eT-2l; Thu, 14 Sep 2023 14:53:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgrTA-0004Yq-AA for emacs-devel@gnu.org; Thu, 14 Sep 2023 14:53:41 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgrSz-0005r7-6R for emacs-devel@gnu.org; Thu, 14 Sep 2023 14:53:39 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 26B08240029 for ; Thu, 14 Sep 2023 20:53:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1694717603; bh=fwRlMgW5uaAZ/jXv14NXJzaLVZ5bmqgleyRjQ34p/Hs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Autocrypt:OpenPGP: From; b=m4IxAIRKm1ftmI3VuaIzyRO5wS9q1nAf1PD8qF1wuh9SEKWnWpP7eiynT41pb58Wa 6stecUClFxoT4tKFrmik6lb0sn9KWhxzmPoD02mZAl+5ro1L24yWaJDmYS1bZMkR1D PlR4REg5a2dlyrK6W9Lbhaw7w+wKgogO/i8WlGsM1ieLOhPb9Yn0K4ItjnKLCSr/L5 lSBVGGAvgznD4OexpazycPr9B+7qvENogHiJygdPptY6h95GtJf/aTlXvyCAsfrJ/V dQCrpcS/0mztzXodYvrWR8O0qTj4vodeDDjakPFadcuPYDTySDG+/YLvyH7dgAvdO1 orxVND/3l8NYA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Rmmg61nR0z9rxG; Thu, 14 Sep 2023 20:53:22 +0200 (CEST) In-reply-to: <875y4dosa4.fsf@posteo.net> Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata=xsDNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MAedi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0pkcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfbtG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQGVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqCWcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEAAc0SdGhpZXZvbEBwb3N0ZW8ubmV0wsEOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8hBp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslxhU46VSz1Z83NwIG3mpdYNV5WUTUdgzx ExHTNTFCd7NKv0nlHKQaAtdXm5bYnSHsnL7cx8z OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt Received-SPF: pass client-ip=185.67.36.65; envelope-from=thievol@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310585 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Philip Kaludercic writes: > ELPA Syncer writes: > >> branch: elpa/helm >> commit 07dacfe2e2db980a9e42afef2fc8539c155fdd0d >> Author: Thierry Volpiatto >> Commit: Thierry Volpiatto >> >> Prefer string-match-p over string-suffix-p >> --- >> helm-lib.el | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/helm-lib.el b/helm-lib.el >> index 2a93271f57..70df22089c 100644 >> --- a/helm-lib.el >> +++ b/helm-lib.el >> @@ -1732,7 +1732,7 @@ Directories expansion is not supported." >> (with-temp-buffer >> (call-process-shell-command=20 >> (format cmd >> - (if (string-suffix-p ".gz" file) >> + (if (string-match-p ".gz\\'" file) > > Is there a reason for this preference? Just a preference, I tried string-suffix-p but I prefer string-match-p which is more readable, for me at least. > Also, I assume you want to quote the period in ".gz\\'"? Yes, my mistake. > If so, I can recommend using `rx' or `wildcard-to-regexp' to avoid > mistakes like these. No thanks, I hate rx and unneeded complications more generally, I am used to plain regexps. > >> "gzip -c -q -d" "cat") >> (shell-quote-argument file) >> regexp) =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmUDVp8THHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvkw1/C/sE1z6VU7IREaGByrSu/aXSWgdXe+wi ia60JqiVGlA2vASa0aAtMhQKOqb7tEXr3ARzTXJlFdtQl3VuDSCRbyP9YA9fx61F Lw2qfGPi0s7IU0ihMPbq5GennQ3l2yTizesgapDAV1Qm+BHfDnNq18UCpiR9bOuU APhwjgH3rQ180lXwu1MHb7Y2FPeJm/3fyAL57c8noR30SIKiDl2TJJ81U+Notv6J F5wvrMr9HZMJnZZw1LqxMUyo3+J/aN1VF9TPvUgmJ6yBCpVCP0LrmrF00UOw0f8P 9JQoZWA2OWVdkyw9k9W52vyI2BTUstMU4SglbFs3ljyOAv5NJZUAyRAgTSTGGI/j 5wU9A0it6S8DV0hNRvAcQDI0RwPqR7SwT6hJM0DQ2eenN+J6Ui9EQ9Mw6wNMm8/k Bus6i1jBWEC+yMRux9+igFKBJy8lMhOcqgiitbQ0tGQWCIa+PVe+r4CBOIaC2T5S DhLKLstDmtxMEDNWf/Ny+0l7Z/4DMqwt9jg= =o1/o -----END PGP SIGNATURE----- --=-=-=--