From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnecting Date: Fri, 22 Sep 2023 08:23:42 +0000 Message-ID: <87cyyavcoh.fsf@posteo.net> References: <87bke85hsb.fsf@gmail.com> <87a5tobby9.fsf@debian-hx90.lan> <871qf0atqs.fsf@debian-hx90.lan> <878r97ooxs.fsf@posteo.net> <87a5tf3714.fsf@debian-hx90.lan> <87r0mrwkyp.fsf@posteo.net> <875y4331m2.fsf@debian-hx90.lan> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11368"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65882-done@debbugs.gnu.org, Ryan Yeske , Stefan Kangas , Leo Liu To: Manphiz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 22 10:25:08 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qjbTH-0002fG-Uw for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Sep 2023 10:25:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjbT5-0004mU-0w; Fri, 22 Sep 2023 04:24:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjbT2-0004mI-Dc for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 04:24:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjbT2-0006hw-4b for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 04:24:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qjbTC-00020s-JV for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 04:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Sep 2023 08:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65882 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65882-done@debbugs.gnu.org id=D65882.16953710447666 (code D ref 65882); Fri, 22 Sep 2023 08:25:02 +0000 Original-Received: (at 65882-done) by debbugs.gnu.org; 22 Sep 2023 08:24:04 +0000 Original-Received: from localhost ([127.0.0.1]:35282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjbSF-0001zY-Se for submit@debbugs.gnu.org; Fri, 22 Sep 2023 04:24:04 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:48689) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjbSD-0001z3-GP for 65882-done@debbugs.gnu.org; Fri, 22 Sep 2023 04:24:02 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 156AB24002A for <65882-done@debbugs.gnu.org>; Fri, 22 Sep 2023 10:23:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1695371025; bh=b/UEBTYhK1ZIL1qnErE3W7nqLOLa9MYuVM11gtzdY+8=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=Pc3t9Hn9YRvh+YVaKWTRm3vlAHHgcFLhqCk1KVaU4lrEHfvNxDg/FYQUdTDYh3GmP XxpZ9W1gbs6D0Dq/yrQzibOqtmvy0tgFg6fLlupF2I0T/JEqxxjBt9PtVYX/PG5UTa 9Pt27ZiluEkL82aLULEhhwLpMV/qpyyMzd963wjiTHw6YdsV6OCrRVW+Hp1CI052pj r4gDi1wqsigCexHEeNFEpW2qo5S8MO34IU6ODRZRykoy8k/F2S7cZKrzaPgc2eDijp iIX9JrKOvpAzNBAdhcerb+bjXa4sL3blfx5hpL53gOFF/YRSUoUbBjYxEW8kxCFbPV 7IDtaeiIOCqtg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RsQJt4SP7z9s0j; Fri, 22 Sep 2023 10:23:42 +0200 (CEST) In-Reply-To: <875y4331m2.fsf@debian-hx90.lan> (manphiz@gmail.com's message of "Thu, 21 Sep 2023 09:57:57 -0700") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271052 Archived-At: Manphiz writes: > Philip Kaludercic writes: > >> Manphiz writes: >> >>> Philip Kaludercic writes: >>> >>>> The change makes sense, but I'll want to try it out to make sure we are >>>> doing the right thing. Unless I write something here, ping me in a few >>>> days. These kinds of auto-reconnect bugs can be annoying to debug in >>>> real-life situations. >>>> >>> >>> Friendly ping. >> >> I haven't noticed any issues, and the change makes sense. I'll apply it >> to master. Thanks! >> > > Great, thanks! > > Additionally, is it OK to backport this to 29 branch or even 28 branch? I don't know if bugs are backported onto emacs-28, the branch seems to be stale. The emacs-29 branch might be viable, but I don't want to decide that myself. If Stefan is fine with that, I can take care of it. > Or is there any automatic backport process for release branches? Not that I know of. >>>> Manphiz writes: >>>> >>>>> Stefan Kangas writes: >>>>> >>>>>> severity 65882 + minor >>>>>> thanks >>>>>> >>>>>> Manphiz writes: >>>>>> >>>>>>> I noticed that you lowered the severity of this bug from "normal" to >>>>>>> "wishlist". AIUI rcirc provides a way to automatically join channels >>>>>>> upon connecting to a server and currently this is not working as >>>>>>> intended, so IMHO it should be considered a bug instead of a feature >>>>>>> request (a wishlist). >>>>>> >>>>>> Thanks, so I bumped it to minor. I hope that makes more sense. >>>>>> >>>>> >>>>> Thanks! >>>>> >>>>>>> (If you are using severity as a means to manage bug triage priority >>>>>>> I'm OK with that.) >>>>>> >>>>>> My impression is that almost no one pays attention to bug severities, so >>>>>> I wouldn't make too much of it. Bug reports that come with a patch, >>>>>> like yours did, tend to get more visibility though. >>>>>> >>>>> >>>>> Ah got it. It's my first time filing bug here so not very familiar with >>>>> the convention. Looks like tagging patch was a good move :) >>>> >>>> So this patch would be applied without a copyright assignment, right? >>>> >>>>>>> Personally, as the patch is sufficiently trivial, I would hope it won't >>>>>>> take too much work for a review. But I would understand if dealing with >>>>>>> rcirc-user-authenticated is more involved than it looks like and should >>>>>>> be handled with care. >>>>>> >>>>>> I've copied in the rcirc maintainers. Let's see if they have any >>>>>> comments first. >>>>> >>>>> Great! Thanks again!