From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: joakim@verona.se Newsgroups: gmane.emacs.bugs Subject: bug#68486: 29.1; Confusing window layout changes in image-dired Date: Tue, 16 Jan 2024 10:53:36 +0100 Message-ID: <87cyu1hae7.fsf@tanaka.verona.se> References: <86le8qfj3s.fsf@chopper> <874jfdwspy.fsf@ledu-giraud.fr> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3933"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 68486@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 16 10:54:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rPg9D-0000oo-4K for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Jan 2024 10:54:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rPg8y-0005wd-IF; Tue, 16 Jan 2024 04:54:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rPg8w-0005vX-8Z for bug-gnu-emacs@gnu.org; Tue, 16 Jan 2024 04:54:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rPg8v-000679-W3 for bug-gnu-emacs@gnu.org; Tue, 16 Jan 2024 04:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rPg8w-0000Nz-5N for bug-gnu-emacs@gnu.org; Tue, 16 Jan 2024 04:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: joakim@verona.se Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Jan 2024 09:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68486 X-GNU-PR-Package: emacs Original-Received: via spool by 68486-submit@debbugs.gnu.org id=B68486.17053988271449 (code B ref 68486); Tue, 16 Jan 2024 09:54:02 +0000 Original-Received: (at 68486) by debbugs.gnu.org; 16 Jan 2024 09:53:47 +0000 Original-Received: from localhost ([127.0.0.1]:47791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rPg8h-0000NI-B0 for submit@debbugs.gnu.org; Tue, 16 Jan 2024 04:53:47 -0500 Original-Received: from smtp.outgoing.loopia.se ([93.188.3.37]:24561) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rPg8e-0000Mx-IT for 68486@debbugs.gnu.org; Tue, 16 Jan 2024 04:53:45 -0500 Original-Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id B37DA2FD82E8 for <68486@debbugs.gnu.org>; Tue, 16 Jan 2024 10:53:37 +0100 (CET) Original-Received: from s899.loopia.se (unknown [172.22.191.5]) by s807.loopia.se (Postfix) with ESMTP id A4E052E2842F; Tue, 16 Jan 2024 10:53:37 +0100 (CET) Original-Received: from s473.loopia.se (unknown [172.22.191.5]) by s899.loopia.se (Postfix) with ESMTP id A33052C8BAA3; Tue, 16 Jan 2024 10:53:37 +0100 (CET) X-Virus-Scanned: amavisd-new at amavis.loopia.se Original-Received: from s899.loopia.se ([172.22.191.6]) by s473.loopia.se (s473.loopia.se [172.22.190.13]) (amavisd-new, port 10024) with LMTP id eBE9nrubVJVQ; Tue, 16 Jan 2024 10:53:36 +0100 (CET) X-Loopia-Auth: user X-Loopia-User: joakim@alicantealmeria.se X-Loopia-Originating-IP: 193.234.148.196 Original-Received: from tanaka.verona.se (unknown [193.234.148.196]) (Authenticated sender: joakim@alicantealmeria.se) by s899.loopia.se (Postfix) with ESMTPSA id BAFA42C8BA6D; Tue, 16 Jan 2024 10:53:36 +0100 (CET) In-Reply-To: <874jfdwspy.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Tue, 16 Jan 2024 10:08:41 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278325 Archived-At: Manuel Giraud writes: > joakim@verona.se writes: > >> I have a question about image dired. I find it very confusing the way >> window layout changes in image-dired happen. >> >> Basically I want a window layout like depicted here: >> https://www.emacswiki.org/emacs/ImageDired >> >> In words: a 3 window layout, dired to the left, image dired top right, larger >> view of current image bottom right. >> >> +----+----+ >> | | | >> | +----+ >> | | | >> +----+----+ >> >> Whenever I try to set this layout up by hand the main image view jumps between >> windows, ruining my layout. > > Hi Joakim, > > I have tried your layout and you're right that this is annoying: for me > the dired buffer and image view buffer are switching windows each time I > go to the next image. > > Maybe we should try to fix this but, as usual, with Emacs display layout > it could not be to everybody's taste. Agreed, but I think it wouldnt be controversial to keep an existing user created layout, and you seem to agree with this sentiment. > >> Theres a function image-dired-display-image that displays the image >> you select for display in the thumb view window. the call to >> kill-buffer and then pop-to-buffer would seem to indicate that this is >> the intended behaviour, or is it? Shouldnt the code try to preserve >> the users window configuration if possible? >> >> The function, notice kill-buffer then pop-to-buffer. > > Thanks for this hint. You're right that the kill/pop-to/rename dance > may be the cause of this issue. I tried just removing the kill-buffer, but that didnt work, I guess the call is there for a reason. I thought that if the buffer isnt killed, and the content just replaced everything should work, but aparently not. If you come up with a patch I will try it! -- Joakim Verona joakim@verona.se