* Re: [elpa] externals/counsel 14c696aa2d 1/2: Prefer Emacs 27 (TICKS . HZ) time values
[not found] ` <20240229151837.A73A5C12C4D@vcs2.savannah.gnu.org>
@ 2024-02-29 15:40 ` Stefan Monnier
2024-02-29 16:13 ` Basil L. Contovounesios
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2024-02-29 15:40 UTC (permalink / raw)
To: Basil L. Contovounesios; +Cc: emacs-devel
> +(defalias 'counsel--async-filter-update-time
> + (if (fboundp 'time-convert)
> + ;; Preferred (TICKS . HZ) format since Emacs 27.1.
> + (lambda () (cons counsel-async-filter-update-time 1000000))
Why not use `time-convert` rather than hardcode the internal representation?
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [elpa] externals/counsel 14c696aa2d 1/2: Prefer Emacs 27 (TICKS . HZ) time values
2024-02-29 15:40 ` [elpa] externals/counsel 14c696aa2d 1/2: Prefer Emacs 27 (TICKS . HZ) time values Stefan Monnier
@ 2024-02-29 16:13 ` Basil L. Contovounesios
2024-02-29 17:54 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Basil L. Contovounesios @ 2024-02-29 16:13 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier [2024-02-29 10:40 -0500] wrote:
>> +(defalias 'counsel--async-filter-update-time
>> + (if (fboundp 'time-convert)
>> + ;; Preferred (TICKS . HZ) format since Emacs 27.1.
>> + (lambda () (cons counsel-async-filter-update-time 1000000))
>
> Why not use `time-convert` rather than hardcode the internal representation?
It wasn't clear to me that any of these options is better:
1. (time-convert (/ counsel-async-filter-update-time 1e6) t)
2. (time-convert (cons counsel-async-filter-update-time 1000000) t)
3. ...?
Did you have something else in mind?
What would you recommend?
Thanks,
--
Basil
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [elpa] externals/counsel 14c696aa2d 1/2: Prefer Emacs 27 (TICKS . HZ) time values
2024-02-29 16:13 ` Basil L. Contovounesios
@ 2024-02-29 17:54 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2024-02-29 17:54 UTC (permalink / raw)
To: Basil L. Contovounesios; +Cc: emacs-devel
>>> +(defalias 'counsel--async-filter-update-time
>>> + (if (fboundp 'time-convert)
>>> + ;; Preferred (TICKS . HZ) format since Emacs 27.1.
>>> + (lambda () (cons counsel-async-filter-update-time 1000000))
>>
>> Why not use `time-convert` rather than hardcode the internal representation?
>
> It wasn't clear to me that any of these options is better:
>
> 1. (time-convert (/ counsel-async-filter-update-time 1e6) t)
> 2. (time-convert (cons counsel-async-filter-update-time 1000000) t)
Yeah, I guess all alternatives are about as good/bad.
Nevermind,
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-29 17:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <170921991732.23167.11490635005347998872@vcs2.savannah.gnu.org>
[not found] ` <20240229151837.A73A5C12C4D@vcs2.savannah.gnu.org>
2024-02-29 15:40 ` [elpa] externals/counsel 14c696aa2d 1/2: Prefer Emacs 27 (TICKS . HZ) time values Stefan Monnier
2024-02-29 16:13 ` Basil L. Contovounesios
2024-02-29 17:54 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.