all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <basil@contovou.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [elpa] externals/counsel 14c696aa2d 1/2: Prefer Emacs 27 (TICKS . HZ) time values
Date: Thu, 29 Feb 2024 17:13:13 +0100	[thread overview]
Message-ID: <87cysfs0yu.fsf@epfl.ch> (raw)
In-Reply-To: <jwvbk7zmg9j.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 29 Feb 2024 10:40:05 -0500")

Stefan Monnier [2024-02-29 10:40 -0500] wrote:

>> +(defalias 'counsel--async-filter-update-time
>> +  (if (fboundp 'time-convert)
>> +      ;; Preferred (TICKS . HZ) format since Emacs 27.1.
>> +      (lambda () (cons counsel-async-filter-update-time 1000000))
>
> Why not use `time-convert` rather than hardcode the internal representation?

It wasn't clear to me that any of these options is better:

1. (time-convert (/ counsel-async-filter-update-time 1e6) t)
2. (time-convert (cons counsel-async-filter-update-time 1000000) t)
3. ...?

Did you have something else in mind?
What would you recommend?

Thanks,
-- 
Basil



  reply	other threads:[~2024-02-29 16:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <170921991732.23167.11490635005347998872@vcs2.savannah.gnu.org>
     [not found] ` <20240229151837.A73A5C12C4D@vcs2.savannah.gnu.org>
2024-02-29 15:40   ` [elpa] externals/counsel 14c696aa2d 1/2: Prefer Emacs 27 (TICKS . HZ) time values Stefan Monnier
2024-02-29 16:13     ` Basil L. Contovounesios [this message]
2024-02-29 17:54       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cysfs0yu.fsf@epfl.ch \
    --to=basil@contovou.net \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.