all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Philip Kaludercic <philipk@posteo.net>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 69647@debbugs.gnu.org, "João Távora" <joaotavora@gmail.com>
Subject: bug#69647: [PATCH 1/2] Delete trailing whitespace when formatting LSP documentation
Date: Sat, 09 Mar 2024 09:02:10 +0000	[thread overview]
Message-ID: <87cys3dbhp.fsf@posteo.net> (raw)
In-Reply-To: <97befab2-f39a-9aac-41c6-cf1d4964aad8@gmail.com> (Jim Porter's message of "Fri, 8 Mar 2024 19:08:37 -0800")

Jim Porter <jporterbugs@gmail.com> writes:

> On 3/8/2024 1:36 PM, Jim Porter wrote:
>> However, as a partial fix, you could probably just set
>> 'markdown-line-break-face' to be invisible when
>> 'markdown-hide-markup[-in-view-modes]' is non-nil somewhere in
>> Markdown mode. I think that would be easy, although I tried to do
>> this and the obvious method didn't work, so who knows?
>
> I did a big more digging and came up with this patch to markdown-mode,
> implementing the partial fix I described above.
>
> Does this work for you, Philip? If so, I'll submit it to the
> markdown-mode maintainers.

Seems fine.  The only concern I have is if someone who enabled
`show-trailing-whitespace' would still get highlighted line-endings, but
I guess that's on markdown-mode to solve.

Does my patch have to be updated, or can we discard it then?

-- 
	Philip Kaludercic on peregrine





  reply	other threads:[~2024-03-09  9:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-08 15:48 bug#69647: [PATCH 1/2] Delete trailing whitespace when formatting LSP documentation Philip Kaludercic
2024-03-08 20:41 ` João Távora
2024-03-08 20:54 ` Jim Porter
2024-03-08 21:02   ` João Távora
2024-03-08 21:36     ` Jim Porter
2024-03-09  3:08       ` Jim Porter
2024-03-09  9:02         ` Philip Kaludercic [this message]
2024-03-09 18:28           ` Jim Porter
2024-03-09 18:46             ` Philip Kaludercic
2024-03-11  3:50             ` Jim Porter
2024-03-22  8:49               ` Philip Kaludercic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cys3dbhp.fsf@posteo.net \
    --to=philipk@posteo.net \
    --cc=69647@debbugs.gnu.org \
    --cc=joaotavora@gmail.com \
    --cc=jporterbugs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.