bug#70030: 29.3; package.el confused by ELPA nongnu archive meta-data for `annotate` listing multiple maintainers

bug#70030: 29.3; package.el confused by ELPA nongnu archive meta-data for `annotate` listing multiple maintainers

[Herbert Valerio Riedel]

I'm not sure if this a bug in package.el proper or rather an ELPA
archive bug:

When invoking `M-x describe-package annotate` to describe the `annotate`
package from https://elpa.nongnu.org/nongnu/annotate.html the function
errors out with

    describe-package-1: Wrong type argument: char-or-string-p, ("Bastian Bechtold" . "bastibe.dev@mailbox.org")

and its backtrace is basically

    Debugger entered--Lisp error: (wrong-type-argument char-or-string-p ("Bastian Bechtold" . "bastibe.dev@mailbox.org"))
      package--print-email-button((("Bastian Bechtold" . "bastibe.dev@mailbox.org") ("cage" . "cage-dev@twistfold.it")))
      describe-package-1(annotate)
      #f(compiled-function () #<bytecode -0xc22abc67090fa64>)()
      help--window-setup("*Help*" #f(compiled-function () #<bytecode -0xc22abc67090fa64>))
      describe-package(annotate)

pointing to the function `package--print-email-button` specifically not
being able to deal with the maintainer value

In fact, the 'annotate' meta-data entry in
`~/.emacs.d/elpa/archives/nongnu/archive-contents` looks like

    (annotate .
           [(2 2 1)
            nil "annotate files without changing them" tar
            ((:url . "https://github.com/bastibe/annotate.el")
             (:maintainer
              ("Bastian Bechtold" . "bastibe.dev@mailbox.org")
              ("cage" . "cage-dev@twistfold.it"))
             (:commit . "a388c39231207f6234ca1af547dbd29995ee476f"))])

as far as I could see, most package entries have rather a maintainer
value such as

    (:maintainer "Jordon Biondo" . "jordonbiondo@gmail.com")

or sometimes without an email addr, such as

    (:maintainer "Benjamin Beckwith")

and in some cases even something weird like

    (:maintainer "Andrea Orru <andreaorru1991@gmail.com>, Andrew Kelley" . "superjoe30@gmail.com")

which is surely not intended to be that way...



In GNU Emacs 29.3 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.20,
 cairo version 1.16.0) of 2024-03-25 built on bos03-amd64-034
Repository revision: 73d7d08f3f07a68b198e5ba230a474ba019e6a8a
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000

bug#70030: 29.3; package.el confused by ELPA nongnu archive meta-data for `annotate` listing multiple maintainers

[Philip Kaludercic]

Herbert Valerio Riedel <hvr@gnu.org> writes:

> I'm not sure if this a bug in package.el proper or rather an ELPA
> archive bug:
>
> When invoking `M-x describe-package annotate` to describe the `annotate`
> package from https://elpa.nongnu.org/nongnu/annotate.html the function
> errors out with
>
>     describe-package-1: Wrong type argument: char-or-string-p, ("Bastian Bechtold" . "bastibe.dev@mailbox.org")
>
> and its backtrace is basically
>
>     Debugger entered--Lisp error: (wrong-type-argument char-or-string-p ("Bastian Bechtold" . "bastibe.dev@mailbox.org"))
>       package--print-email-button((("Bastian Bechtold" . "bastibe.dev@mailbox.org") ("cage" . "cage-dev@twistfold.it")))
>       describe-package-1(annotate)
>       #f(compiled-function () #<bytecode -0xc22abc67090fa64>)()
>       help--window-setup("*Help*" #f(compiled-function () #<bytecode -0xc22abc67090fa64>))
>       describe-package(annotate)
>
> pointing to the function `package--print-email-button` specifically not
> being able to deal with the maintainer value

This sounds like a duplicate of bug#68288, that was resolved with
73cb931e5bab1b956f0569cd542468cfa7f4c9a7.  I cannot reproduce the bug on
master, either with annotate or with marginalia.

>
> In fact, the 'annotate' meta-data entry in
> `~/.emacs.d/elpa/archives/nongnu/archive-contents` looks like
>
>     (annotate .
>            [(2 2 1)
>             nil "annotate files without changing them" tar
>             ((:url . "https://github.com/bastibe/annotate.el")
>              (:maintainer
>               ("Bastian Bechtold" . "bastibe.dev@mailbox.org")
>               ("cage" . "cage-dev@twistfold.it"))
>              (:commit . "a388c39231207f6234ca1af547dbd29995ee476f"))])
>
> as far as I could see, most package entries have rather a maintainer
> value such as
>
>     (:maintainer "Jordon Biondo" . "jordonbiondo@gmail.com")
>
> or sometimes without an email addr, such as
>
>     (:maintainer "Benjamin Beckwith")
>
> and in some cases even something weird like
>
>     (:maintainer "Andrea Orru <andreaorru1991@gmail.com>, Andrew Kelley" . "superjoe30@gmail.com")
>
> which is surely not intended to be that way...
>
>
>
> In GNU Emacs 29.3 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.20,
>  cairo version 1.16.0) of 2024-03-25 built on bos03-amd64-034
> Repository revision: 73d7d08f3f07a68b198e5ba230a474ba019e6a8a
> Repository branch: master
> Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
>
>
>
>
>
>
>

-- 
	Philip Kaludercic on peregrine

bug#70030: 29.3; package.el confused by ELPA nongnu archive meta-data for `annotate` listing multiple maintainers

[Herbert Valerio Riedel]

Philip Kaludercic <philipk@posteo.net> writes:

>> I'm not sure if this a bug in package.el proper or rather an ELPA
>> archive bug:
>>
>> When invoking `M-x describe-package annotate` to describe the `annotate`
>> package from https://elpa.nongnu.org/nongnu/annotate.html the function
>> errors out with
>>
>>     describe-package-1: Wrong type argument: char-or-string-p, ("Bastian Bechtold" . "bastibe.dev@mailbox.org")

...

> This sounds like a duplicate of bug#68288, that was resolved with
> 73cb931e5bab1b956f0569cd542468cfa7f4c9a7.  I cannot reproduce the bug on
> master, either with annotate or with marginalia.

Oh, sorry for the noise then... I should have tried harder to find a
preexisting bug report about this :-/


However, what shall be done about entries with malformed :maintainer
properties such as

--8<---------------cut here---------------start------------->8---
     (gnuplot .
          [(0 8 1)
           ((emacs
             (25 1)))
           "Major-mode and interactive frontend for gnuplot" tar
           ((:url . "https://github.com/emacs-gnuplot/gnuplot")
            (:keywords "data" "gnuplot" "plotting")
            (:maintainer "Maxime Tréca <maxime@gmail.com>, Daniel Mendler" . "mail@daniel-mendler.de")
            (:authors
             ("Jon Oddie, Bruce Ravel, Phil Type"))
            (:commit . "663a89d263d4f26b996796d01b6a3b783449e0f5"))])
--8<---------------cut here---------------end--------------->8---

is this considered an package bug to be dealt with by the upstream
maintainer or rather a bug in the ELPA archive index creation step (and
whom shall I contact for that?) which apparently extracted the
information from

  https://raw.githubusercontent.com/emacs-gnuplot/gnuplot/0.8.1/gnuplot.el

which states

--8<---------------cut here---------------start------------->8---
;; Author:           Jon Oddie, Bruce Ravel, Phil Type
;; Maintainer:       Maxime Tréca <maxime@gmail.com>, Daniel Mendler <mail@daniel-mendler.de>
;; Created:          1998
;; Version:          0.8.1
;; Keywords:         data gnuplot plotting
;; URL:              https://github.com/emacs-gnuplot/gnuplot
;; Package-Requires: ((emacs "25.1"))
--8<---------------cut here---------------end--------------->8---

bug#70030: 29.3; package.el confused by ELPA nongnu archive meta-data for `annotate` listing multiple maintainers

[J.P.]

Hi Herbert,

Just noting a somewhat related bug:

  https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68660

Thanks,
J.P.

bug#70030: 29.3; package.el confused by ELPA nongnu archive meta-data for `annotate` listing multiple maintainers

[Philip Kaludercic]

Herbert Valerio Riedel <hvr@gnu.org> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>>> I'm not sure if this a bug in package.el proper or rather an ELPA
>>> archive bug:
>>>
>>> When invoking `M-x describe-package annotate` to describe the `annotate`
>>> package from https://elpa.nongnu.org/nongnu/annotate.html the function
>>> errors out with
>>>
>>>     describe-package-1: Wrong type argument: char-or-string-p, ("Bastian Bechtold" . "bastibe.dev@mailbox.org")
>
> ...
>
>> This sounds like a duplicate of bug#68288, that was resolved with
>> 73cb931e5bab1b956f0569cd542468cfa7f4c9a7.  I cannot reproduce the bug on
>> master, either with annotate or with marginalia.
>
> Oh, sorry for the noise then... I should have tried harder to find a
> preexisting bug report about this :-/

No problem, I'll close the bug then.

> However, what shall be done about entries with malformed :maintainer
> properties such as
>
>      (gnuplot .
>           [(0 8 1)
>            ((emacs
>              (25 1)))
>            "Major-mode and interactive frontend for gnuplot" tar
>            ((:url . "https://github.com/emacs-gnuplot/gnuplot")
>             (:keywords "data" "gnuplot" "plotting")
>             (:maintainer "Maxime Tréca <maxime@gmail.com>, Daniel Mendler" . "mail@daniel-mendler.de")
>             (:authors
>              ("Jon Oddie, Bruce Ravel, Phil Type"))
>             (:commit . "663a89d263d4f26b996796d01b6a3b783449e0f5"))])
>
>
> is this considered an package bug to be dealt with by the upstream
> maintainer or rather a bug in the ELPA archive index creation step (and
> whom shall I contact for that?) which apparently extracted the
> information from
>
>   https://raw.githubusercontent.com/emacs-gnuplot/gnuplot/0.8.1/gnuplot.el
>
> which states
>
> ;; Author:           Jon Oddie, Bruce Ravel, Phil Type
> ;; Maintainer:       Maxime Tréca <maxime@gmail.com>, Daniel Mendler <mail@daniel-mendler.de>
> ;; Created:          1998
> ;; Version:          0.8.1
> ;; Keywords:         data gnuplot plotting
> ;; URL:              https://github.com/emacs-gnuplot/gnuplot
> ;; Package-Requires: ((emacs "25.1"))

That is not the responsibility of the package maintainers.  Their header
is well-formed, I believe this was a bug with the elpa-admin.el script.
Either way, if I run the script locally, I get this entry in
archive-contents:

 --8<---------------cut here---------------start------------->8---
(gnuplot
  . [(0 8 1) ((emacs (25 1)))
     "Major-mode and interactive frontend for gnuplot" tar
     ((:url . "https://github.com/emacs-gnuplot/gnuplot")
      (:keywords "data" "gnuplot" "plotting")
      (:maintainer ("Maxime Tréca" . "maxime@gmail.com")
		   ("Daniel Mendler" . "mail@daniel-mendler.de"))
      (:commit . "663a89d263d4f26b996796d01b6a3b783449e0f5"))])
--8<---------------cut here---------------end--------------->8---

So the issue can be fixed upstream by releasing a new version of the
package.

-- 
	Philip Kaludercic on peregrine