From: Michael Heerdegen via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Lin Sun <sunlin7@hotmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
"74881@debbugs.gnu.org" <74881@debbugs.gnu.org>
Subject: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs
Date: Mon, 30 Dec 2024 02:37:33 +0100 [thread overview]
Message-ID: <87cyhavtlu.fsf@web.de> (raw)
In-Reply-To: <TYCPR01MB10004F2BBF48917C06E73BE29FB082@TYCPR01MB10004.jpnprd01.prod.outlook.com> (Lin Sun's message of "Sun, 29 Dec 2024 02:25:16 +0000")
Lin Sun <sunlin7@hotmail.com> writes:
> I didn't found a local version of `kill-emacs-hook` example in emacs
> git repo.
I would expect it to work. I found one in Gnu Elpa, in "subed.el".
> Current version also work for the killing from command line, for
> example executing a "pkill emacs" during ediff session.
I think this feature would not go.
> diff --git a/lisp/vc/ediff-util.el b/lisp/vc/ediff-util.el
> index 33666535843..d448973b345 100644
> --- a/lisp/vc/ediff-util.el
> +++ b/lisp/vc/ediff-util.el
> @@ -219,12 +219,11 @@ ediff--delete-temp-files-on-kill-emacs
> ;; where this hook could prevent kill-emacs from shutting down Emacs,
> ;; because user interaction is not possible (e.g., in a daemon), or
> ;; if deleting these files signals an error.
> - (ignore-errors
> - (let ((inhibit-interaction t))
> - (dolist (b (buffer-list))
> + (let ((inhibit-interaction t))
> + (dolist (b ediff-session-registry)
> + (ignore-errors
> (with-current-buffer b
> - (when (eq major-mode 'ediff-mode)
> - (ediff-delete-temp-files)))))))
> + (ediff-delete-temp-files))))))
>
> ;;; Setup functions
Yes, this is what I had in mind when the local hook can't be used.
Thank you,
Michael.
next prev parent reply other threads:[~2024-12-30 1:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-15 5:59 bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs Lin Sun
2024-12-15 8:04 ` Eli Zaretskii
2024-12-15 17:25 ` Lin Sun
2024-12-27 5:38 ` Lin Sun
2024-12-27 8:10 ` Eli Zaretskii
2024-12-27 17:34 ` Lin Sun
2024-12-28 7:38 ` Eli Zaretskii
2024-12-28 8:04 ` Lin Sun
2024-12-28 12:41 ` Eli Zaretskii
2024-12-28 17:40 ` Lin Sun
2024-12-29 1:49 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-29 2:25 ` Lin Sun
2024-12-30 1:37 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-12-30 2:07 ` Lin Sun
2024-12-30 22:37 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-29 7:04 ` Eli Zaretskii
2024-12-29 23:34 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-30 13:02 ` Eli Zaretskii
2024-12-30 22:34 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyhavtlu.fsf@web.de \
--to=bug-gnu-emacs@gnu.org \
--cc=74881@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=michael_heerdegen@web.de \
--cc=sunlin7@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.