bug#75116: [PATCH] Make 'yank-media' autoselect the best media type

[Ihor Radchenko <yantar92@posteo.net>]

Visuwesh <visuweshm@gmail.com> writes:

>>> >> +    (setq pref-type (and (null noselect)
>>> >> +                         (funcall yank-media-autoselect-function
>>> >> +                                  (mapcar #'car all-types))))
>>> >> +    (cond
>>> >> +     ;; We have one preferred mime type so use it unconditionally.
>>> >> +     ((and pref-type (symbolp pref-type))
>>> >> +      (funcall (cdr (assq pref-type all-types)) pref-type
>>> >> +               (yank-media--get-selection pref-type)))
>>> >> +     ;; The user chose to not autoselect and there's just a single type,
>>> >> +     ;; just call the handler.
>>> >> +     ((and (null pref-type) (length= all-types 1))
>>> >> +      (funcall (cdar all-types) (caar all-types)
>>> >> +               (yank-media--get-selection (caar all-types))))
>>> >
>>> > This goes against what the doc string says.  And I think the doc
>>> > string describes a better behavior: if the user asked not to
>>> > auto-select, we shouldn't, even if there's just one type available.
>>> > We should instead ask the user whether to yank that type, because the
>>> > user could decide she doesn't want that type, even it it's the only
>>> > one.
>>> ...
>>> I want to ensure we are on the same page wrt UI here:
>>> 
>>>     User asks to autoselect:
>>>       1. autoselect-function (a-s-f) returns one media type: we yank it.
>>
>> Yes.
>>
>>>       2. a-s-f returns multiple media types: we ask the user which one
>>>          to yank.
>>
>> No, we use the first one.
>
> Doesn't this mean there is pratically no difference between (1) and (2)?
> Ihor, is this okay?  Or did you have something else in mind when you
> asked for the possibility to return multiple types?

Eli, what exactly do you mean by "user asks to autoselect"?
AFAIU, autoselect is done by default. User cannot ask for it. User can
only supply a prefix argument to explicitly disable autoselection.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>