all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: slow bibtex menu access
Date: Sat, 05 Mar 2005 16:27:00 -0500	[thread overview]
Message-ID: <87br9xkcv0.fsf-monnier+gnu.emacs.help@gnu.org> (raw)
In-Reply-To: mailman.2485.1109868847.32256.help-gnu-emacs@gnu.org

> Thank you, I'd forgotten that (haven't done it in a long time). So I found
> the problem, and it was table.el. I had (require 'table) and (require
> 'emacs-wiki-table) (the latter requires table.el) in a few places. I have
> no idea where and how table.el is causing the problem, but would it be
> possible to turn it off (I guess a hook might do it) while in bibtex?
> Tables are not needed in bibtex anyway.

Setting debug-on-quit and hitting C-g while the menu is being built
indicates that the time is actually spent in table--find-row-column.

Looking some more at the table.el code, it seems there is a minor
logic-thinko bug in it.  Can you try the patch below (it's against the
Emacs-CVS version of table.el, so you may have to apply the patch by hand).

Tak, is my reasoning correct that `table--probe-cell' should return non-nil
iff we're inside a table?


        Stefan


--- orig/lisp/textmodes/table.el
+++ mod/lisp/textmodes/table.el
@@ -1025,13 +1025,13 @@
       :help "Insert a text based table at point"]
      ["Row" table-insert-row
       :active (and (not buffer-read-only)
-		   (or (table--probe-cell)
+		   (and (table--probe-cell)
 		       (save-excursion
 			 (table--find-row-column nil t))))
       :help "Insert row(s) of cells in table"]
      ["Column" table-insert-column
       :active (and (not buffer-read-only)
-		   (or (table--probe-cell)
+		   (and (table--probe-cell)
 		       (save-excursion
 			 (table--find-row-column 'column t))))
       :help "Insert column(s) of cells in table"])
@@ -1077,13 +1077,13 @@
     ("Insert"
      ["Row" table-insert-row
       :active (and (not buffer-read-only)
-		   (or (table--probe-cell)
+		   (and (table--probe-cell)
 		       (save-excursion
 			 (table--find-row-column nil t))))
       :help "Insert row(s) of cells in table"]
      ["Column" table-insert-column
       :active (and (not buffer-read-only)
-		   (or (table--probe-cell)
+		   (and (table--probe-cell)
 		       (save-excursion
 			 (table--find-row-column 'column t))))
       :help "Insert column(s) of cells in table"])

  parent reply	other threads:[~2005-03-05 21:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.2117.1109641717.32256.help-gnu-emacs@gnu.org>
2005-03-01 12:19 ` slow bibtex menu access Roland Winkler
2005-03-01 14:06   ` Sebastian Luque
2005-03-01 14:31     ` Sebastian Luque
     [not found]   ` <mailman.2167.1109686744.32256.help-gnu-emacs@gnu.org>
2005-03-01 14:44     ` Roland.Winkler
2005-03-01 16:36       ` Sebastian Luque
     [not found]       ` <mailman.2198.1109696777.32256.help-gnu-emacs@gnu.org>
2005-03-01 22:13         ` Jochen Küpper
2005-03-02 13:08 ` Stefan Monnier
2005-03-02 19:47   ` Sebastian Luque
     [not found]   ` <mailman.2371.1109793933.32256.help-gnu-emacs@gnu.org>
2005-03-03  4:04     ` Chong Yidong
2005-03-03 16:18       ` Sebastian Luque
     [not found]       ` <mailman.2485.1109868847.32256.help-gnu-emacs@gnu.org>
2005-03-05 21:27         ` Stefan Monnier [this message]
2005-03-08 22:56           ` Tak Ota
2005-03-14 17:15             ` Tak Ota
2005-03-18 22:07               ` Tak Ota
2005-03-01  1:25 Sebastian Luque

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87br9xkcv0.fsf-monnier+gnu.emacs.help@gnu.org \
    --to=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.