[PATCH] [Peter Dyballa] --enable-locallisppath=PATH does not work when PATH contains space

[PATCH] [Peter Dyballa] --enable-locallisppath=PATH does not work when PATH contains space

[Jérôme Marant]

Hi,

The following patch seems to fix the problem.
Please confirm.

Regards,

diff -u -r emacs.orig/ChangeLog emacs/ChangeLog
--- emacs.orig/ChangeLog	2005-06-07 22:07:31.466158056 +0200
+++ emacs/ChangeLog	2005-06-07 22:26:48.707230672 +0200
@@ -1,3 +1,8 @@
+2005-06-07  Jérôme Marant  <jerome@marant.org>
+
+	* Makefile.in (epaths-force): Protect both lisppath
+	and buildlisppath from whitespaces.
+
 2005-06-06  Jan Djärv  <jan.h.d@swipnet.se>
 
 	* configure.in (HAVE_CANCELMENUTRACKING): New test.
diff -u -r emacs.orig/Makefile.in emacs/Makefile.in
--- emacs.orig/Makefile.in	2004-12-23 22:40:31.000000000 +0100
+++ emacs/Makefile.in	2005-06-07 22:19:39.384497648 +0200
@@ -260,8 +260,8 @@
 	  x_default_search_path=`echo ${x_default_search_path}`; \
 	  gamedir=`echo ${gamedir}`; \
 	  sed < ${srcdir}/src/epaths.in > epaths.h.$$$$		\
-	  -e 's;\(#.*PATH_LOADSEARCH\).*$$;\1 "'$${lisppath}'";'	\
-	  -e 's;\(#.*PATH_DUMPLOADSEARCH\).*$$;\1 "'$${buildlisppath}'";' \
+	  -e 's;\(#.*PATH_LOADSEARCH\).*$$;\1 "'"$${lisppath}"'";'	\
+	  -e 's;\(#.*PATH_DUMPLOADSEARCH\).*$$;\1 "'"$${buildlisppath}"'";' \
 	  -e 's;\(#.*PATH_EXEC\).*$$;\1 "${archlibdir}";'		\
 	  -e 's;\(#.*PATH_INFO\).*$$;\1 "${infodir}";'			\
 	  -e 's;\(#.*PATH_DATA\).*$$;\1 "${etcdir}";'			\


-- 
Jérôme Marant

Re: [PATCH] [Peter Dyballa] --enable-locallisppath=PATH does not work when PATH contains space

[Peter Dyballa]

Am 07.06.2005 um 22:32 schrieb Jérôme Marant:

> The following patch seems to fix the problem.
>

Allô!

It really works *very* fine, since it's able to handle a whole list of 
such paths with a space in each one!

Could you implement it in all other Emacs versions? Personally I am 
interested in Emacs 22.0.50 too ...

--
Greetings

   Pete

Our enemies are innovative and resourceful, and so are we. They never
stop thinking about new ways to harm our country and our people, and
neither do we. -- Georges W. Bush

Re: [PATCH] [Peter Dyballa] --enable-locallisppath=PATH does not work when PATH contains space

[Peter Dyballa]

Am 07.06.2005 um 22:32 schrieb Jérôme Marant:

> The following patch seems to fix the problem.
> Please confirm.
>

No, today I don't want to! configure works fine and creates the  
Makefile, but during installation this happens:

	/Users/pete/Quellen/Emacs_CVS/emacs--unicode--0--patch-55/ 
mkinstalldirs /usr/local/share/emacs/23.0.0/etc  
/usr/local/share/emacs/23.0.0/lisp /usr/local/info /usr/local/man/man1  
\
	  /usr/local/bin /usr/local/share/emacs/23.0.0/etc /usr/local/libexec \
	  /usr/local/share/emacs/site-lisp \
	  /usr/local/share/emacs/23.0.0/site-lisp \
	  `echo /Library/Application  
Support/Emacs/calendar23:/Library/Application  
Support/Emacs/preview:/Library/Application  
Support/Emacs/auctex/images:/Library/Application  
Support/Emacs/auctex:/Library/Application Support/Emacs | sed 's/:/  
/g'`
	mkdir Support
	mkdir Support/Emacs
	mkdir Support/Emacs/calendar23
	mkdir Support/Emacs/preview
	mkdir Support/Emacs/auctex
	mkdir Support/Emacs/auctex/images
	(cd man; make  info)

So I have now in  
/Users/pete/Quellen/Emacs_CVS/emacs--unicode--0--patch-55 a little tree  
of empty directories starting with Support:
	
	pete 222 /\ l -R Support
	total 0
	drwxr-xr-x  5 root  pete  170  8 Jun 13:57 Emacs
	
	Support/Emacs:
	total 0
	drwxr-xr-x  3 root  pete  102  8 Jun 13:57 auctex
	drwxr-xr-x  2 root  pete   68  8 Jun 13:57 calendar23
	drwxr-xr-x  2 root  pete   68  8 Jun 13:57 preview
	
	Support/Emacs/auctex:
	total 0
	drwxr-xr-x  2 root  pete  68  8 Jun 13:57 images
	
	Support/Emacs/auctex/images:
	
	Support/Emacs/calendar23:
	
	Support/Emacs/preview:

And /Library/Application ...


IMO it would be OK if make would not take care for the directories in  
locallisppath since it does not install anything there -- I think  
that's in the local maintainer's duty completely ...

--
Greetings

   Pete

Windows, c'est un peu comme le beaujolais nouveau: à chaque nouvelle  
cuvée on sait que ce sera dégueulasse, mais on en prend quand même, par  
masochisme.

Re: [PATCH] [Peter Dyballa] --enable-locallisppath=PATH does not work when PATH contains space

[Jérôme Marant]

Hi,

Is anyone interested in applying this patch?

Regards,

Jérôme Marant <jmarant@free.fr> writes:

> Hi,
>
> The following patch seems to fix the problem.
> Please confirm.
>
> Regards,
>
> diff -u -r emacs.orig/ChangeLog emacs/ChangeLog
> --- emacs.orig/ChangeLog	2005-06-07 22:07:31.466158056 +0200
> +++ emacs/ChangeLog	2005-06-07 22:26:48.707230672 +0200
> @@ -1,3 +1,8 @@
> +2005-06-07  Jérôme Marant  <jerome@marant.org>
> +
> +	* Makefile.in (epaths-force): Protect both lisppath
> +	and buildlisppath from whitespaces.
> +
>  2005-06-06  Jan Djärv  <jan.h.d@swipnet.se>
>  
>  	* configure.in (HAVE_CANCELMENUTRACKING): New test.
> diff -u -r emacs.orig/Makefile.in emacs/Makefile.in
> --- emacs.orig/Makefile.in	2004-12-23 22:40:31.000000000 +0100
> +++ emacs/Makefile.in	2005-06-07 22:19:39.384497648 +0200
> @@ -260,8 +260,8 @@
>  	  x_default_search_path=`echo ${x_default_search_path}`; \
>  	  gamedir=`echo ${gamedir}`; \
>  	  sed < ${srcdir}/src/epaths.in > epaths.h.$$$$		\
> -	  -e 's;\(#.*PATH_LOADSEARCH\).*$$;\1 "'$${lisppath}'";'	\
> -	  -e 's;\(#.*PATH_DUMPLOADSEARCH\).*$$;\1 "'$${buildlisppath}'";' \
> +	  -e 's;\(#.*PATH_LOADSEARCH\).*$$;\1 "'"$${lisppath}"'";'	\
> +	  -e 's;\(#.*PATH_DUMPLOADSEARCH\).*$$;\1 "'"$${buildlisppath}"'";' \
>  	  -e 's;\(#.*PATH_EXEC\).*$$;\1 "${archlibdir}";'		\
>  	  -e 's;\(#.*PATH_INFO\).*$$;\1 "${infodir}";'			\
>  	  -e 's;\(#.*PATH_DATA\).*$$;\1 "${etcdir}";'			\
>
>
> -- 
> Jérôme Marant
>
>
> _______________________________________________
> Emacs-devel mailing list
> Emacs-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-devel
>

-- 
Jérôme Marant

Re: [PATCH] [Peter Dyballa] --enable-locallisppath=PATH does not work when PATH contains space

[Lute Kamstra]

Hi Jérôme,

> Is anyone interested in applying this patch?

Yep, I'll do that.

Lute.

Re: [PATCH] [Peter Dyballa] --enable-locallisppath=PATH does not work when PATH contains space

[Jérôme Marant]

Selon Lute Kamstra <Lute.Kamstra.lists@xs4all.nl>:

> Hi Jérôme,

Hi,

> > Is anyone interested in applying this patch?
>
> Yep, I'll do that.

Many thanks in advance!

--
Jérôme Marant