From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Buffer menu fix Date: Mon, 05 Sep 2005 20:23:13 -0400 Message-ID: <87br37gi32.fsf@stupidchicken.com> References: <87slwkfxt9.fsf@stupidchicken.com> <17180.56255.712298.670071@farnswood.snap.net.nz> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1125968716 27377 80.91.229.2 (6 Sep 2005 01:05:16 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 6 Sep 2005 01:05:16 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 06 03:05:14 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1ECRst-0004ur-B4 for ged-emacs-devel@m.gmane.org; Tue, 06 Sep 2005 03:04:23 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ECRxM-0003Mc-3a for ged-emacs-devel@m.gmane.org; Mon, 05 Sep 2005 21:09:00 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ECRwr-0003HC-0B for emacs-devel@gnu.org; Mon, 05 Sep 2005 21:08:29 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ECRwn-0003GS-6r for emacs-devel@gnu.org; Mon, 05 Sep 2005 21:08:26 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ECRsT-0001uV-Si for emacs-devel@gnu.org; Mon, 05 Sep 2005 21:03:57 -0400 Original-Received: from [18.95.6.46] (helo=localhost.localdomain) by monty-python.gnu.org with esmtp (Exim 4.34) id 1ECRIn-00063B-Gi for emacs-devel@gnu.org; Mon, 05 Sep 2005 20:27:05 -0400 Original-Received: by localhost.localdomain (Postfix, from userid 1000) id 21A4F1E44B2; Mon, 5 Sep 2005 20:23:13 -0400 (EDT) Original-To: Nick Roberts In-Reply-To: <17180.56255.712298.670071@farnswood.snap.net.nz> (Nick Roberts's message of "Tue, 6 Sep 2005 11:58:55 +1200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:42635 Archived-At: > With this patch header-line buttons in the buffer list buffer certainly > respond to Mouse-1 but unfortunately they do this even when > mouse-1-click-follows-link is nil. This behavior is the same as Info-mode. It makes sense because mouse-1 on the header line would not set point, as it would in the main editing area. > I don't think > > > ! (define-key map [follow-link] 'mouse-face) > > does anything in this case possibly because map here is a text property and > not associated with a mode. This deals with the case when Buffer-menu-use-header-line is nil. > It would be best to omit the line > > > ! (define-key map [header-line down-mouse-1] 'ignore) > > because then the header line can then respond to mouse-1 clicks and still be > dragged (try it on the mode-line to see what I mean). You can drag it by clicking on any part of the header line outside the button text. Again, this is the same as Info-mode. > > ! (define-key map "\C-m" > > ! `(lambda () (interactive) > > ! (Buffer-menu-sort ,column))) > > I don't see the point of this as you can't place point on the header line. This deals with the case when Buffer-menu-use-header-line is nil. > In summary, I don't see how to solve the problem (neither did the original > author presumably), all I can do is pull your solution apart. With my code, clicking mouse-1 actually works, where previously it didn't. If there are any other problems with my solution, feel free to point them out.