From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: michael.cadilhac@lrde.org (=?iso-8859-1?Q?Micha=EBl?= Cadilhac) Newsgroups: gmane.emacs.devel Subject: Re: Ispell loads dict twice. Date: Tue, 06 Jun 2006 22:45:03 +0200 Organization: Epita/LRDE Message-ID: <87bqt6xbcg.fsf@lrde.org> References: <87k69eyddj.fsf@lrde.org> <87fyj0r41g.fsf@lrde.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2033760308==" X-Trace: sea.gmane.org 1149626625 10795 80.91.229.2 (6 Jun 2006 20:43:45 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 6 Jun 2006 20:43:45 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 06 22:43:41 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FniOn-0001F8-6Q for ged-emacs-devel@m.gmane.org; Tue, 06 Jun 2006 22:43:37 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FniOm-0005NH-Rf for ged-emacs-devel@m.gmane.org; Tue, 06 Jun 2006 16:43:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FniOa-0005Mu-F7 for emacs-devel@gnu.org; Tue, 06 Jun 2006 16:43:24 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FniOY-0005MU-Vb for emacs-devel@gnu.org; Tue, 06 Jun 2006 16:43:24 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FniOY-0005MQ-TH for emacs-devel@gnu.org; Tue, 06 Jun 2006 16:43:22 -0400 Original-Received: from [62.39.139.2] (helo=kualalumpur.lrde.epita.fr) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1FniVz-0001dz-MY for emacs-devel@gnu.org; Tue, 06 Jun 2006 16:51:04 -0400 Original-Received: from mahaena.lrde.epita.fr ([192.168.101.66] helo=mahaena.lrde) by kualalumpur.lrde.epita.fr with esmtp (Exim 4.50) id 1FniOW-0004Dw-DH for emacs-devel@gnu.org; Tue, 06 Jun 2006 22:43:20 +0200 Original-To: emacs-devel@gnu.org Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEVWPh+Tai+5r5YKBAEU CQQzGAtiq7gjAAACR0lEQVQ4jW2UzW7lIAyFzVW8BzTZX5DmCZLuU2H2pMXv/ypzbK7aSh2kRCRf /HNsE0q7Sg+RQ7JFKaqtrRNAl5AIIKe6D5DBqgbmUAe5hBI1wIRFAHjeM0RKtZi7XVVEpb0BSNfA IddChChT5DildSLWOWhY5IEItMnncZgFcUAc/5jjwCMsDosRNdfKPDTFEdVBW8C+RebDb4N5Orio RhM1+11IJyx0ng2+LryFHBMPDQDYHrY6IfGuU3ouiXTQNE8LIJDKOWpNxERTFrggQwRPd7USUsTW fJ0XbR3bdj5KgBYy4SACpxDeUYEUAzLmtJ1iIrD2gczPq8Qomjhsh/RjGIgKIO8p7NITjwlx7WID nsnQe5NeuTvoBpi8LX6vLLOh5icjOHqBypgnuSp7M+RE1agbQKHQr5E2z1WObhYW4gMqeGQL7joM jCf2DxSk5ApADSYHfFF4igNfJZL1z0GKP0FN02s4XiDXr7V5P94W6I9v8MfBOQDmfwAaVYt+x8Da v4DJvX8BAdin3Knm5yMZYAO4ABDkDniZLLfi4P40gP1F0TPGZOu0CGwA1lcowxwlGy6A9705mD0V jHCxwVZT/hYdRJVUGZNlx6l7ScQBTluof6Wj6bsPYlvpwoTvXFD9gHPn2TZPF3ntI2ecxVrW5MrV XiCie5EeNa7BlWu/HNSkprDUva163PHxAv5jyGV7gVzyAghSKOTnat85UIYFICXbD2NV9rRiv0BS tKQsg6OHH4A15F1WW+UHKHHa32h6aPnAm3/pUcWp+WYnTQAAAABJRU5ErkJggg== In-Reply-To: <87fyj0r41g.fsf@lrde.org> (=?iso-8859-1?Q?Micha=EBl?= Cadilhac's message of "Tue, 23 May 2006 20:26:19 +0200") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:55761 Archived-At: --===============2033760308== Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Can someone please install the following change, as it has been reviewed by the concerned people? Thanks. michael.cadilhac@lrde.org (Micha=EBl Cadilhac) writes: > I was wondering why ispell-kill-process took so much time to > execute. > > This function does the following: > - Send EOF to ispell, > - Read its output if there is, timeout to 1 sec, > - Kill the process if it's still not, > - Wait for it to be really killed (sleeping for 0.25 sec between checks). > > I don't want to be ... rude, I'm really a pacifist actually, but why > not just delete-process it ? > > I often have some flyspellized buffers in English and some others in > French, the time I have to wait on every C-x o is kind of > disturbing... > > I propose the following change: --=-=-= Content-Type: text/x-patch; charset=iso-8859-1 Content-Disposition: inline; filename=ispell.patch Content-Transfer-Encoding: quoted-printable Index: lisp/ChangeLog =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /sources/emacs/emacs/lisp/ChangeLog,v retrieving revision 1.9661 diff -c -r1.9661 ChangeLog *** lisp/ChangeLog 1 Jun 2006 06:42:07 -0000 1.9661 =2D-- lisp/ChangeLog 6 Jun 2006 20:42:02 -0000 *************** *** 1,3 **** =2D-- 1,11 ---- + 2006-06-06 Micha=EBl Cadilhac +=20 + * textmodes/ispell.el (ispell-kill-ispell): If ispell has been + launched asynchronously, delete its process instead of being + cool. + (ispell-async-processp): Check for `delete-process' existence + instead of `kill-process' one for consistency. +=20 2006-06-01 Jan Dj=E4rv =20=20 * term/x-win.el: Change x-menu-bar-start to menu-bar-open. Index: lisp/textmodes/ispell.el =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /sources/emacs/emacs/lisp/textmodes/ispell.el,v retrieving revision 1.199 diff -c -r1.199 ispell.el *** lisp/textmodes/ispell.el 21 May 2006 20:25:43 -0000 1.199 =2D-- lisp/textmodes/ispell.el 6 Jun 2006 20:42:03 -0000 *************** *** 865,871 **** (defvar ispell-process nil "The process object for Ispell.") =20=20 ! (defvar ispell-async-processp (and (fboundp 'kill-process) (fboundp 'process-send-string) (fboundp 'accept-process-output) ;;(fboundp 'start-process) =2D-- 865,871 ---- (defvar ispell-process nil "The process object for Ispell.") =20=20 ! (defvar ispell-async-processp (and (fboundp 'delete-process) (fboundp 'process-send-string) (fboundp 'accept-process-output) ;;(fboundp 'start-process) *************** *** 2572,2586 **** (or no-error (error "There is no ispell process running!")) (if ispell-async-processp ! (progn ! (process-send-eof ispell-process) ! (if (eq (ispell-process-status) 'run) ! (ispell-accept-output 1)) ! (if (eq (ispell-process-status) 'run) ! (kill-process ispell-process)) ! (while (not (or (eq (ispell-process-status) 'exit) ! (eq (ispell-process-status) 'signal))) ! (sleep-for 0.25))) ;; synchronous processes (ispell-send-string "\n") ; make sure side effects occurred. (kill-buffer ispell-output-buffer) =2D-- 2572,2578 ---- (or no-error (error "There is no ispell process running!")) (if ispell-async-processp ! (delete-process ispell-process) ;; synchronous processes (ispell-send-string "\n") ; make sure side effects occurred. (kill-buffer ispell-output-buffer) --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable =2D-=20 | Micha=EBl `Micha' Cadilhac | La culture c'est comme la confiture= , | | Epita/LRDE Promo 2007 | c'est meilleur avec du pain. = | | http://www.lrde.org/~cadilh_m | -- MOI59 = | `-- - JID: micha@amessage.be --' - -= -' --=-=-=-- --==-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) iD8DBQFEhelRZYNf4qobZ7kRAvPVAKDTYsesabZDYOxxSjF7T97VA4SegwCfQ0pN qtmkGnaWfb0EZKQzUeeoT+A= =/JeG -----END PGP SIGNATURE----- --==-=-=-- --===============2033760308== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --===============2033760308==--