From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: two related edebug problems Date: Sat, 12 Aug 2006 00:02:10 -0400 Message-ID: <87bqqqy531.fsf@furball.mit.edu> References: <2cd46e7f0608071130o7d72123ct82841031bf757f5d@mail.gmail.com> <2cd46e7f0608081226o63f2a0d5q9e79575021d0a181@mail.gmail.com> <873bc4k1yl.fsf@furball.mit.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1155355361 31666 80.91.229.2 (12 Aug 2006 04:02:41 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 12 Aug 2006 04:02:41 +0000 (UTC) Cc: Ken Manheimer , rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 12 06:02:38 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GBkho-0007dL-9g for ged-emacs-devel@m.gmane.org; Sat, 12 Aug 2006 06:02:37 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GBkhn-0000xE-NG for ged-emacs-devel@m.gmane.org; Sat, 12 Aug 2006 00:02:35 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GBkhc-0000x9-71 for emacs-devel@gnu.org; Sat, 12 Aug 2006 00:02:24 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GBkha-0000x1-U9 for emacs-devel@gnu.org; Sat, 12 Aug 2006 00:02:22 -0400 Original-Received: from [18.72.1.2] (helo=south-station-annex.mit.edu) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1GBkms-000434-2B; Sat, 12 Aug 2006 00:07:50 -0400 Original-Received: from central-city-carrier-station.mit.edu (CENTRAL-CITY-CARRIER-STATION.MIT.EDU [18.7.7.72]) by south-station-annex.mit.edu (8.13.6/8.9.2) with ESMTP id k7C42KqS010128; Sat, 12 Aug 2006 00:02:21 -0400 (EDT) Original-Received: from outgoing-legacy.mit.edu (OUTGOING-LEGACY.MIT.EDU [18.7.22.104]) by central-city-carrier-station.mit.edu (8.13.6/8.9.2) with ESMTP id k7C42IE3003456; Sat, 12 Aug 2006 00:02:20 -0400 (EDT) Original-Received: from furball.mit.edu (SYDNEYPACIFIC-ONE-NINETEEN.MIT.EDU [18.95.5.119]) ) by outgoing-legacy.mit.edu (8.13.6/8.12.4) with ESMTP id k7C42ARO008071; Sat, 12 Aug 2006 00:02:10 -0400 (EDT) Original-Received: from cyd by furball.mit.edu with local (Exim 3.36 #1 (Debian)) id 1GBkhO-0002oL-00; Sat, 12 Aug 2006 00:02:10 -0400 Original-To: Stefan Monnier In-Reply-To: (Stefan Monnier's message of "Fri, 11 Aug 2006 18:34:29 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-Spam-Score: 1.217 X-Scanned-By: MIMEDefang 2.42 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:58307 Archived-At: Stefan Monnier writes: >> I found out the cause of the bug. edebug-display calls sit-for to >> pause before displaying eval results, then calls >> edebug-recursive-edit. However, edebug-recursive-edit rebinds >> unread-command-events, causing sit-for interruptions (which are put >> into unread-command-events) to go unnoticed. This creates problems >> when you type in edebug commands in quick succession. I fixed this by >> moving the rebinding of unread-command-events to edebug-display. > > This is a workaround rather than a fix. A real fix would be to change > sit-for so it doesn't use unread-command-events but an internal variable > instead with which other code can't mess. Is this really necessary? It seems to me that code that messes with unread-command-events should simply take the behavior of sit-for into account, and avoid breaking it. I'm not sure this situation arises often enough to justify introducing a separate unread-command-events mechanism for sit-for.