all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
Cc: Ken Manheimer <ken.manheimer@gmail.com>,
	rms@gnu.org, emacs-devel@gnu.org
Subject: Re: two related edebug problems
Date: Sat, 12 Aug 2006 00:02:10 -0400	[thread overview]
Message-ID: <87bqqqy531.fsf@furball.mit.edu> (raw)
In-Reply-To: <jwv3bc2x5r7.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 11 Aug 2006 18:34:29 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> I found out the cause of the bug.  edebug-display calls sit-for to
>> pause before displaying eval results, then calls
>> edebug-recursive-edit.  However, edebug-recursive-edit rebinds
>> unread-command-events, causing sit-for interruptions (which are put
>> into unread-command-events) to go unnoticed.  This creates problems
>> when you type in edebug commands in quick succession.  I fixed this by
>> moving the rebinding of unread-command-events to edebug-display.
>
> This is a workaround rather than a fix.  A real fix would be to change
> sit-for so it doesn't use unread-command-events but an internal variable
> instead with which other code can't mess.

Is this really necessary?  It seems to me that code that messes with
unread-command-events should simply take the behavior of sit-for into
account, and avoid breaking it.  I'm not sure this situation arises
often enough to justify introducing a separate unread-command-events
mechanism for sit-for.

  parent reply	other threads:[~2006-08-12  4:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-07 18:30 two related edebug problems Ken Manheimer
2006-08-08 18:02 ` Richard Stallman
2006-08-08 19:26   ` Ken Manheimer
2006-08-09 14:42     ` Chong Yidong
2006-08-09 19:42       ` Ken Manheimer
2006-08-10  1:13       ` Richard Stallman
2006-08-10 16:08     ` Chong Yidong
2006-08-11 22:34       ` Stefan Monnier
2006-08-12  0:19         ` Kim F. Storm
2006-08-12 21:50           ` Richard Stallman
2006-08-12  4:02         ` Chong Yidong [this message]
2006-08-12 21:50         ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bqqqy531.fsf@furball.mit.edu \
    --to=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    --cc=ken.manheimer@gmail.com \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.