From: Karl Fogel <kfogel@red-bean.com>
To: Miles Bader <miles@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: ChangeLog policy for same-day changes to a file?
Date: Wed, 02 Jan 2008 01:39:59 -0800 [thread overview]
Message-ID: <87bq84r2fk.fsf@red-bean.com> (raw)
In-Reply-To: <87wsqsu2o9.fsf@catnip.gol.com> (Miles Bader's message of "Wed\, 02 Jan 2008 16\:06\:30 +0900")
Miles Bader <miles@gnu.org> writes:
> Karl Fogel <kfogel@red-bean.com> writes:
>> Obviously, they represent separate CVS commits to doc-view.el, but on
>> the same day, so Tassilo put them into the same ChangeLog entry. The
>> result is counterintuitive, but I'm not sure what else he should do.
>> Create a separate ChangeLog entry with the same date? Do we have a
>> policy for how to handle this?
>
> Does it matter? Either seems clear enough, for a human reader, at
> least.
It's just confusing because there is an implicit one-to-one mapping
between ChangeLog top-level entries and CVS commits. While I can
discard this assumption if advised to, I'm pretty sure it's one many
developers would share, especially those unfamiliar with Emacs's
unusual ChangeLog policy (i.e., virtually every incoming developer).
When I read Tassilo's entry, I hit that first mention of doc-view.el
and assumed I'd seen everything Tassilo did to that file on that day.
That caused me to spend a bit of time being confused, because I knew
there should be more. Eventually I saw what I was looking for, later
in the entry.
Personally, I'm going to make a separate top-level entry in ChangeLog
for each commit of mine. I don't know whether I'll bother to defactor
Tassilo's entry, though ("mattress in the road" problem and all that).
-Karl
next prev parent reply other threads:[~2008-01-02 9:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-02 8:58 ChangeLog policy for same-day changes to a file? Karl Fogel
2008-01-02 7:06 ` Miles Bader
2008-01-02 9:39 ` Karl Fogel [this message]
2008-01-02 7:46 ` Miles Bader
2008-01-03 9:50 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bq84r2fk.fsf@red-bean.com \
--to=kfogel@red-bean.com \
--cc=emacs-devel@gnu.org \
--cc=miles@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.