From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bastien Newsgroups: gmane.emacs.devel Subject: Re: bookmark.el and lisp/gnus/gnus-bookmark.el Date: Fri, 07 Mar 2008 14:13:53 +0000 Message-ID: <87bq5qhba6.fsf@bzg.ath.cx> References: <874pbj682f.fsf@red-bean.com> <87zltbhbq8.fsf@bzg.ath.cx> <87iqzzigv6.fsf@bzg.ath.cx> <87ejan7xhq.fsf@member.fsf.org> <87hcfi3egg.fsf@bzg.ath.cx> <87abla8w6b.fsf@member.fsf.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1204899377 13138 80.91.229.12 (7 Mar 2008 14:16:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 7 Mar 2008 14:16:17 +0000 (UTC) Cc: Karl Fogel , Stefan Monnier , Reiner Steib , emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 07 15:16:41 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JXdNA-0007yW-91 for ged-emacs-devel@m.gmane.org; Fri, 07 Mar 2008 15:16:33 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JXdMb-0005f8-Bz for ged-emacs-devel@m.gmane.org; Fri, 07 Mar 2008 09:15:57 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JXdLG-000463-50 for emacs-devel@gnu.org; Fri, 07 Mar 2008 09:14:34 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JXdLA-0003xO-SB for emacs-devel@gnu.org; Fri, 07 Mar 2008 09:14:33 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JXdLA-0003wP-H0 for emacs-devel@gnu.org; Fri, 07 Mar 2008 09:14:28 -0500 Original-Received: from nf-out-0910.google.com ([64.233.182.186]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JXdL7-0002t0-Sr for emacs-devel@gnu.org; Fri, 07 Mar 2008 09:14:28 -0500 Original-Received: by nf-out-0910.google.com with SMTP id f5so266519nfh.26 for ; Fri, 07 Mar 2008 06:14:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:received:from:to:cc:subject:in-reply-to:references:user-agent:date:message-id:mime-version:content-type:sender; bh=TmGxlslmIOKMQ68rfw7ajzBO1iU0/x+Vj8be1w0A8qg=; b=JBXMBLHAYuXtH0Gunwx6h1xLLqXOFoCq44+tCUeYW4FZWmB9EM3r1cWNQdE9ngVe7Hl8kXq0UI5kjBIoczFWFevrs4qbPtKf8kA1gfnbkNvw90wDWl5ePFKi/KaG/Rk0la0pYZDqIqRbZf+HOFEX618iRwZSgPzLkB25FMsOieQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:user-agent:date:message-id:mime-version:content-type:sender; b=n4N4OpkRf/aQ+dZHx5YMLA+1/TdeZFFO5vIc9eHGJ0jBJ4ppWOA+FgKpxoK2/NwlvTi80URESqY3Gj7rVrCpSRrkJG5I+/tGbTkTwggGv3w65eu7MLw6qOgErLG3OmkNd/zQtCizYvC3iyAx5bUpUivcMIUbZN9PPPhV8VgEtMw= Original-Received: by 10.78.121.2 with SMTP id t2mr3889270huc.32.1204899258647; Fri, 07 Mar 2008 06:14:18 -0800 (PST) Original-Received: from bzg.ath.cx ( [81.99.213.34]) by mx.google.com with ESMTPS id c24sm7648804ika.10.2008.03.07.06.14.05 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 07 Mar 2008 06:14:14 -0800 (PST) Original-Received: by bzg.ath.cx (Postfix, from userid 1000) id D9158157920; Fri, 7 Mar 2008 14:13:53 +0000 (GMT) In-Reply-To: <87abla8w6b.fsf@member.fsf.org> (Tassilo Horn's message of "Fri, 07 Mar 2008 15:07:24 +0100") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:91632 Archived-At: Tassilo Horn writes: >>> Hm, looking at the code `bookmark-buffer-file-name' is only called >>> for buffers that don't have `bookmark-make-record-function' set >>> locally, so I don't see why you would need that? >> >> I think you mean: `bookmark-make-cell-function', right? > > Nope, Karl has renamed it to bookmark-make-record-function. No, there is both bookmark-make-record-function (line 466) bookmark-make-cell-function (line 741) >> Now a mode can define `bookmark-make-cell-function' so that it tells >> bookmark.el how to set the name of the bookmark. > > Now it's bookmark-make-record-function, but that has been there (as > b-m-cell-f) for a while now... I think there is a misunderstanding somewhere. bookmark-make-record-function makes the *record* depending on the mode we are in. But so far, there way no other way to get the *name* of the bookmark than to rely on `bookmark-buffer-file-name'. Now the local value of `bookmark-make-cell-function' is first checked, in case the mode sets this specifically. > And others can't follow while others talk. :-) :) Hopes it's clearer now... -- Bastien