From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] nested imenu support for which-func Date: Sat, 27 Sep 2008 15:53:14 -0400 Message-ID: <87bpy9icwl.fsf@cyd.mit.edu> References: <200809251702.48660.danc@merrillpress.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1222545166 28672 80.91.229.12 (27 Sep 2008 19:52:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 27 Sep 2008 19:52:46 +0000 (UTC) Cc: emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 27 21:53:43 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KjfrL-0005AM-DS for ged-emacs-devel@m.gmane.org; Sat, 27 Sep 2008 21:53:43 +0200 Original-Received: from localhost ([127.0.0.1]:57183 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KjfqI-0004GF-RY for ged-emacs-devel@m.gmane.org; Sat, 27 Sep 2008 15:52:38 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KjfqD-0004Dl-CA for emacs-devel@gnu.org; Sat, 27 Sep 2008 15:52:33 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KjfqC-0004DS-VW for emacs-devel@gnu.org; Sat, 27 Sep 2008 15:52:33 -0400 Original-Received: from [199.232.76.173] (port=54086 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KjfqC-0004DJ-Te for emacs-devel@gnu.org; Sat, 27 Sep 2008 15:52:32 -0400 Original-Received: from cyd.mit.edu ([18.115.2.24]:45942) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KjfqC-000394-7O for emacs-devel@gnu.org; Sat, 27 Sep 2008 15:52:32 -0400 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 9941E57E32F; Sat, 27 Sep 2008 15:53:14 -0400 (EDT) In-Reply-To: <200809251702.48660.danc@merrillpress.com> (Daniel Colascione's message of "Thu, 25 Sep 2008 17:02:48 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:104198 Archived-At: Daniel Colascione writes: > As it is in 22.1, which-func only looks one level down the imenu tree. This > patch has it look down all branches. In addition, there's a new variable, > which-func-imenu-joiner-function. It's called with the names of all > the levels of imenu that which-func had to traverse to reach the given > function. By default, which-func just uses the deepest name; that matches > existing behavior. Looks OK to me. I don't have access to CVS right now; could someone help check it in?