From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#1488: 23.0.60; dired-pop-to-buffer: use fit-window-to-buffer Date: Fri, 05 Dec 2008 18:27:20 +0100 Message-ID: <87bpvqttvr.fsf@escher.local.home> References: <87fxl446mr.fsf@escher.local.home> <493939C0.7010507@gmx.at> Reply-To: Stephen Berman , 1488@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1228499471 7585 80.91.229.12 (5 Dec 2008 17:51:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 5 Dec 2008 17:51:11 +0000 (UTC) Cc: 1488@emacsbugs.donarmstrong.com To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 05 18:52:13 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L8eqG-0007kb-Rk for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Dec 2008 18:51:53 +0100 Original-Received: from localhost ([127.0.0.1]:40447 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L8ep6-0000yL-Dm for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Dec 2008 12:50:40 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L8eon-0000oK-NO for bug-gnu-emacs@gnu.org; Fri, 05 Dec 2008 12:50:22 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L8eol-0000mz-Jy for bug-gnu-emacs@gnu.org; Fri, 05 Dec 2008 12:50:20 -0500 Original-Received: from [199.232.76.173] (port=36894 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L8eol-0000mq-C0 for bug-gnu-emacs@gnu.org; Fri, 05 Dec 2008 12:50:19 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:37885) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L8eok-0000fh-PK for bug-gnu-emacs@gnu.org; Fri, 05 Dec 2008 12:50:19 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB5HoDUl000668; Fri, 5 Dec 2008 09:50:14 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mB5HZ3ST028901; Fri, 5 Dec 2008 09:35:03 -0800 X-Loop: don@donarmstrong.com Resent-From: Stephen Berman Original-Sender: steve@escher.local.home Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 05 Dec 2008 17:35:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1488 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1488-submit@emacsbugs.donarmstrong.com id=B1488.122849805127511 (code B ref 1488); Fri, 05 Dec 2008 17:35:03 +0000 Original-Received: (at 1488) by emacsbugs.donarmstrong.com; 5 Dec 2008 17:27:31 +0000 Original-Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id mB5HRReb027505 for <1488@emacsbugs.donarmstrong.com>; Fri, 5 Dec 2008 09:27:29 -0800 Original-Received: (qmail invoked by alias); 05 Dec 2008 17:27:21 -0000 Original-Received: from i59F557B6.versanet.de (EHLO escher.local.home) [89.245.87.182] by mail.gmx.net (mp056) with SMTP; 05 Dec 2008 18:27:21 +0100 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX192pSUKbA12IX28lKOxpsHf2Z/vIGcCLqPyKdwrTV HjnP8GkgxgHqKc Original-Received: by escher.local.home (Postfix, from userid 1000) id 0F90D7FF56; Fri, 5 Dec 2008 18:27:20 +0100 (CET) In-Reply-To: <493939C0.7010507@gmx.at> (martin rudalics's message of "Fri, 05 Dec 2008 15:25:04 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-Y-GMX-Trusted: 0 X-FuHaFi: 0.67 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Fri, 05 Dec 2008 12:50:20 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:22986 Archived-At: On Fri, 05 Dec 2008 15:25:04 +0100 martin rudalics wrote: > `fit-window-to-buffer' seems broken in a number of regards. I'll > eventually put condition-cases around the `enlarge-window' calls. > Could you, so far, try whether the attached patch improves things. You're referring to the parenthetical note below my patch, right? So I tested my patched version of dired-pop-to-buffer after applying your patch. The result is that dired-pop-to-buffer does not raise an error if I shrink the frame to a size too small to show all marked files, irrespective of the presence or absence of a header line; in both cases I can shrink the frame until only one file can be shown. That is, your patch makes the behavior of dired-pop-to-buffer (with my patch) uniformly like the behavior with a header line without your patch. Is that what you intend? Steve Berman