Re: Integrate sr-speedbar.el with speedbar.el

[Andy Stewart <lazycat.manatee@gmail.com>]

Hi Richard,

Thanks for you bug report.
About "bug 2", that's my mistake.
Now fix it.

About "bug 1" and "bug 3", i can't reproducte it.
Please send more details step to reproducte it.

BTW, send me or "Sebastian Rose" immediately if you find any bug, don't follow this post.

Thank you very much!

  -- Andy

richardeng <richardeng@foxmail.com> writes:

> Andy Stewart wrote:
>> Hi all,
>>
>> Speedbar is very useful for file browser or other programming.
>> But this have a big problem is, speedbar is show in other frame.
>> So need switch between two frame, not very convenient.
>>
>> And have a exist extension sr-speedbar.el (write by "Sebastian Rose")
>> can make speedbar show in same frame.
>>
>> Find it at: http://www.emacswiki.org/emacs/download/sr-speedbar.el
>>
>> I'm another developer of sr-speedbar.
>> I have attached newest version of sr-speedbar.
>>
>> I want to integrate sr-speedbar with speedbar.
>> "Sebastian Rose" and me were sign copyright of FSF.
>>
>> Any suggestion?
>>
>>   -- Andy
>>
>>   
> I love this feature, it's useful in console.
>
>
> Bug 1: eval (sr-speedbar-close) twice, then (sr-speedbar-open) got following error:
> Window width 0 too small (after splitting)
>
> So, check sr-speedbar before real closing: ----------------------- 
> diff -c /tmp/sr-speedbar.el\~ /tmp/sr-speedbar.el                                    ---
> /tmp/sr-speedbar.el~   2008-11-06 07:57:08.000000000 -0800                                    +++
> /tmp/sr-speedbar.el    2008-11-06 07:59:21.000000000 -0800                                    @@
> -270,16 +270,17 @@
>   (interactive)
> (let ((current-window (selected-window)))
> (if (and sr-speedbar-window
> -           speedbar-buffer
> -           (window-live-p sr-speedbar-window) ;when `sr-speedbar-window' visible
> -           (buffer-live-p speedbar-buffer))   ;and contain `speedbar-buffer'
> -       (sr-speedbar-select-window)
> -      (if (> (current-window-take-width) 1) ;if width of `sr-speedbar-window' is a valid value
> -         (setq sr-speedbar-width (current-window-take-width))) ;remember it make next restore same
> width      -      (bury-buffer)
> -      (if (and current-window
> -              (window-live-p current-window))
> -        (select-window current-window)))))
> +            speedbar-buffer
> +            (window-live-p sr-speedbar-window) ;when `sr-speedbar-window' visible
> +            (buffer-live-p speedbar-buffer))   ;and contain `speedbar-buffer'
> +       (progn
> +         (sr-speedbar-select-window)
> +         (if (> (current-window-take-width) 1) ;if width of `sr-speedbar-window' is a valid value
> +             (setq sr-speedbar-width (current-window-take-width))) ;remember it make next restore
> same width  +         (bury-buffer)
> +         (if (and current-window
> +                  (window-live-p current-window))
> + (select-window current-window))))))
>
>                                                                  Bug 2: trivial bug
> ;;; Installation:                                                                     ;;
> ;; Copy sr-speedbar.el to your load-path and add to your ~/.emacs                     ;;
> ;;  (require 'sr-speedbar)                                                            ;;
> (global-set-key (kbd "s-s") 'sr-speedbar-togge)             		// --> toggle
> ;;                                                                                    ;; ... or any
> key binding you like.                                                
>
>
>
> Bug 3: (speedbar) then (sr-speedbar-open) report error "Wrong type argument: stringp, nil"