From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Seltenreich Newsgroups: gmane.emacs.bugs Subject: bug#3597: 23.0.94; [PATCH] org-store-link broken within kbd macros Date: Wed, 17 Jun 2009 13:15:38 +0200 Message-ID: <87bponi011.fsf__49573.981765616$1245239077$gmane$org@gate450.dyndns.org> Reply-To: Andreas Seltenreich , 3597@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1245239077 25189 80.91.229.12 (17 Jun 2009 11:44:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 17 Jun 2009 11:44:37 +0000 (UTC) Cc: emacs-orgmode@gnu.org To: emacs-pretest-bug@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 17 13:44:33 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MGtZA-0000Tr-8K for geb-bug-gnu-emacs@m.gmane.org; Wed, 17 Jun 2009 13:44:32 +0200 Original-Received: from localhost ([127.0.0.1]:33039 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MGtZ9-0000sG-Jp for geb-bug-gnu-emacs@m.gmane.org; Wed, 17 Jun 2009 07:44:31 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MGtSO-00064e-4z for bug-gnu-emacs@gnu.org; Wed, 17 Jun 2009 07:37:32 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MGtSI-00061s-Ev for bug-gnu-emacs@gnu.org; Wed, 17 Jun 2009 07:37:30 -0400 Original-Received: from [199.232.76.173] (port=41329 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MGtSG-00061V-Va for bug-gnu-emacs@gnu.org; Wed, 17 Jun 2009 07:37:25 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:49620) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MGtSG-0001fW-8w for bug-gnu-emacs@gnu.org; Wed, 17 Jun 2009 07:37:24 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5HBbKhH029616; Wed, 17 Jun 2009 04:37:21 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n5HBK6GB026541; Wed, 17 Jun 2009 04:20:06 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Andreas Seltenreich Original-Sender: Andreas Seltenreich Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 17 Jun 2009 11:20:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 3597 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.124523735726222 (code B ref -1); Wed, 17 Jun 2009 11:20:05 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 17 Jun 2009 11:15:57 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5HBFqEI026216 for ; Wed, 17 Jun 2009 04:15:54 -0700 Original-Received: from mail.gnu.org ([199.232.76.166]:32915 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MGt7Q-0007kO-Bm for emacs-pretest-bug@gnu.org; Wed, 17 Jun 2009 07:15:52 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MGt7O-0006lp-6m for emacs-pretest-bug@gnu.org; Wed, 17 Jun 2009 07:15:51 -0400 Original-Received: from smtp1.rz.uni-karlsruhe.de ([129.13.185.217]:51788) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MGt7N-0006kG-Nu; Wed, 17 Jun 2009 07:15:50 -0400 Original-Received: from rzstud2.stud.uni-karlsruhe.de (rzstud2.stud.uni-karlsruhe.de [193.196.41.42]) by smtp1.rz.uni-karlsruhe.de with esmtps (Exim 4.63 #1) id 1MGt7E-0008EB-BJ; Wed, 17 Jun 2009 13:15:40 +0200 Original-Received: from uwi7 by rzstud2.stud.uni-karlsruhe.de with local (Exim 4.63) (envelope-from ) id 1MGt7E-0007Q9-1Y; Wed, 17 Jun 2009 13:15:40 +0200 User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.94 (gnu/linux) X-Hashcash: 1:26:090617:emacs-pretest-bug@gnu.org::NszLJ23tsr6NUMFK:000000002eMFd X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Wed, 17 Jun 2009 07:37:30 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:28766 Archived-At: > Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list. > Please describe exactly what actions triggered the bug > and the precise symptoms of the bug: org-store-link works fine when recording a keyboard macro but it is a NOP when executing it. The following change appears to fix it. regards, andreas > In GNU Emacs 23.0.94.1 (x86_64-unknown-linux-gnu) > of 2009-05-28 on tengen --8<---------------cut here---------------start------------->8--- *** org.el.~1.48.~ 2009-02-20 10:02:49.000000000 +0100 --- org.el 2009-06-17 12:55:15.000000000 +0200 *************** *** 6594,6600 **** desc (or desc cpltxt)) (if (equal desc "NONE") (setq desc nil)) ! (if (and (interactive-p) link) (progn (setq org-stored-links (cons (list link desc) org-stored-links)) --- 6594,6600 ---- desc (or desc cpltxt)) (if (equal desc "NONE") (setq desc nil)) ! (if (and (or (interactive-p) executing-kbd-macro) link) (progn (setq org-stored-links (cons (list link desc) org-stored-links)) --8<---------------cut here---------------end--------------->8---