* bug#3597: 23.0.94; [PATCH] org-store-link broken within kbd macros
@ 2009-06-17 11:15 Andreas Seltenreich
0 siblings, 0 replies; 4+ messages in thread
From: Andreas Seltenreich @ 2009-06-17 11:15 UTC (permalink / raw)
To: emacs-pretest-bug; +Cc: emacs-orgmode
> Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.
> Please describe exactly what actions triggered the bug
> and the precise symptoms of the bug:
org-store-link works fine when recording a keyboard macro but it is a
NOP when executing it. The following change appears to fix it.
regards,
andreas
> In GNU Emacs 23.0.94.1 (x86_64-unknown-linux-gnu)
> of 2009-05-28 on tengen
--8<---------------cut here---------------start------------->8---
*** org.el.~1.48.~ 2009-02-20 10:02:49.000000000 +0100
--- org.el 2009-06-17 12:55:15.000000000 +0200
***************
*** 6594,6600 ****
desc (or desc cpltxt))
(if (equal desc "NONE") (setq desc nil))
! (if (and (interactive-p) link)
(progn
(setq org-stored-links
(cons (list link desc) org-stored-links))
--- 6594,6600 ----
desc (or desc cpltxt))
(if (equal desc "NONE") (setq desc nil))
! (if (and (or (interactive-p) executing-kbd-macro) link)
(progn
(setq org-stored-links
(cons (list link desc) org-stored-links))
--8<---------------cut here---------------end--------------->8---
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: bug#3597: 23.0.94; [PATCH] org-store-link broken within kbd macros
2009-06-27 0:43 ` bug#3597: [Orgmode] " Stefan Monnier
@ 2009-06-27 9:38 ` Carsten Dominik
0 siblings, 0 replies; 4+ messages in thread
From: Carsten Dominik @ 2009-06-27 9:38 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-orgmode, 3597, Andreas Seltenreich
Thanks, I'll check it out.
- Carsten
On Jun 27, 2009, at 2:43 AM, Stefan Monnier wrote:
>>> This sounds like interactive-p is working as documented and the
>>> excplicit check I proposed would be neccessary.
>> True enough, and I am applying your fix.
>
> IIUC you may want to use called-interactively-p instead.
>
>
> Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#3597: 23.0.94; [PATCH] org-store-link broken within kbd macros
2009-06-17 11:15 Andreas Seltenreich
2009-06-24 12:17 ` Carsten Dominik
2011-03-03 21:15 ` Glenn Morris
@ 2011-03-03 21:15 ` Glenn Morris
2 siblings, 0 replies; 4+ messages in thread
From: Glenn Morris @ 2011-03-03 21:15 UTC (permalink / raw)
To: 3597-done
Version: 23.2
Looks like this patch was in 23.2.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#3597: 23.0.94; [PATCH] org-store-link broken within kbd macros
2009-06-17 11:15 Andreas Seltenreich
2009-06-24 12:17 ` Carsten Dominik
@ 2011-03-03 21:15 ` Glenn Morris
2011-03-03 21:15 ` Glenn Morris
2 siblings, 0 replies; 4+ messages in thread
From: Glenn Morris @ 2011-03-03 21:15 UTC (permalink / raw)
To: 3597-done
Version: 23.2
Looks like this patch was in 23.2.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-03-03 21:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-17 11:15 bug#3597: 23.0.94; [PATCH] org-store-link broken within kbd macros Andreas Seltenreich
-- strict thread matches above, loose matches on Subject: below --
2009-06-17 11:15 Andreas Seltenreich
2009-06-24 12:17 ` Carsten Dominik
2009-06-24 12:39 ` Andreas Seltenreich
2009-06-24 12:44 ` Carsten Dominik
2009-06-27 0:43 ` bug#3597: [Orgmode] " Stefan Monnier
2009-06-27 9:38 ` bug#3597: " Carsten Dominik
2011-03-03 21:15 ` Glenn Morris
2011-03-03 21:15 ` Glenn Morris
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.