From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#4471: menu-bar menu is undefined Date: Fri, 18 Sep 2009 00:19:47 +0300 Organization: JURTA Message-ID: <87bpl96zgs.fsf@mail.jurta.org> Reply-To: Juri Linkov , 4471@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1253224087 28197 80.91.229.12 (17 Sep 2009 21:48:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 17 Sep 2009 21:48:07 +0000 (UTC) To: bug-gnu-emacs@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 17 23:48:00 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MoOpb-0004jx-KV for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Sep 2009 23:47:59 +0200 Original-Received: from localhost ([127.0.0.1]:50108 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MoOpa-0000g3-QS for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Sep 2009 17:47:58 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MoOop-00004q-0G for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 17:47:11 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MoOoj-0008Q3-V1 for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 17:47:10 -0400 Original-Received: from [199.232.76.173] (port=53422 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MoOoj-0008Ps-3G for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 17:47:05 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:48329) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MoOoi-0003rZ-9g for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 17:47:04 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8HLl1ef006537; Thu, 17 Sep 2009 14:47:01 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8HLU6XT003897; Thu, 17 Sep 2009 14:30:06 -0700 Resent-Date: Thu, 17 Sep 2009 14:30:06 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Juri Linkov Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Thu, 17 Sep 2009 21:30:06 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 4471 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12532225832857 (code B ref -1); Thu, 17 Sep 2009 21:30:06 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 17 Sep 2009 21:23:03 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8HLN1p4002854 for ; Thu, 17 Sep 2009 14:23:03 -0700 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MoORQ-0004Ix-T8 for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 17:23:00 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MoORM-0004IU-Aj for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 17:23:00 -0400 Original-Received: from [199.232.76.173] (port=33679 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MoORM-0004IR-5P for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 17:22:56 -0400 Original-Received: from smtp-out2.starman.ee ([85.253.0.4]:45777 helo=mx2.starman.ee) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MoORL-000766-Rc for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 17:22:56 -0400 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Original-Received: from mail.starman.ee (82.131.28.98.cable.starman.ee [82.131.28.98]) by mx2.starman.ee (Postfix) with ESMTP id DD6443F4119 for ; Fri, 18 Sep 2009 00:22:48 +0300 (EEST) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Thu, 17 Sep 2009 17:47:10 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31188 Archived-At: Some menu-bar's menus fail to open in non-toolkit X builds. For instance, when I click on the "Buffer-Menu" menu-bar's item, it signals the error: is undefined However, with the following patch it displays the menu correctly: Index: lisp/buff-menu.el =================================================================== RCS file: /sources/emacs/emacs/lisp/buff-menu.el,v retrieving revision 1.125 diff -u -r1.125 buff-menu.el --- lisp/buff-menu.el 15 Jan 2009 16:46:09 -0000 1.125 +++ lisp/buff-menu.el 17 Sep 2009 21:15:37 -0000 @@ -119,7 +119,7 @@ (defvar Buffer-menu-mode-map (let ((map (make-keymap)) - (menu-map (make-sparse-keymap))) + (menu-map (make-sparse-keymap "Buffer-Menu"))) (suppress-keymap map t) (define-key map "v" 'Buffer-menu-select) (define-key map "2" 'Buffer-menu-2-window) If this is the right way to define menus, I could do the same for other menus as well, e.g. Index: lisp/add-log.el =================================================================== RCS file: /sources/emacs/emacs/lisp/add-log.el,v retrieving revision 1.230 diff -u -r1.230 add-log.el --- lisp/add-log.el 1 Sep 2009 07:24:18 -0000 1.230 +++ lisp/add-log.el 17 Sep 2009 21:16:23 -0000 @@ -551,7 +551,7 @@ (defvar change-log-mode-map (let ((map (make-sparse-keymap)) - (menu-map (make-sparse-keymap))) + (menu-map (make-sparse-keymap "ChangeLog"))) (define-key map [?\C-c ?\C-p] 'add-log-edit-prev-comment) (define-key map [?\C-c ?\C-n] 'add-log-edit-next-comment) (define-key map [?\C-c ?\C-f] 'change-log-find-file) and some other menus that have no menu names. -- Juri Linkov http://www.jurta.org/emacs/