* Why was diary-fancy-display-mode conditionalized?
@ 2009-09-20 19:06 Stephen Berman
2009-09-24 3:28 ` Glenn Morris
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Berman @ 2009-09-20 19:06 UTC (permalink / raw
To: emacs-devel
As a result of this change:
2009-09-04 Glenn Morris <rgm@gnu.org>
[...]
* calendar/diary-lib.el (diary-fancy-display): Only switch modes if
necessary.
diary-fancy-display-mode-hook is only run when there is no live buffer
whose major mode is diary-fancy-display-mode; i.e., in effect, when
there is no fancy diary buffer. Previously the hook was run
unconditionally. Since calling diary-fancy-display when there is a live
fancy diary buffer erases and rewrites the buffer, but does not change
its major mode, this change means that, in this circumstance, any
functions in diary-fancy-display-mode-hook will not be called, which
can, e.g., result in a surprising change in the appearance of the fancy
diary buffer (I have such a function in diary-fancy-display-mode-hook in
my init file and was a victim of such surprise). This seems like a bug
to me, and I think the simplest fix is to revert the change; or does it
fix some other problem? If so, then how can the failure to run
diary-fancy-display-mode-hook be repaired?
Steve Berman
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Why was diary-fancy-display-mode conditionalized?
2009-09-20 19:06 Why was diary-fancy-display-mode conditionalized? Stephen Berman
@ 2009-09-24 3:28 ` Glenn Morris
2009-09-24 7:21 ` Stephen Berman
0 siblings, 1 reply; 3+ messages in thread
From: Glenn Morris @ 2009-09-24 3:28 UTC (permalink / raw
To: Stephen Berman; +Cc: emacs-devel
Stephen Berman wrote:
> This seems like a bug to me, and I think the simplest fix is to
> revert the change; or does it fix some other problem?
I can't really remember. I think it was possibly to do with preventing
a loop in some case. Anyway, I simply made sure it always runs the hook.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Why was diary-fancy-display-mode conditionalized?
2009-09-24 3:28 ` Glenn Morris
@ 2009-09-24 7:21 ` Stephen Berman
0 siblings, 0 replies; 3+ messages in thread
From: Stephen Berman @ 2009-09-24 7:21 UTC (permalink / raw
To: emacs-devel
On Wed, 23 Sep 2009 23:28:28 -0400 Glenn Morris <rgm@gnu.org> wrote:
> Stephen Berman wrote:
>
>> This seems like a bug to me, and I think the simplest fix is to
>> revert the change; or does it fix some other problem?
>
> I can't really remember. I think it was possibly to do with preventing
> a loop in some case. Anyway, I simply made sure it always runs the hook.
Thanks,
Steve Berman
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-09-24 7:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-20 19:06 Why was diary-fancy-display-mode conditionalized? Stephen Berman
2009-09-24 3:28 ` Glenn Morris
2009-09-24 7:21 ` Stephen Berman
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.