From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#5062: 23.1.50; image-toggle-display overwrites nxml-mode local key map Date: Sun, 29 Nov 2009 00:54:16 +0200 Organization: JURTA Message-ID: <87bpim8d5b.fsf@mail.jurta.org> References: <87einifskr.fsf@mail.jurta.org> Reply-To: Juri Linkov , 5062@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1259452075 2087 80.91.229.12 (28 Nov 2009 23:47:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 28 Nov 2009 23:47:55 +0000 (UTC) Cc: Brent Goodrick , 5062@emacsbugs.donarmstrong.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 29 00:47:48 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NEX11-0005DF-D6 for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Nov 2009 00:47:47 +0100 Original-Received: from localhost ([127.0.0.1]:36834 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NEX11-0004fe-4u for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Nov 2009 18:47:47 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NEX0k-0004VF-PX for bug-gnu-emacs@gnu.org; Sat, 28 Nov 2009 18:47:30 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NEX0g-0004Rl-Nx for bug-gnu-emacs@gnu.org; Sat, 28 Nov 2009 18:47:30 -0500 Original-Received: from [199.232.76.173] (port=49863 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NEX0g-0004Ri-JC for bug-gnu-emacs@gnu.org; Sat, 28 Nov 2009 18:47:26 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:60023) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NEX0g-0002gc-45 for bug-gnu-emacs@gnu.org; Sat, 28 Nov 2009 18:47:26 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nASNlN0L026310; Sat, 28 Nov 2009 15:47:23 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nASNZAlr025373; Sat, 28 Nov 2009 15:35:10 -0800 Resent-Date: Sat, 28 Nov 2009 15:35:10 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Juri Linkov Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Sat, 28 Nov 2009 23:35:10 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 5062 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 5062-submit@emacsbugs.donarmstrong.com id=B5062.125945089424805 (code B ref 5062); Sat, 28 Nov 2009 23:35:10 +0000 Original-Received: (at 5062) by emacsbugs.donarmstrong.com; 28 Nov 2009 23:28:14 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mx1.starman.ee (smtp-out3.starman.ee [85.253.0.5]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nASNSCPm024801 for <5062@emacsbugs.donarmstrong.com>; Sat, 28 Nov 2009 15:28:14 -0800 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Original-Received: from mail.starman.ee (82.131.33.180.cable.starman.ee [82.131.33.180]) by mx1.starman.ee (Postfix) with ESMTP id 2DB073F40D2; Sun, 29 Nov 2009 01:28:06 +0200 (EET) In-Reply-To: (Stefan Monnier's message of "Sat, 28 Nov 2009 15:21:49 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Sat, 28 Nov 2009 18:47:30 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:33024 Archived-At: > Better would be to save the major mode, and then switch to > "saved-major-mode + image-minor-mode". No need to modify anybody's > keymap. And I think that image-minor-mode should only be used while > displaying text: basically, image-toggle-display should toggle between > image-mode and the other major-mode (complemented with > image-minor-mode). > > That would be cleaner, I see now how this is implemented with `doc-view-previous-major-mode' in doc-view. Perhaps we should "sync" this with image-mode to use the same logic. -- Juri Linkov http://www.jurta.org/emacs/