From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: pjb@informatimago.com (Pascal J. Bourguignon) Newsgroups: gmane.emacs.help Subject: Re: Problem advising nreverse. Date: Mon, 14 Dec 2009 14:01:48 +0100 Organization: Informatimago Message-ID: <87bpi1n1z7.fsf@galatea.local> References: <87skbg8jww.fsf@galatea.local> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1260798390 16153 80.91.229.12 (14 Dec 2009 13:46:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 14 Dec 2009 13:46:30 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Mon Dec 14 14:46:23 2009 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NKBFl-0005Fi-2M for geh-help-gnu-emacs@m.gmane.org; Mon, 14 Dec 2009 14:46:22 +0100 Original-Received: from localhost ([127.0.0.1]:39466 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NKBFk-0005Z3-QC for geh-help-gnu-emacs@m.gmane.org; Mon, 14 Dec 2009 08:46:20 -0500 Original-Path: news.stanford.edu!usenet.stanford.edu!news.tele.dk!news.tele.dk!small.news.tele.dk!fu-berlin.de!uni-berlin.de!individual.net!not-for-mail Original-Newsgroups: gnu.emacs.help Original-Lines: 48 Original-X-Trace: individual.net KyMFl6w8RgxOzcU3yUkNIQKEc3yu+IccndpQ2COJ81q8DeplMD Cancel-Lock: sha1:YmNlNjIxMjkwNTExMzk1NmQ3OWVhY2Q4ZGUyYmFmOGJkNDNlZTBiYg== sha1:RRvcu9va9V75rFnd1R5CKuH3PpM= Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAQMAAABtzGvEAAAABlBMVEUAAAD///+l2Z/dAAAA oElEQVR4nK3OsRHCMAwF0O8YQufUNIQRGIAja9CxSA55AxZgFO4coMgYrEDDQZWPIlNAjwq9 033pbOBPtbXuB6PKNBn5gZkhGa86Z4x2wE67O+06WxGD/HCOGR0deY3f9Ijwwt7rNGNf6Oac l/GuZTF1wFGKiYYHKSFAkjIo1b6sCYS1sVmFhhhahKQssRjRT90ITWUk6vvK3RsPGs+M1RuR mV+hO/VvFAAAAABJRU5ErkJggg== X-Accept-Language: fr, es, en X-Disabled: X-No-Archive: no User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/22.3 (darwin) Original-Xref: news.stanford.edu gnu.emacs.help:175557 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:70634 Archived-At: Sergei Organov writes: > pjb@informatimago.com (Pascal J. Bourguignon) writes: >> Sergei Organov writes: >> >>> Hello, >>> >>> It seems that an advice set for `nreverse' function fails to be called >>> when `nreverse' is called from a byte compiled function: > > [...] > >>> Is it bug or feature? What's going on here? >> >> Indeed, it is a feature. >> >> Advices are not available from several call points: >> >> 1- when the advised function is called from C code. >> >> 2- when the advised function is a an opcode of the virtual machine. >> You can observe the difference between the two primitives nreverse >> and buffer-name for example, with: >> >> (disassemble (byte-compile (lambda (x) (nreverse x)))) >> vs.: >> (disassemble (byte-compile (lambda (x) (buffer-name x)))) >> >> In the former case, nreverse is a byte code, and therefore no >> advice applies. In the later case, buffer-name is called with the >> call byte code, which will go thru the advice. >> >> Notice that if you really want to advice such a low level primitive >> function as nreverse, you can replace it with a lisp function (and >> recompile all the code that uses it). > > Thanks a lot for the explanations and suggestion. > > Unfortunately this is not an option as intention was to advise > `nreverse' during calls to a possibly buggy `ewoc-collect' function that > for a long time errorneously called `nreverse' at the end (fixed since > 2008). Redefining nreverse and reloading the ewoc-collect function would help as indicated... -- __Pascal Bourguignon__