From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: org-src.el begin_src/end_src fontification may have been broken recently Date: Fri, 10 Jun 2011 21:51:17 +0200 Message-ID: <87boy5jwi2.fsf@gmail.com> References: <87aaebbndz.fsf@lifelogs.com> <874o4ebtq0.fsf_-_@lifelogs.com> <87vcwpsa6y.fsf@lifelogs.com> <871uzccr2k.fsf@lifelogs.com> <87lixji1mz.fsf@lifelogs.com> <87r57beyqk.fsf@lifelogs.com> <4DE90C32.7090105@swipnet.se> <871uzag6js.fsf@lifelogs.com> <4DE9228A.1010504@swipnet.se> <4DEC9C9C.2010001@swipnet.se> <877h8yfzs2.fsf@lifelogs.com> <87zkltr617.fsf_-_@lifelogs.com> <87lixak053.fsf@lifelogs.com> <871uz1eju7.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1307735524 13248 80.91.229.12 (10 Jun 2011 19:52:04 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 10 Jun 2011 19:52:04 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 10 21:52:01 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QV7kN-0004Wf-D6 for ged-emacs-devel@m.gmane.org; Fri, 10 Jun 2011 21:51:59 +0200 Original-Received: from localhost ([::1]:42441 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QV7kM-0000xm-ES for ged-emacs-devel@m.gmane.org; Fri, 10 Jun 2011 15:51:58 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:37206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QV7k4-0000xM-AD for emacs-devel@gnu.org; Fri, 10 Jun 2011 15:51:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QV7k2-0002q7-Lr for emacs-devel@gnu.org; Fri, 10 Jun 2011 15:51:40 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:59427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QV7k2-0002q1-1S for emacs-devel@gnu.org; Fri, 10 Jun 2011 15:51:38 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1QV7jw-0004KK-TT for emacs-devel@gnu.org; Fri, 10 Jun 2011 21:51:32 +0200 Original-Received: from 142.211.85.79.rev.sfr.net ([79.85.211.142]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 10 Jun 2011 21:51:32 +0200 Original-Received: from thierry.volpiatto by 142.211.85.79.rev.sfr.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 10 Jun 2011 21:51:32 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 56 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 142.211.85.79.rev.sfr.net User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:nw2I+iAg3cRB06ftrPd3OFUltbA= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 80.91.229.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:140350 Archived-At: Ted Zlatanov writes: > On Thu, 09 Jun 2011 19:20:24 -0500 Ted Zlatanov wrote: > > TZ> On Tue, 07 Jun 2011 10:54:28 -0500 Ted Zlatanov wrote: > TZ> Recently (I haven't been able to find the commit that did it) org-src.el > TZ> fontification broke. I get an error that ":-mode" could not be > TZ> executed. > > TZ> Tha attached patch fixes the problem, which is that the fontification > TZ> language is now in position 8 instead of 7, and position 7 has ":". The > TZ> fix is purely a patch, not really addressing why position 7 now has ":" > TZ> when it was the language before (there have been no commits to org.el > TZ> that could have caused this bug, AFAICT). So something in this regular > TZ> expression: > > TZ> "^\\([ \t]*#\\+\\(\\([a-zA-Z]+:?\\| \\|$\\)\\(_\\([a-zA-Z]+\\)\\)?\\)[ \t]*\\(\\([^ \t\n]*\\)[ \t]*\\(.*\\)\\)\\)" > > TZ> broke between May 28 or so and today. Which is why I made the fix as I > TZ> did, so it would keep working in places where the breakage doesn't > TZ> happen. > > Sometimes it takes days of debugging and a full patch to see the > problem: Julien Danjou is using begin/end tags like this: > > #+begin_src: emacs-lisp > #+end_src > > While I'm using (as I was shown by Julien) > > #+begin_src lisp > #+end_src > > TZ> I'd really appreciate it if someone could review and maybe commit this > TZ> patch on the Emacs side (or I can commit it if necessary). I don't > TZ> think it's an org-mode issue, but it could be breaking other people's > TZ> setups too because it triggers during fontification. > > Julien, are you using that extra ":" because it's legitimate? Or is it > an accident? What should I do with my patch? I use here: #+BEGIN_SRC lisp (defun foo (a b) (+ a b)) #+END_SRC See `anything-c-org-keywords-insert' (just commited a fix) -- A+ Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997