From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: RFC: [PATCH] isearch enhancements: symbol mode; syntactic filtering Date: Sat, 09 Jul 2011 00:50:17 +0300 Organization: JURTA Message-ID: <87box4tpba.fsf@mail.jurta.org> References: <4E15C0BA.10400@gmail.com> <081BD683079347BAB86EBC04F6E49ACB@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1310161919 19299 80.91.229.12 (8 Jul 2011 21:51:59 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 8 Jul 2011 21:51:59 +0000 (UTC) Cc: 'Daniel Colascione' , 'Lennart Borgman' , emacs-devel@gnu.org To: "Drew Adams" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 08 23:51:55 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QfIxm-0008Pk-K9 for ged-emacs-devel@m.gmane.org; Fri, 08 Jul 2011 23:51:54 +0200 Original-Received: from localhost ([::1]:42970 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QfIxl-0002Jk-R0 for ged-emacs-devel@m.gmane.org; Fri, 08 Jul 2011 17:51:54 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:59032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QfIxX-0002Jc-4L for emacs-devel@gnu.org; Fri, 08 Jul 2011 17:51:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QfIxV-00043f-Uo for emacs-devel@gnu.org; Fri, 08 Jul 2011 17:51:39 -0400 Original-Received: from smarty.dreamhost.com ([208.113.175.8]:53355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QfIxV-00043P-Ib for emacs-devel@gnu.org; Fri, 08 Jul 2011 17:51:37 -0400 Original-Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 39B936E8054; Fri, 8 Jul 2011 14:51:36 -0700 (PDT) Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 638B2451C1A5; Fri, 8 Jul 2011 14:51:30 -0700 (PDT) In-Reply-To: <081BD683079347BAB86EBC04F6E49ACB@us.oracle.com> (Drew Adams's message of "Fri, 8 Jul 2011 14:19:02 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.113.175.8 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:141825 Archived-At: >> While we are thinking about this: I think sometimes it would be good >> to search only visible text. (Especially in org-mode.) > > I thought Juri already mentioned that as one of the filtering possibilities. Yes, the default value of `isearch-filter-predicate' is `isearch-filter-visible'. But to avoid conflicts with other possible filters, it should support a list of filters and behave like e.g. `run-hook-with-args-until-success'. > Anyway, FWIW, in Isearch+, `C-+' toggles searching invisible text. So yes, I > agree with you. Trivial to do, and useful IMO. Then `C-+' could just add/remove `isearch-filter-visible' to/from `isearch-filter-predicate'.