From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 3/4] Implement cygw32 Date: Fri, 30 Dec 2011 08:56:47 +0800 Message-ID: <87boqqho6o.fsf@gnu.org> References: <5624badc7ef2eea96f90da1a823144757a5f0290.1325166472.git.dancol@dancol.org> <83oburuvzt.fsf@gnu.org> <4EFCA8FF.5080200@dancol.org> <83fwg3uts8.fsf@gnu.org> <4EFCE0A8.1080305@dancol.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1325206627 28914 80.91.229.12 (30 Dec 2011 00:57:07 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 30 Dec 2011 00:57:07 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 30 01:57:03 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RgQmM-00086l-8h for ged-emacs-devel@m.gmane.org; Fri, 30 Dec 2011 01:57:02 +0100 Original-Received: from localhost ([::1]:52467 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgQmL-0004oC-Uj for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2011 19:57:01 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:50525) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgQmJ-0004o7-BL for emacs-devel@gnu.org; Thu, 29 Dec 2011 19:57:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RgQmI-0001cY-H1 for emacs-devel@gnu.org; Thu, 29 Dec 2011 19:56:59 -0500 Original-Received: from mail-iy0-f169.google.com ([209.85.210.169]:40931) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgQmH-0001cJ-5j; Thu, 29 Dec 2011 19:56:57 -0500 Original-Received: by iacb35 with SMTP id b35so26581209iac.0 for ; Thu, 29 Dec 2011 16:56:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=0/l9kxLy9gkspP+uveO1yRhG37iJJAtj8WAPhvemaTk=; b=LzeLms26bB8ghdQIDvANQtYNVdkXltIYHoWzpzjnQ/OD6BYdcjzqGYyH+shGmPrNg4 vtPVo0n0AAfxv4XuFWcGm9vhg6D/UKuyAIxtRsZ0b0YBiNEvRNr6I0EDD+MdHKc5gAOh yetV0X0DxKR65AiFF889UjfqvzIFPrrzBQ6F8= Original-Received: by 10.50.157.131 with SMTP id wm3mr43432668igb.13.1325206616089; Thu, 29 Dec 2011 16:56:56 -0800 (PST) Original-Received: from home.jasonrumney.net ([180.75.74.4]) by mx.google.com with ESMTPS id 36sm120965861ibc.6.2011.12.29.16.56.52 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 29 Dec 2011 16:56:54 -0800 (PST) Original-Received: by home.jasonrumney.net (Postfix, from userid 1000) id C2D9416E9; Fri, 30 Dec 2011 08:56:47 +0800 (MYT) In-Reply-To: <4EFCE0A8.1080305@dancol.org> (Daniel Colascione's message of "Thu, 29 Dec 2011 13:50:32 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.210.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:147024 Archived-At: Daniel Colascione writes: > On 12/29/11 10:17 AM, Eli Zaretskii wrote: >>> Date: Thu, 29 Dec 2011 09:53:03 -0800 >>> From: Daniel Colascione >>> CC: emacs-devel@gnu.org >>> >>>>> --- a/lisp/faces.el >>>>> +++ b/lisp/faces.el >>>>> @@ -89,7 +89,7 @@ ALTERNATIVE2 etc." >>>>> ;; This is defined originally in xfaces.c. >>>>> (defcustom face-font-registry-alternatives >>>>> (mapcar (lambda (arg) (mapcar 'purecopy arg)) >>>>> - (if (eq system-type 'windows-nt) >>>>> + (if (featurep 'w32) >>>>> '(("iso8859-1" "ms-oemlatin") >>>>> ("gb2312.1980" "gb2312" "gbk" "gb18030") >>>>> ("jisx0208.1990" "jisx0208.1983" "jisx0208.1978") >>>> >>>> Why not use window-system (the function) here? >>> >>> Isn't it a little early for window-system at this point? >> >> A defcustom is evaluated more than once. So I'm a bit fuzzy about >> "too early" ;-) > > When we initialize for the first time, we won't have a GUI frame to > check, yes? (And then we dump the table into pure storage.) If there's > no facility to force reevaluation of the mapping table, we'll end up > using the wrong one when we *do* finally come up with a GUI frame. In any case, these registry mappings are not important. They used to be, because fonts were chosen based on particular registries, but now I think all script to font mappings have an appropriate iso10646 character range mapping which will work on Windows. Some of them might still serve some backwards compatibility purpose if users are using that particular registry in their .emacs, but this probably only applies to gb2312.