Re: [PATCH 3/4] Implement cygw32

[Jason Rumney <jasonr@gnu.org>]

Daniel Colascione <dancol@dancol.org> writes:

> On 12/29/11 10:17 AM, Eli Zaretskii wrote:
>>> Date: Thu, 29 Dec 2011 09:53:03 -0800
>>> From: Daniel Colascione <dancol@dancol.org>
>>> CC: emacs-devel@gnu.org
>>>
>>>>> --- a/lisp/faces.el
>>>>> +++ b/lisp/faces.el
>>>>> @@ -89,7 +89,7 @@ ALTERNATIVE2 etc."
>>>>>  ;; This is defined originally in xfaces.c.
>>>>>  (defcustom face-font-registry-alternatives
>>>>>    (mapcar (lambda (arg) (mapcar 'purecopy arg))
>>>>> -  (if (eq system-type 'windows-nt)
>>>>> +  (if (featurep 'w32)
>>>>>        '(("iso8859-1" "ms-oemlatin")
>>>>>  	("gb2312.1980" "gb2312" "gbk" "gb18030")
>>>>>  	("jisx0208.1990" "jisx0208.1983" "jisx0208.1978")
>>>>
>>>> Why not use window-system (the function) here?
>>>
>>> Isn't it a little early for window-system at this point?
>> 
>> A defcustom is evaluated more than once.  So I'm a bit fuzzy about
>> "too early" ;-)
>
> When we initialize for the first time, we won't have a GUI frame to
> check, yes? (And then we dump the table into pure storage.) If there's
> no facility to force reevaluation of the mapping table, we'll end up
> using the wrong one when we *do* finally come up with a GUI frame.

In any case, these registry mappings are not important. They used to be,
because fonts were chosen based on particular registries, but now I
think all script to font mappings have an appropriate iso10646 character
range mapping which will work on Windows.  Some of them might still
serve some backwards compatibility purpose if users are using that
particular registry in their .emacs, but this probably only applies to
gb2312.