From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: read-passwd breaks tramp Date: Wed, 18 Apr 2012 17:01:30 +0200 Message-ID: <87bompkrsl.fsf@gmx.de> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1334761321 23251 80.91.229.3 (18 Apr 2012 15:02:01 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 18 Apr 2012 15:02:01 +0000 (UTC) Cc: emacs-devel@gnu.org To: Liang Wang Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 18 17:01:59 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SKWOK-0001cp-Rv for ged-emacs-devel@m.gmane.org; Wed, 18 Apr 2012 17:01:57 +0200 Original-Received: from localhost ([::1]:46967 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SKWOH-0004uh-VD for ged-emacs-devel@m.gmane.org; Wed, 18 Apr 2012 11:01:53 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SKWO8-0004sd-Ej for emacs-devel@gnu.org; Wed, 18 Apr 2012 11:01:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SKWNy-0002YJ-6x for emacs-devel@gnu.org; Wed, 18 Apr 2012 11:01:44 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:37378) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1SKWNx-0002Xv-Tz for emacs-devel@gnu.org; Wed, 18 Apr 2012 11:01:34 -0400 Original-Received: (qmail invoked by alias); 18 Apr 2012 15:01:31 -0000 Original-Received: from p57BB97FD.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.151.253] by mail.gmx.net (mp001) with SMTP; 18 Apr 2012 17:01:31 +0200 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX1+8rMlG5nO8bFsk74IHW/bT/yg5XMEIuXGqVbp0rZ 9MHuY1BW86dTrf In-Reply-To: (Liang Wang's message of "Wed, 18 Apr 2012 17:25:22 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 213.165.64.23 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:149765 Archived-At: Liang Wang writes: > Hi, Hi, > In latest trunk, read-passwd change in revision 107874 breaks tramp. > When I try to C-x C-f /sudo::/etc/fstab RET, I can see > > Tramp: Opening connection for root@localhost using sudo...done > > in echo area. But I haven't had a chance to input password yet. In > *Messages* buffer, I can see a line of message like: > > completion--some: Command attempted to use minibuffer while in minibuffer > > By using previous version of read-passwd, I can use tramp without problems. Does the following patch fixes it? --8<---------------cut here---------------start------------->8--- *** /home/albinus/src/emacs/lisp/net/tramp.el.~107957~ --- /home/albinus/src/emacs/lisp/net/tramp.el *************** *** 3133,3143 **** (defun tramp-action-password (proc vec) "Query the user for a password." (with-current-buffer (process-buffer proc) ! (tramp-check-for-regexp proc tramp-password-prompt-regexp) ! (tramp-message vec 3 "Sending %s" (match-string 1)) ! (tramp-enter-password proc) ! ;; Hide password prompt. ! (narrow-to-region (point-max) (point-max)))) (defun tramp-action-succeed (proc vec) "Signal success in finding shell prompt." --- 3133,3144 ---- (defun tramp-action-password (proc vec) "Query the user for a password." (with-current-buffer (process-buffer proc) ! (let ((enable-recursive-minibuffers t)) ! (tramp-check-for-regexp proc tramp-password-prompt-regexp) ! (tramp-message vec 3 "Sending %s" (match-string 1)) ! (tramp-enter-password proc) ! ;; Hide password prompt. ! (narrow-to-region (point-max) (point-max))))) (defun tramp-action-succeed (proc vec) "Signal success in finding shell prompt." --8<---------------cut here---------------end--------------->8--- > Thanks, > Liang. Best regards, Michael.