From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Inclusion of naquadah-theme Date: Mon, 25 Jun 2012 21:49:41 +0800 Message-ID: <87bok7zekq.fsf@gnu.org> References: <87pq8nk8cj.fsf@zelenka.enovance.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1340632214 16232 80.91.229.3 (25 Jun 2012 13:50:14 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 25 Jun 2012 13:50:14 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 25 15:50:11 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sj9g7-0004i9-46 for ged-emacs-devel@m.gmane.org; Mon, 25 Jun 2012 15:50:07 +0200 Original-Received: from localhost ([::1]:35254 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sj9g7-0003Ia-5Y for ged-emacs-devel@m.gmane.org; Mon, 25 Jun 2012 09:50:07 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:39757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sj9fz-0003G0-3J for emacs-devel@gnu.org; Mon, 25 Jun 2012 09:50:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sj9fu-0005UI-6e for emacs-devel@gnu.org; Mon, 25 Jun 2012 09:49:58 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:57345) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sj9fu-0005UE-2f for emacs-devel@gnu.org; Mon, 25 Jun 2012 09:49:54 -0400 Original-Received: from cm162.gamma80.maxonline.com.sg ([202.156.80.162]:37088 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1Sj9fs-0001VZ-1e for emacs-devel@gnu.org; Mon, 25 Jun 2012 09:49:53 -0400 In-Reply-To: <87pq8nk8cj.fsf@zelenka.enovance.com> (Julien Danjou's message of "Mon, 25 Jun 2012 12:13:16 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151151 Archived-At: Julien Danjou writes: > I'd like to distribute my color theme more widely and therefore include > it in Emacs distribution. I don't know what the inclusion constraints > are, so I'm sending this here for review. > > http://git.naquadah.org/?p=naquadah-theme.git;a=blob;f=naquadah-theme.el;h=ea9e1b1aba1bac6631e7577e5fc4217ad699d779;hb=HEAD Please have a better description in the first line than "A color theme", since this serves as the accompanying text in the M-x customize-themes buffer. Likewise the docstring to deftheme, which is shown with the describe-theme command. Do not set ansi-term-color-vector directly with setq. If you find the need to customize it, please fix it right: submit a patch to term.el that converts this to a defcustom, then use custom-theme-set-variables. Having defuns in a theme file is obnoxious. Could you explain what these functions are needed for? If there is missing functionality, we should incorporate that directly into Emacs; they should not be naquadah-specific.