From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#14254: 24.3; read-number fails to recognize faulty numbers (string-to-number to blame) Date: Wed, 24 Apr 2013 23:57:18 +0300 Organization: JURTA Message-ID: <87bo93abt8.fsf@mail.jurta.org> References: <87ehe0ayf9.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1366837381 12495 80.91.229.3 (24 Apr 2013 21:03:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 24 Apr 2013 21:03:01 +0000 (UTC) Cc: 14254@debbugs.gnu.org To: Vitalie Spinu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 24 23:03:05 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UV6qG-0004Rg-Ub for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Apr 2013 23:03:05 +0200 Original-Received: from localhost ([::1]:46828 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV6qG-0005Pa-Jh for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Apr 2013 17:03:04 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49198) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV6qC-0005PK-3S for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2013 17:03:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UV6qA-0001Oh-R2 for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2013 17:03:00 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37525) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV6qA-0001OY-Nq for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2013 17:02:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UV6v4-0003I9-1D for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2013 17:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Apr 2013 21:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14254 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14254-submit@debbugs.gnu.org id=B14254.136683768012644 (code B ref 14254); Wed, 24 Apr 2013 21:08:01 +0000 Original-Received: (at 14254) by debbugs.gnu.org; 24 Apr 2013 21:08:00 +0000 Original-Received: from localhost ([127.0.0.1]:41634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UV6v2-0003Hs-31 for submit@debbugs.gnu.org; Wed, 24 Apr 2013 17:08:00 -0400 Original-Received: from ps18281.dreamhost.com ([69.163.218.105]:36296 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UV6uz-0003Hk-Ke for 14254@debbugs.gnu.org; Wed, 24 Apr 2013 17:07:58 -0400 Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id ABA0F258B9E91C; Wed, 24 Apr 2013 14:02:51 -0700 (PDT) In-Reply-To: <87ehe0ayf9.fsf@gmail.com> (Vitalie Spinu's message of "Wed, 24 Apr 2013 14:46:50 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73654 Archived-At: > Try (read-number "Number: ") and insert some non-numeric junk. The > expected behavior is for the read-number to recognize the faulty string > and ask again, like documented in (elisp) Interactive Codes: > > `n' > A number, read with the minibuffer. If the input is not a number, > the user has to try again. `call-interactively' doesn't use `read-number'. It duplicates code from `read-number' with a similar loop to re-read non-numbers. However, it uses `read' instead of `string-to-number'. So I agree it's better to revert the regression and to use `read' in both `read-number' and `call-interactively' for consistency. BTW, while comparing `read-number' and `call-interactively' I noticed a difference between them. Try to evaluate: (defun read-num (n) (interactive "nNumber: ") (message "Number: %s" n)) then `M-x read-num RET non-number RET' clears the prompt to the empty string. This is because `callint_message' is a global variable whose value gets cleared while reading a number from the minibuffer recursively. It should be re-initialized before re-reading the next number. Since this bug is not a regression, I propose to install this patch to trunk: === modified file 'src/callint.c' --- src/callint.c 2013-02-27 07:42:43 +0000 +++ src/callint.c 2013-04-24 20:54:52 +0000 @@ -692,6 +692,11 @@ (at your option) any later version. { message1 ("Please enter a number."); sit_for (make_number (1), 0, 0); + /* Re-initialize callint_message for next iteration. */ + if (strchr (SSDATA (visargs[0]), '%')) + callint_message = Fformat (i, visargs); + else + callint_message = visargs[0]; } first = 0;