From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: org-crypt bug and other org inconveniences.
Date: Wed, 20 Nov 2013 15:20:13 +0100 [thread overview]
Message-ID: <87bo1fkvdu.fsf@gmail.com> (raw)
In-Reply-To: <jwvhab7dwp4.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 20 Nov 2013 08:44:16 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> Note that this warning is not necessarily a problem. Actually, I tend
>>> to think we should just get rid of this warning (which I added, a few
>>> years ago).
>> Yes, setting a var locally already let-bounded works actually.
>> But it is not what the documentation say.
>
>> ,----
>> | Making a variable buffer-local within a `let'-binding for that
>> | variable does not work reliably, unless the buffer in which you do
>> | this is not current either on entry to or exit from the `let'.
>> | This is because `let' does not distinguish between different kinds
>> | of bindings; it knows only which variable the binding was made for.
>> `----
>
> The documentation is indeed rather conservative. But it is true that
> over the years many bugs were found in this area (and fixed).
> AFAIK there are no remaining bugs in this area (no proof of it, but
> I did try to consider "all possible cases"), *but* the "right behavior"
> in some cases is not always completely well-defined. E.g.:
>
> <...global value of x = 1...>
> (let ((x 2))
> (make-local-variable 'x))
>
> After this code (default-value 'x) should have value 1.
> But what about the buffer-local value of x?
>
> So the above comment basically tries to scare coders away from mixing
> let-bindings and buffer-local bindings, because "there be dragons".
Agree. I have fixed all my code last year according to your warning.
So probably it is good to keep the warning and fix all the code that
trigger it ?
The patch about org-crypt does this (It is in my .emacs for months now).
>>> BTW, why not try to push Helm's support for Org to Org, i.e. make Org
>>> support Helm, rather than the other way around?
>> Sure, but I don't think org developers want to maintain/develop code
>> depending on external applications.
>> Emacs developers too I think, (AFAIK sending a patch to emacs handling
>> external dependencies have been always refused).
>
> If the interface is sufficiently clean and generic, I'd definitely
> consider it. Can't speak for Org people.
Ok I will remember it, thanks.
> PS: Last time we talked about including Helm in GNU ELPA, there were
> issues about copyright, IIRC. If those issues are mostly in the various
> mode-specific support files, we could focus on integrating the
> infrastructure part of Helm separately.
I have modified now most of the code during last two years.
But part of this code is still from somebody else even if massively
modified, so I don't know.
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
next prev parent reply other threads:[~2013-11-20 14:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 15:51 org-crypt bug and other org inconveniences Thierry Volpiatto
2013-11-19 16:41 ` Bastien
2013-11-20 7:32 ` Thierry Volpiatto
2013-11-21 8:31 ` Thierry Volpiatto
2013-11-21 9:07 ` Bastien
2013-11-19 18:10 ` Stefan Monnier
2013-11-20 7:45 ` Thierry Volpiatto
2013-11-20 13:44 ` Stefan Monnier
2013-11-20 14:20 ` Thierry Volpiatto [this message]
2013-11-20 18:29 ` Bastien
2013-11-20 18:30 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bo1fkvdu.fsf@gmail.com \
--to=thierry.volpiatto@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.