From: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
To: 16236@debbugs.gnu.org
Subject: bug#16236: 24.3.50; [PATCH] eww: Don't set local value.
Date: Tue, 24 Dec 2013 16:37:50 +0900 [thread overview]
Message-ID: <87bo06n1gx.fsf@dhcp-193-97.nrt.redhat.com> (raw)
This report includes a patch to the bug. Please, review and install it
to the official tree if appreciated.
Now, eww-history-mode does not work well.
eww-history and eww-history-position should not be local value, since eww will
use them in eww-history-mode.
Or, just deleting two lines will work well.
- (setq-local eww-history nil)
- (setq-local eww-history-position 0)
Kenjiro
Signed-off-by: Kenjiro NAKAYAMA <knakayam@redhat.com>
* net/eww.el (eww-mode): Don't set local value to eww-history and eww-history-position.
Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
---
lisp/net/eww.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 89a7eb9..fdf5aca 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -467,8 +467,8 @@ word(s) will be searched for via `eww-search-prefix'."
(setq-local eww-current-source nil)
(setq-local browse-url-browser-function 'eww-browse-url)
(setq-local after-change-functions 'eww-process-text-input)
- (setq-local eww-history nil)
- (setq-local eww-history-position 0)
+ (setq eww-history nil)
+ (setq eww-history-position 0)
(when (boundp 'tool-bar-map)
(setq-local tool-bar-map eww-tool-bar-map))
(buffer-disable-undo)
--
1.8.3.1
Kenjiro NAKAYAMA
next reply other threads:[~2013-12-24 7:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 7:37 Kenjiro NAKAYAMA [this message]
2013-12-24 7:54 ` bug#16236: 24.3.50; [PATCH] eww: Don't set local value Lars Ingebrigtsen
2013-12-28 15:00 ` bug#16236: 24.3.50; [PATCH] eww: eww-history-mode fixup Kenjiro NAKAYAMA
2014-01-05 9:27 ` Lars Magne Ingebrigtsen
2014-07-17 7:06 ` bug#16279: " Ivan Shmakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bo06n1gx.fsf@dhcp-193-97.nrt.redhat.com \
--to=nakayamakenjiro@gmail.com \
--cc=16236@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.