From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andrzej P Newsgroups: gmane.emacs.bugs Subject: bug#16366: 24.3.50; [PATCH] GDB Registers buffer - wrong values fontified Date: Mon, 06 Jan 2014 00:35:04 +0000 Message-ID: <87bnzqvtfr.fsf@andrzej-laptop.i-did-not-set--mail-host-address--so-tickle-me> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1388969119 32342 80.91.229.3 (6 Jan 2014 00:45:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 6 Jan 2014 00:45:19 +0000 (UTC) To: 16366@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 06 01:45:25 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VzyJm-0006b5-Gn for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Jan 2014 01:45:22 +0100 Original-Received: from localhost ([::1]:59989 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzyJm-00043W-43 for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Jan 2014 19:45:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33378) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzyJb-00043B-5N for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2014 19:45:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VzyJT-0000nV-0s for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2014 19:45:11 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51564) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzyJS-0000mU-U2 for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2014 19:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VzyJS-0007pX-3q for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2014 19:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrzej P Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jan 2014 00:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16366 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.138896908530051 (code B ref -1); Mon, 06 Jan 2014 00:45:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Jan 2014 00:44:45 +0000 Original-Received: from localhost ([127.0.0.1]:37350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzyJA-0007od-D0 for submit@debbugs.gnu.org; Sun, 05 Jan 2014 19:44:45 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58879) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzyB3-0007aC-Lm for submit@debbugs.gnu.org; Sun, 05 Jan 2014 19:36:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VzyAv-0007H2-91 for submit@debbugs.gnu.org; Sun, 05 Jan 2014 19:36:21 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:37318) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzyAv-0007Gv-6b for submit@debbugs.gnu.org; Sun, 05 Jan 2014 19:36:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzyAm-00029B-P8 for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2014 19:36:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VzyAe-00079s-KU for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2014 19:36:04 -0500 Original-Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:51224) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzyAe-00078G-Ca for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2014 19:35:56 -0500 Original-Received: from mfilter28-d.gandi.net (mfilter28-d.gandi.net [217.70.178.159]) by relay4-d.mail.gandi.net (Postfix) with ESMTP id 5C411172081 for ; Mon, 6 Jan 2014 01:35:51 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter28-d.gandi.net Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by mfilter28-d.gandi.net (mfilter28-d.gandi.net [10.0.15.180]) (amavisd-new, port 10024) with ESMTP id SzCuzUp1EuEB for ; Mon, 6 Jan 2014 01:35:49 +0100 (CET) X-Originating-IP: 109.157.16.36 Original-Received: from andrzej-laptop (host109-157-16-36.range109-157.btcentralplus.com [109.157.16.36]) (Authenticated sender: andrzej@morgangilbert.co.uk) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 87EC5172085 for ; Mon, 6 Jan 2014 01:35:49 +0100 (CET) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Sun, 05 Jan 2014 19:44:43 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:83036 Archived-At: When stepping through a program with the GDB graphical interface, the values in the Registers buffer are fontified with 'font-lock-warning-face' on the step *after* they have changed. It makes more sense to highlight changed values on each step. I guess that this is a bug. To reproduce: $ emacs -Q M-x gdb gdb -i=mi emacs (or something suitable) M-x gdb-display-registers-buffer In GUD buffer: (gdb) break main (gdb) run Now step by machine instructions (e.g. 'C-x C-a C-i'). The values of registers in the Registers buffer change but are fontified only on the following step. The reason is that in 'gdb-update', 'gdb-changed-registers' is updated *after* the buffers are updated. Switching the order of the two operations as in the following patch solves the problem. === modified file 'lisp/progmodes/gdb-mi.el' --- lisp/progmodes/gdb-mi.el 2014-01-01 07:43:34 +0000 +++ lisp/progmodes/gdb-mi.el 2014-01-05 23:08:27 +0000 @@ -1890,10 +1890,11 @@ ;; gdb-break-list is maintained in breakpoints handler (gdb-get-buffer-create 'gdb-breakpoints-buffer) + (gdb-get-changed-registers) + (unless no-proc (gdb-emit-signal gdb-buf-publisher 'update)) - (gdb-get-changed-registers) (when (and (boundp 'speedbar-frame) (frame-live-p speedbar-frame)) (dolist (var gdb-var-list) (setcar (nthcdr 5 var) nil)) In GNU Emacs 24.3.50.3 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2) of 2014-01-05 on andrzej-laptop Bzr revision: 115879 tsdh@gnu.org-20140105201713-769mykhrpcny4oja Windowing system distributor `The X.Org Foundation', version 11.0.11103000 System Description: Trisquel 6.0 Important settings: value of $LC_MONETARY: en_GB.UTF-8 value of $LC_NUMERIC: en_GB.UTF-8 value of $LC_TIME: en_GB.UTF-8 value of $LANG: en_GB.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: M-x r e p o r t SPC e m Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns mail-prsvr mail-utils time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind gfilenotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs)