all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tassilo Horn <tsdh@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Yuta Yamada <cokesboy@gmail.com>, emacs-devel@gnu.org
Subject: Re: mykie.el
Date: Thu, 09 Jan 2014 09:13:38 +0100	[thread overview]
Message-ID: <87bnzl374d.fsf@gnu.org> (raw)
In-Reply-To: <jwv7gaalair.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 08 Jan 2014 11:11:04 -0500")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Shall I name this `define-key-contextual' or something else?
>
> I don't see anything "define-key ish" in there.  It's a macro that
> lets you define a *command*.

FWIW, I'd much prefer the define-key-like approach you've suggested
earlier this thread (sorry, can't look it up right now), i.e., where you
can add different clauses separately.  Ideally, it would be cool if it
allowed to define the same key in different keymaps and still be working
as expected.  E.g.:

  (define-context-key outline-minor-mode-map (kbd "TAB")
    :predicate outline-heading-p
    :action org-cycle)

  (define-context-key emacs-lisp-mode-map (kbd "TAB")
    :predicate beginning-of-defun-p
    :action eval-defun)

And then in a elisp buffer with outline-minor-mode enabled, if I'm on a
outline heading, it would cycle through the outline states, if I'm at
the beginning of a defun, if would eval it, and if I'm on neither of
those, then it does what TAB would do usually.

I already do have such a macro, but it doesn't allow defining multiple
separate predicate-action combos for the same key.  Falling back to the
"do what TAB would do by default" does work, however.  (Actually, you
helped me implementing it.)

--8<---------------cut here---------------start------------->8---
(defmacro th/define-context-key (keymap key dispatch)
  "Define KEY in KEYMAP to execute according to DISPATCH.

DISPATCH is a form that is evaluated and should return the
command to be executed.

If DISPATCH returns nil, then the command normally bound to KEY
will be executed.

Example:

  (th/define-context-key hs-minor-mode-map
     (kbd \"<C-tab>\")
     (cond
      ((not (hs-already-hidden-p))
       'hs-hide-block)
      ((hs-already-hidden-p)
       'hs-show-block)))

This will make <C-tab> show a hidden block.  If the block is
shown, then it'll be hidden."
  `(define-key ,keymap ,key
     `(menu-item "context-key" ignore
                 :filter ,(lambda (&optional ignored)
                            ,dispatch))))
--8<---------------cut here---------------end--------------->8---

Bye,
Tassilo



  parent reply	other threads:[~2014-01-09  8:13 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-03 20:09 mykie.el Ted Zlatanov
2014-01-03 21:37 ` mykie.el Bozhidar Batsov
2014-01-04  1:08   ` mykie.el Yuta Yamada
2014-01-06 22:47     ` mykie.el, mykie.el Ted Zlatanov
2014-01-06 23:00       ` enable MELPA & Marmalade by defaul [was: mykie.el] Drew Adams
2014-01-06 23:42         ` Óscar Fuentes
2014-01-07  0:29           ` Drew Adams
2014-01-07  1:08             ` Eric Brown
2014-01-07  5:39               ` Drew Adams
2014-01-07  8:33                 ` Nic Ferrier
2014-01-07  8:38                 ` David Kastrup
2014-01-07 14:41                 ` Grim Schjetne
2014-01-07 15:12                   ` Stephen Berman
2014-01-07 17:44                     ` Drew Adams
2014-01-07 20:55                       ` Stephen Berman
2014-01-08 11:52                         ` Tassilo Horn
2014-01-08 13:19                           ` David Kastrup
2014-01-08 14:02                     ` Stefan Monnier
2014-01-08 17:19                       ` enable MELPA & Marmalade by defaul Glenn Morris
2014-01-07 17:44                   ` enable MELPA & Marmalade by defaul [was: mykie.el] Drew Adams
2014-01-08  3:41                     ` Richard Stallman
2014-01-08  4:26                       ` Bob Bobeck
2014-01-08 10:50                       ` Nic Ferrier
2014-01-08 17:54                         ` Achim Gratz
2014-01-09  3:00                           ` Andy Moreton
2014-01-09  6:55                             ` Nic Ferrier
2014-01-09  7:55                           ` Tassilo Horn
2014-01-09 11:24                             ` chad
2014-01-09 18:15                             ` Achim Gratz
2014-01-08  3:23                   ` Stephen J. Turnbull
2014-01-08 10:32                     ` David Kastrup
2014-01-07 16:53             ` Richard Stallman
2014-01-08  3:15               ` Stephen J. Turnbull
2014-01-08  9:27                 ` Richard Stallman
     [not found]           ` <<a62bb795-44d9-44dd-b17a-d5294c21d2b0@default>
     [not found]             ` <<E1W0Zto-0000A5-VX@fencepost.gnu.org>
2014-01-07 17:44               ` Drew Adams
2014-01-07 16:16         ` Ted Zlatanov
2014-01-07 17:44           ` Drew Adams
2014-01-08  3:41             ` Richard Stallman
2014-01-04  2:02   ` mykie.el Yuta Yamada
2014-01-04  4:34 ` mykie.el Stefan Monnier
2014-01-04  8:36   ` mykie.el Leo Liu
2014-01-05  8:10   ` mykie.el Mitchel Humpherys
2014-01-05 10:29     ` mykie.el Leo Liu
2014-01-06 16:09   ` mykie.el Nicolas Richard
2014-01-06 22:38   ` mykie.el Ted Zlatanov
2014-01-07  0:37     ` mykie.el Stefan Monnier
2014-01-07 23:21       ` mykie.el Ted Zlatanov
2014-01-08  3:24         ` mykie.el Stefan Monnier
2014-01-08 15:44           ` mykie.el Ted Zlatanov
2014-01-08 16:11             ` mykie.el Stefan Monnier
2014-01-08 16:38               ` mykie.el Ted Zlatanov
2014-01-08 17:24                 ` mykie.el Stefan Monnier
2014-01-09  8:13               ` Tassilo Horn [this message]
2014-01-09 15:29                 ` mykie.el Stefan Monnier
2014-01-09 18:43                   ` mykie.el Yuta Yamada
2014-01-11 20:23                   ` mykie.el Yuta Yamada
2014-01-12 14:45                     ` mykie.el Stefan Monnier
2014-01-12 18:32                       ` mykie.el Yuta Yamada
2014-01-12 19:46                         ` mykie.el Stefan Monnier
2014-01-12 22:51                           ` mykie.el Yuta Yamada
2014-01-13  3:38                             ` mykie.el Stefan Monnier
2014-01-13  4:59                               ` mykie.el Yuta Yamada
2014-01-13 14:03                                 ` mykie.el Stefan Monnier
2014-01-13 16:09                                   ` mykie.el Yuta Yamada
2014-01-08 21:21             ` mykie.el Yuta Yamada
2014-01-06  5:31 ` mykie.el Yuta Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bnzl374d.fsf@gnu.org \
    --to=tsdh@gnu.org \
    --cc=cokesboy@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.