From: Karl Fogel <kfogel@red-bean.com>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: Obsolete code in savehist
Date: Wed, 16 Apr 2014 23:34:13 +0800 [thread overview]
Message-ID: <87bnw1b85m.fsf@floss.red-bean.com> (raw)
In-Reply-To: <CAAeL0SSy22fo5KsOAoB8jgToKr2fY1xVu-5GxbzguGxZ4UB7HA@mail.gmail.com> (Juanma Barranquero's message of "Fri, 21 Feb 2014 23:25:39 +0100")
I finally got around to this:
| revno: 116979
| revision-id: kfogel@red-bean.com-20140416064636-l1a8ff3q21x5l2q5
| committer: Karl Fogel <kfogel@red-bean.com>
| timestamp: Wed 2014-04-16 14:46:36 +0800
| message:
| * savehist.el (savehist-save): Remove workaround for a read-passwd
| bug that was fixed before 24.3. Thanks to Juanma Barranquero for
| noticing that the shim was still present.
Hilariously, my original reply agreeing to do it was based on my
misreading Juanma's original Subject line. He wrote "savehist" but
somehow I read "saveplace" (which I feel much more responsibility to
maintain), and I only realized my mistake after I got into the code and
nothing looked familiar. But anyway it was an easy shim removal.
Best,
-K
Juanma Barranquero <lekktu@gmail.com> writes:
>On Fri, Feb 21, 2014 at 10:20 PM, Karl Fogel <kfogel@red-bean.com> wrote:
>
>> Have you by any chance verified that
>> the bug is no longer present, though?
>
>No, I haven't verified it. In theory, it is fixed though.
>
>2012-06-22 Stefan Monnier <monnier@iro.umontreal.ca>
>
> * subr.el (read-passwd): Don't use a history at all.
> * savehist.el (savehist-save): Remove password saved accidentally
> because of the above bug.
prev parent reply other threads:[~2014-04-16 15:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 2:48 Obsolete code in savehist Juanma Barranquero
2014-02-21 21:20 ` Karl Fogel
2014-02-21 22:25 ` Juanma Barranquero
2014-02-21 23:26 ` Karl Fogel
2014-02-24 19:58 ` Stefan Monnier
2014-04-16 15:34 ` Karl Fogel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnw1b85m.fsf@floss.red-bean.com \
--to=kfogel@red-bean.com \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.