From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nicolas Richard Newsgroups: gmane.emacs.bugs Subject: bug#18096: 24.3.92; async shell command and a busy buffer leads to error Date: Thu, 24 Jul 2014 14:13:06 +0200 Message-ID: <87bnsf6jl9.fsf@geodiff-mac3.ulb.ac.be> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1406203954 11899 80.91.229.3 (24 Jul 2014 12:12:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 24 Jul 2014 12:12:34 +0000 (UTC) To: 18096@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 24 14:12:27 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XAHso-0004rI-8L for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Jul 2014 14:12:26 +0200 Original-Received: from localhost ([::1]:49623 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAHsn-0006r7-NT for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Jul 2014 08:12:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAHsa-0006pH-Kd for bug-gnu-emacs@gnu.org; Thu, 24 Jul 2014 08:12:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XAHsQ-0008No-Qk for bug-gnu-emacs@gnu.org; Thu, 24 Jul 2014 08:12:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41248) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAHsQ-0008Nk-O5 for bug-gnu-emacs@gnu.org; Thu, 24 Jul 2014 08:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XAHsQ-0003WR-Ct for bug-gnu-emacs@gnu.org; Thu, 24 Jul 2014 08:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nicolas Richard Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Jul 2014 12:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18096 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.140620391313523 (code B ref -1); Thu, 24 Jul 2014 12:12:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Jul 2014 12:11:53 +0000 Original-Received: from localhost ([127.0.0.1]:36514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XAHsD-0003Vy-63 for submit@debbugs.gnu.org; Thu, 24 Jul 2014 08:11:53 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45753) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XAHs7-0003Ve-ES for submit@debbugs.gnu.org; Thu, 24 Jul 2014 08:11:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XAHrs-0007xl-AB for submit@debbugs.gnu.org; Thu, 24 Jul 2014 08:11:38 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:53884) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAHrs-0007xh-7O for submit@debbugs.gnu.org; Thu, 24 Jul 2014 08:11:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAHrk-0006l4-Gv for bug-gnu-emacs@gnu.org; Thu, 24 Jul 2014 08:11:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XAHrd-0007p3-0x for bug-gnu-emacs@gnu.org; Thu, 24 Jul 2014 08:11:20 -0400 Original-Received: from mxin.ulb.ac.be ([164.15.128.112]:47245) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAHrc-0007op-Rm for bug-gnu-emacs@gnu.org; Thu, 24 Jul 2014 08:11:12 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvcGAJD20FOkD4Xx/2dsb2JhbABZs3wBAQEBAQEGnhGEOneFPzQBBIkJARSZIJEYjXABiAUXhXuCIodLhDAFlxSLJI09g0o7 Original-Received: from mathsrv4.ulb.ac.be (HELO geodiff-mac3.ulb.ac.be) ([164.15.133.241]) by smtp.ulb.ac.be with ESMTP; 24 Jul 2014 14:11:11 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.92 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91770 Archived-At: Running the following and answering "yes" to the prompt leads to an error: (let ((b (get-buffer-create "Some command"))) (shell-command "sleep 1 &" b) (shell-command ":&" b)) Debugger entered--Lisp error: (wrong-type-argument stringp #) generate-new-buffer-name(#) generate-new-buffer(#) (setq buffer (generate-new-buffer (or output-buffer "*Async Shell Command*"))) [hand-edited] shell-command(":&" #) I suggest the following in order to have a better error message : --- a/lisp/simple.el +++ b/lisp/simple.el @@ -2904,7 +2904,8 @@ the use of a shell (with its need to quote arguments)." (error "Shell command in progress"))) ((eq async-shell-command-buffer 'confirm-new-buffer) ;; If will create a new buffer, query first. - (if (yes-or-no-p "A command is running in the default buffer. Use a new buffer? ") + (if (and (stringp output-buffer) + (yes-or-no-p "A command is running in the default buffer. Use a new buffer? ")) (setq buffer (generate-new-buffer (or output-buffer "*Async Shell Command*"))) (error "Shell command in progress"))) -- Nico.