From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Engster Newsgroups: gmane.emacs.bugs Subject: bug#18494: 24.4.50; defclass creates undocumented *-list-p function Date: Sat, 20 Sep 2014 12:41:25 +0200 Message-ID: <87bnqavaju.fsf@engster.org> References: <87a95xvfuy.fsf@tromey.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1411209753 17808 80.91.229.3 (20 Sep 2014 10:42:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 20 Sep 2014 10:42:33 +0000 (UTC) Cc: 18494@debbugs.gnu.org, Eric Ludlam To: Tom Tromey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 20 12:42:26 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XVI7W-0007KG-HX for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Sep 2014 12:42:26 +0200 Original-Received: from localhost ([::1]:34108 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVI7V-0002zX-Pg for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Sep 2014 06:42:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55441) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVI7M-0002zF-IV for bug-gnu-emacs@gnu.org; Sat, 20 Sep 2014 06:42:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XVI7E-0003Vq-9B for bug-gnu-emacs@gnu.org; Sat, 20 Sep 2014 06:42:16 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54847) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVI7D-0003V2-Rh for bug-gnu-emacs@gnu.org; Sat, 20 Sep 2014 06:42:08 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XVI78-00066L-9y for bug-gnu-emacs@gnu.org; Sat, 20 Sep 2014 06:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: David Engster Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Sep 2014 10:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18494 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18494-submit@debbugs.gnu.org id=B18494.141120970823433 (code B ref 18494); Sat, 20 Sep 2014 10:42:02 +0000 Original-Received: (at 18494) by debbugs.gnu.org; 20 Sep 2014 10:41:48 +0000 Original-Received: from localhost ([127.0.0.1]:46411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XVI6t-00065t-9w for submit@debbugs.gnu.org; Sat, 20 Sep 2014 06:41:47 -0400 Original-Received: from randomsample.de ([5.45.97.173]:37432) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XVI6p-00065f-0P for 18494@debbugs.gnu.org; Sat, 20 Sep 2014 06:41:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=randomsample.de; s=a; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=k074HnPT+TdJhm+eA2EwH6KU/G7n+lqyNb6fQfgkHjM=; b=IeIHqGgyB2BEExHV0NUiYA8LEugGAmeNi2JRzE+6csifhR6ApB9cAWgQSzCuBqWsxCLFWlihQqeg6ttyA7D1PfpczvHh7vT6miLGfYY2AtyRfbX3YCLnn8JfiHXa3pDV; Original-Received: from dslc-082-082-164-097.pools.arcor-ip.net ([82.82.164.97] helo=desk) by randomsample.de with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XVI6j-0003sn-BB; Sat, 20 Sep 2014 12:41:40 +0200 In-Reply-To: <87a95xvfuy.fsf@tromey.com> (Tom Tromey's message of "Wed, 17 Sep 2014 20:09:57 -0600") User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.3.93 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93552 Archived-At: [add CC Eric] Tom Tromey writes: > Try: > > (defclass zzz-whatever () ((hi))) > > Now notice there is a new function: > > (symbol-function 'zzz-whatever-list-p) > (lambda (obj) "Test OBJ to see if it a list of objects which are a child of type zzz-whatever" (when (listp obj) (let ((ans t)) (while (and obj ans) (setq ans (and (eieio-object-p (car obj)) (object-of-class-p (car obj) zzz-whatever))) (setq obj (cdr obj))) ans))) > > > This new -list-p function is not documented in the EIEIO manual. > > It seems to me that it would be a bit better not to define it. > It doesn't seem generally useful enough, to me. I agree it's not generally useful. It was added as a helper function to validate a slot which should hold a list of objects (as part of the EIEIO/EDE security fix for Emacs 23.4). At least that's what I remember. I was under the impression that eieio-persistent-validate/fix-slot-value would use this, but I cannot see it; maybe it's just hidden very well. If it is not used, I'd agree that it should better be removed or at least renamed to X--list-p. Eric, WDYT? -David