bug#18638: 24.3.94; resizing of whindow by dragging the modeline does not work under xterm

bug#18638: 24.3.94; resizing of whindow by dragging the modeline does not work under xterm

[olaf]

Hi,

I can not resize windows by dragging the mode-line under xterm:

This test was made with a fresh install from the bzr repositiory, xterm version
is 300:

emacs -nw -Q
M-x xterm-mouse-mode RET
C-x 2
Move mouse to upper mode-line.
Click and drag with mouse button 1.
Release mouse button .

Result: At the release of the mouse button the upper window will get a
hight of 3 lines, irrespective of the dragging amount.






In GNU Emacs 24.3.94.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8)
 of 2014-10-05 on blaubaer
Repository revision: 117555 sdl.web@gmail.com-20141005005838-oyl694hqhu2d3632
System Description:	Ubuntu 14.04.1 LTS

Configured using:
 `configure --prefix /home/olaf/local --with-x-toolkit=gtk3
 --without-gconf --without-gsettings'

Important settings:
  value of $LANG: de_DE.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  xterm-mouse-mode: t
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
ESC [ > 4 1 ; 3 0 0 ; 0 c ESC ] 1 1 ; r g b : 3 3 3 
3 / 3 3 3 3 / 3 3 3 3 ESC \ ESC x x t - m o TAB RET 
C-x 2 ESC [ < 0 ; 3 8 ; 4 6 M ESC [ < 0 ; 3 8 ; 2 2 
m ESC [ < 0 ; 3 8 ; 5 M ESC [ < 0 ; 3 8 ; 1 5 m ESC 
x r e p o r TAB RET

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Xterm-Mouse mode enabled

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util help-fns mail-prsvr mail-utils cus-start cus-load xt-mouse xterm
time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment lisp-mode prog-mode register page menu-bar
rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax
facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak
czech european ethiopic indian cyrillic chinese case-table epa-hook
jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button
faces cus-face macroexp files text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process dbusbind gfilenotify dynamic-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs)

Memory information:
((conses 16 83963 6158)
 (symbols 48 18559 0)
 (miscs 40 33 113)
 (strings 32 10759 4307)
 (string-bytes 1 274520)
 (vectors 16 7129)
 (vector-slots 8 341892 32639)
 (floats 8 72 546)
 (intervals 56 175 16)
 (buffers 960 11)
 (heap 1024 16984 745))

bug#18638: 24.3.94; resizing of whindow by dragging the modeline does not work under xterm

[Glenn Morris]

olaf wrote:

> emacs -nw -Q
> M-x xterm-mouse-mode RET
> C-x 2
> Move mouse to upper mode-line.
> Click and drag with mouse button 1.
> Release mouse button .
>
> Result: At the release of the mouse button the upper window will get a
> hight of 3 lines, irrespective of the dragging amount.

I see this in 24.3.94 but not 24.3, so it seems to be a new issue.

bug#18638: 24.3.94; resizing of whindow by dragging the modeline does not work under xterm

[Stefan Monnier]

>> Result: At the release of the mouse button the upper window will get a
>> hight of 3 lines, irrespective of the dragging amount.
> I see this in 24.3.94 but not 24.3, so it seems to be a new issue.

Indeed, the reason is that mouse.el now uses mouse-pixel-position
instead of mouse-position in mouse-drag-line, and xt-mouse.el uses
mouse-position-function to convince mouse-position to return useful info
in xterm frames, whereas there was no such hook for
mouse-pixel-position.

I installed a patch which fixes this by making mouse-pixel-position call
mouse-position-function as well.  I think a better patch would be to
make mouse-drag-line use the event's own position info rather than calling
mouse-pixel-position, but the corresponding patch is a bit more
fiddly, so I'll keep it for after 24.4.


        Stefan

bug#18638: 24.3.94; resizing of whindow by dragging the modeline does not work under xterm

[martin rudalics]

 > Indeed, the reason is that mouse.el now uses mouse-pixel-position
 > instead of mouse-position in mouse-drag-line, and xt-mouse.el uses
 > mouse-position-function to convince mouse-position to return useful info
 > in xterm frames, whereas there was no such hook for
 > mouse-pixel-position.

Thanks for fixing this.  I found the cause of the bug before but was too
silly to grok the purpose of `mouse-position-function'.

martin